From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU autolearn=ham autolearn_force=no version=3.4.4
Received: (qmail 6977 invoked from network); 28 Aug 2020 21:16:26 -0000
Received: from lists1.math.uh.edu (129.7.128.208)
  by inbox.vuxu.org with ESMTPUTF8; 28 Aug 2020 21:16:26 -0000
Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu)
	by lists1.math.uh.edu with smtp (Exim 4.94)
	(envelope-from <ding-owner+M37605@lists.math.uh.edu>)
	id 1kBliu-00ARnm-DP; Fri, 28 Aug 2020 16:15:48 -0500
Received: from mx2.math.uh.edu ([129.7.128.33])
	by lists1.math.uh.edu with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.94)
	(envelope-from <ding-account@m.gmane-mx.org>)
	id 1kBlio-00ARlr-Tu
	for ding@lists.math.uh.edu; Fri, 28 Aug 2020 16:15:42 -0500
Received: from quimby.gnus.org ([95.216.78.240])
	by mx2.math.uh.edu with esmtps  (TLS1.3) tls TLS_AES_256_GCM_SHA384
	(Exim 4.94)
	(envelope-from <ding-account@m.gmane-mx.org>)
	id 1kBlil-003ClH-Ax
	for ding@lists.math.uh.edu; Fri, 28 Aug 2020 16:15:42 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org;
	 s=20200322; h=Content-Transfer-Encoding:Content-Type:Mime-Version:Message-ID
	:Date:Subject:From:To:Sender:Reply-To:Cc:Content-ID:Content-Description:
	Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:
	In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
	List-Post:List-Owner:List-Archive;
	bh=NNVAsjweOFocWOcemBIC4EB5f7aDFKEz3z5fDduPjAw=; b=BCi5l2buhZSkGcdbGESCT0wubr
	mKSE8eWkN+cScakrEixTQmp+4OMzQ9PrsTqPoXEOnMSy8emgeHwBq9mBZKeXdPA1zkqwuJwCGjqOn
	QbXhuFYZR6qMvdVGrhuPlNO8UCwPZJJIw42sWaLlc4hIUhP5N5oFe+h8chUBR6FfsHJU=;
Received: from static.214.254.202.116.clients.your-server.de ([116.202.254.214] helo=ciao.gmane.io)
	by quimby with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <ding-account@m.gmane-mx.org>)
	id 1kBlid-0008Cl-Cz
	for ding@gnus.org; Fri, 28 Aug 2020 23:15:35 +0200
Received: from list by ciao.gmane.io with local (Exim 4.92)
	(envelope-from <ding-account@m.gmane-mx.org>)
	id 1kBlic-0005vQ-84
	for ding@gnus.org; Fri, 28 Aug 2020 23:15:30 +0200
X-Injected-Via-Gmane: http://gmane.org/
To: ding@gnus.org
From: =?utf-8?Q?Adam_Sj=C3=B8gren?= <asjo@koldfront.dk>
Subject: GitLab integration take two, light edition
Date: Fri, 28 Aug 2020 23:15:22 +0200
Organization: koldfront - analysis & revolution, Copenhagen, Denmark
Message-ID: <87k0xi79qt.fsf@tullinup.koldfront.dk>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
Cancel-Lock: sha1:Vws7D+SmRqElaYqmWzoOfnKlhQY=
OpenPGP: id=476630590A231909B0A0961A49D0746121BDE416; url=https://asjo.koldfront.dk/gpg.asc
Mail-Follow-Up-To: never
X-Now-Playing: Saving Grace, Saved (Bob Dylan)
X-Face: )qY&CseJ?.:=8F#^~GcSA?F=9eu'{KAFfL1C3/A&:nE?PW\i65"ba0NS)97,Q(^@xk}n4Ou
 rPuR#V8I(J_@~H($[ym:`K_+]*kjvW>xH5jbgLBVFGXY:(#4P>zVBklLbdL&XxL\M)%T}3S/IS9lMJ
 ^St'=VZBR<gm`!Dj`dIpp?+$"$l_'JKDN\w-jB;fo0Qy}Tbw
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=koldfront.dk;
	s=news; t=1598649322;
	bh=NNVAsjweOFocWOcemBIC4EB5f7aDFKEz3z5fDduPjAw=;
	h=From:Subject:Date:From;
	b=U2Y6VMPSpnyT2vTDM6/tD7n0RKCP3+qxGZJv/ZZ0ZE/+5ZMQGLtvG9aFAjBwYMtsd
	 eLoZvoRqX2EVyY99FLEDs0babDxWvPwhegQyzcWf7yFGMzmo6mA3vKtOVU993nzQ1D
	 UQ9IFLVMMcQiwjY0b+rDyg9e6p28VGBwNdgcnLXldQW8jyn4en+MkyDmz52tYKOxcM
	 Aa4lCyl94hvjrNby6uMFOGbkhlwWGDo4rEGnJHGmP6N9fd/ISaDSHoBR0Zr41p3w6g
	 lhTAVXgIZZ+CaZ5gwbxzZVI9IT7IfRee14QcsZU8+gsjmgvBInIHtQ3oyrCcVBcvsZ
	 Zjw+rd4vA5gVQ==
List-ID: <ding.gnus.org>
Precedence: bulk

A while back I mumbled about creating an nngitlab backend, and I got a
prototype working¹.

However, as predicted, it was quite slow, because checking for new
issues and comments meant an http-request per issue.

I kind of gave up on that (I should probably have tried if I could use
the GitLab API to ask for "changes since last update", but I ran out of
steam and was a little discouraged by a remark in the API documentation).

So today I lowered my level of ambition, and started by simply
implementing a function that gives a "thumbs up" to a comment, when
reading the notification email for the comment:

  (defun asjo-gitlab-give-thumbsup ()
    "Give thumbsup to current comment on a GitLab issue"
    (interactive)
    (with-current-buffer gnus-original-article-buffer
      (let ((project-id (gnus-fetch-field "X-GitLab-Project-Id"))
            (issue-iid (gnus-fetch-field "X-GitLab-Issue-IID"))
            (message-id (gnus-fetch-field "Message-ID")))
        (string-match "<note_\\([0-9]+\\)" message-id)
        (ghub-request "POST" (format "/projects/%s/issues/%s/notes/%s/award_emoji?name=thumbsup" project-id issue-iid (match-string 1 message-id)) nil :auth 'nngitlab :host "very.secret.gitlab.instance/api/v4" :username "asjo" :forge 'gitlab)
        (message "👍"))))

The new thing I wanted to do was to implement a "washing" function to
check what "award emojis" the comment I'm reading already has.

I found a comment in the manual saying that I can use
gnus-part-display-hook to add custom washing functions.

But I need some help. My feeble attempt was this:

  (defun asjo-article-treat-gitlab ()
    "Show thumbsup on GitLab comments"
    (let ((project-id (gnus-fetch-field "X-GitLab-Project-Id"))
          (issue-iid (gnus-fetch-field "X-GitLab-Issue-IID"))
          (message-id (gnus-fetch-field "Message-ID")))
      (when project-id
        (string-match "<note_\\([0-9]+\\)" message-id)
        (ignore-errors
          (let ((emoji (ghub-request "GET" (format "/projects/%s/issues/%s/notes/%s/award_emoji" project-id issue-iid (match-string 1 message-id)) nil :auth 'nngitlab :host "very.secret.gitlab.instance/api/v4" :username "asjo" :forge 'gitlab)))
            (message-goto-eoh)
            (insert "GitLab-Emoji: 👍\n")
            (message "👍"))))))

  (add-hook 'gnus-part-display-hook 'asjo-article-treat-gitlab)

There's a lot wrong here. It does a request for each part, so 3 or 4
(these are emails with both text and html MIME parts), and it puts in
the fake header in multiple places. I'm sure there are nice functions to
call to do what I want. Finding them is my issue.

Also, the request actually returns a list of the various emojis, which
ideally would be iterated over, and added to the header instead of the
hardcoded thumbs up.

Oh, and the ghub-request errors out with a 404 when there are no emojis
(funky API design), which really ought to insert an empty GitLab-Emoji:
fake header instead of just being ignored.

So the question is: how do I write a proper washing function for
"decorating" emails with the relevant X-GitLab-* headers which only does
one request per article?

Even with all the ailments of my code, it actually didn't feel slow, so
this "type" of "integration" might be a more viable way to spend less
time opening GitLab webpages and clicking various buttons.


  Best regards,

    Adam


¹ https://koldfront.dk/git/nngitlab/

-- 
 "En pessimist i sitt livs form"                            Adam Sjøgren
                                                       asjo@koldfront.dk