From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/88209 Path: news.gmane.org!.POSTED!not-for-mail From: "Garreau\, Alexandre" Newsgroups: gmane.emacs.gnus.general Subject: Two successive patches about the same function [Was: Re: message-simplify-subject too coupled with reply (and not extensible)] Date: Tue, 30 Oct 2018 13:28:52 +0100 Message-ID: <87k1lz8vp7.fsf_-_@portable.galex-713.eu> References: <87zhux7u4z.fsf@portable.galex-713.eu> <87k1m1zedm.fsf@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1540902445 13069 195.159.176.226 (30 Oct 2018 12:27:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 30 Oct 2018 12:27:25 +0000 (UTC) User-Agent: Gnus (5.13), GNU Emacs 25.1.1 (i686-pc-linux-gnu, GTK+ Version 3.22.11) of 2017-09-15, modified by Debian Cc: ding@gnus.org To: Eric Abrahamsen Original-X-From: ding-owner+M36421@lists.math.uh.edu Tue Oct 30 13:27:21 2018 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from lists1.math.uh.edu ([129.7.128.208]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gHT78-0003DM-F7 for ding-account@gmane.org; Tue, 30 Oct 2018 13:27:18 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by lists1.math.uh.edu with smtp (Exim 4.90_1) (envelope-from ) id 1gHT8t-0005pr-Ts; Tue, 30 Oct 2018 07:29:07 -0500 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by lists1.math.uh.edu with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1gHT8l-0005my-RK for ding@lists.math.uh.edu; Tue, 30 Oct 2018 07:28:59 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.90_1) (envelope-from ) id 1gHT8k-0001Uc-2N for ding@lists.math.uh.edu; Tue, 30 Oct 2018 07:28:59 -0500 Original-Received: from portable.galex-713.eu ([89.234.186.82]) by quimby.gnus.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gHT8h-0001Zr-W0 for ding@gnus.org; Tue, 30 Oct 2018 13:28:56 +0100 Original-Received: from localhost ([::1] helo=portable.galex-713.eu) by portable.galex-713.eu with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1gHT8f-0002Ek-6p; Tue, 30 Oct 2018 13:28:54 +0100 PGP-FINGERPRINT: E109 9988 4197 D7CB B0BC 5C23 8DEB 24BA 867D 3F7F Accept-Language: fr, en, eo, it, br In-Reply-To: <87k1m1zedm.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sun, 28 Oct 2018 19:16:21 -0700") X-Spam-Score: -1.9 (-) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:88209 Archived-At: On 2018-10-28 at 19:16, Eric Abrahamsen wrote: > I'm less certain about this. It's one of those cases where probably no > one remembers why it is the way it is, and no one wants to touch it > because who knows how things might suddenly break. If I were you I > would report two separate bugs, so that the first had a better chance > of being accepted. I=E2=80=99ve a question about patches: a patch mention the original version= , as long as its context, so if I end trying to submit a patch for the same function, the second will either base on the version patched by the first, either be based on original function before first patch, and then won=E2=80=99t it have problem applying after first has been applied? In our case, the second patch is about simplifying, improving and factorizing `gnus-simplify-subject', and arrives after the one stripping the =E2=80=9Cconcat "Re: "=E2=80=9D, but still having it in the version of = the function it patches. Or maybe should I report without a patch tentative? on another hand, with what I did it=E2=80=99s not that long, and I suppose at worse it=E2=80= =99s possible to ignore the (then incorrect (or rather outdated?)) patch=E2=80=A6