Gnus development mailing list
 help / color / mirror / Atom feed
From: Andrew Cohen <cohen@andy.bu.edu>
To: ding@gnus.org
Subject: Re: gnus-registry rewrite
Date: Mon, 18 Apr 2011 14:17:04 -0400	[thread overview]
Message-ID: <87k4erh1b3.fsf@andy.bu.edu> (raw)
In-Reply-To: <87mxjphv1m.fsf@andy.bu.edu> (Andrew Cohen's message of "Sun, 17 Apr 2011 09:22:29 -0400")

I think I understand the logic in
gnus-registry--split-fancy-with-parent-internal but I'm not 100%
sure. The following changes seem to fix my problem that unfollowed
groups are still followed. Ted, does this look right?

Best,
Andy

diff --git a/lisp/gnus-registry.el b/lisp/gnus-registry.el
index eab4403..ac06be1 100644
--- a/lisp/gnus-registry.el
+++ b/lisp/gnus-registry.el
@@ -453,7 +453,7 @@ See the Info node `(gnus)Fancy Mail Splitting' for more details."
         (loop for group in (gnus-registry-get-id-key reference 'group)
               when (gnus-registry-follow-group-p group)
               do (gnus-message 7 "%s traced %s to %s" log-agent reference group)
-              do (push group found)))
+               (push group found)))
       ;; filter the found groups and return them
       ;; the found groups are the full groups
       (setq found (gnus-registry-post-process-groups
@@ -478,7 +478,7 @@ See the Info node `(gnus)Fancy Mail Splitting' for more details."
                          (if gnus-registry-track-extra 7 9)
                          "%s (extra tracking) traced subject '%s' to %s"
                          log-agent subject group)
-                     collect group))
+                    and collect group))
          ;; filter the found groups and return them
          ;; the found groups are NOT the full groups
          (setq found (gnus-registry-post-process-groups
@@ -505,7 +505,7 @@ See the Info node `(gnus)Fancy Mail Splitting' for more details."
                          (if gnus-registry-track-extra 7 9)
                          "%s (extra tracking) traced sender '%s' to %s"
                          log-agent sender group)
-                     collect group)))
+                     and collect group)))
 
        ;; filter the found groups and return them
        ;; the found groups are NOT the full groups
@@ -535,7 +535,7 @@ See the Info node `(gnus)Fancy Mail Splitting' for more details."
                              (if gnus-registry-track-extra 7 9)
                              "%s (extra tracking) traced recipient '%s' to %s"
                              log-agent recp group)
-                         collect group)))))
+                        and collect group)))))
 
        ;; filter the found groups and return them
        ;; the found groups are NOT the full groups



  reply	other threads:[~2011-04-18 18:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-17 13:22 Andrew Cohen
2011-04-18 18:17 ` Andrew Cohen [this message]
2011-04-20 20:41   ` Ted Zlatanov
2011-04-20 20:48 ` Ted Zlatanov
  -- strict thread matches above, loose matches on Subject: below --
2011-04-05 16:28 Ted Zlatanov
2011-04-05 17:56 ` Ted Zlatanov
2011-04-06  8:10   ` Kan-Ru Chen
2011-04-06 10:53     ` Ted Zlatanov
2011-04-06 17:29       ` Kan-Ru Chen
2011-04-06 17:37         ` Ted Zlatanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k4erh1b3.fsf@andy.bu.edu \
    --to=cohen@andy.bu.edu \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).