From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/76615 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.gnus.general Subject: [PATCH] Fix Gcc processing on IMAP Date: Sun, 13 Feb 2011 12:11:24 +0100 Message-ID: <87k4h4dw9v.fsf@member.fsf.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: dough.gmane.org 1297595507 18447 80.91.229.12 (13 Feb 2011 11:11:47 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 13 Feb 2011 11:11:47 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M24958=ding+2Daccount=gmane.org@lists.math.uh.edu Sun Feb 13 12:11:42 2011 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PoZrh-0005AB-EI for ding-account@gmane.org; Sun, 13 Feb 2011 12:11:41 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1PoZrd-0001pA-Ph for ding-account@gmane.org; Sun, 13 Feb 2011 05:11:37 -0600 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1PoZra-0001p1-U3 for ding@lists.math.uh.edu; Sun, 13 Feb 2011 05:11:34 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtp (Exim 4.72) (envelope-from ) id 1PoZrZ-00078f-3H for ding@lists.math.uh.edu; Sun, 13 Feb 2011 05:11:34 -0600 Original-Received: from out1.smtp.messagingengine.com ([66.111.4.25]) by quimby.gnus.org with esmtp (Exim 4.72) (envelope-from ) id 1PoZrX-0001t9-QK for ding@gnus.org; Sun, 13 Feb 2011 12:11:32 +0100 Original-Received: from compute2.internal (compute2.nyi.mail.srv.osa [10.202.2.42]) by gateway1.messagingengine.com (Postfix) with ESMTP id 55CD520600 for ; Sun, 13 Feb 2011 06:11:26 -0500 (EST) Original-Received: from frontend1.messagingengine.com ([10.202.2.160]) by compute2.internal (MEProxy); Sun, 13 Feb 2011 06:11:26 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=messagingengine.com; h=from:to:subject:date:message-id:mime-version:content-type; s=smtpout; bh=EsV01ZlGoWGMwau5WfQcIX0l2gc=; b=U3XiBIPGQ7Z5n1pu76ORhvm0XOdfWHVUMv0qca8a8ZTg/1zWYb7QT2UEwZqPGdJ4fh5OVtdfCHWVUGPcuOkKVHHtI3I+uBXZFrdyHpV5y1mAYdBqm/GWI/QmDMNC+zMHjgil6L0gFVyFAqcZOxKz7FGUJbK1yHNTIK7pE33naXc= X-Sasl-enc: LgAXFunbY7qlJVBZv8h8vUofHXhk9YSwCjSUjuJfHsyq 1297595485 Original-Received: from thinkpad (95-88-32-105-dynip.superkabel.de [95.88.32.105]) by mail.messagingengine.com (Postfix) with ESMTPA id B890D400594 for ; Sun, 13 Feb 2011 06:11:25 -0500 (EST) User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) X-Spam-Score: -2.9 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:76615 Archived-At: --=-=-= Content-Type: text/plain Hi all, as I've reported in <874o8enpi0.fsf@member.fsf.org>, Gcc is broken in the current HEAD. I wanted to sit it out on an older working revision till Lars is back, but unfortunately Ted did an interface change in auth-sources that was synced to emacs, and now emacs has an autoload cookie for some auth-sources function that is not available in the older Gnus version... Since non-working Gcc is effectively data-loss, I've dug into the relevant code, and Lars seems to have added some quirk for Gmail, which breaks any IMAP except Gmail. ;-) I'm no expert with nnimap.el (in fact, 20 minutes ago I had my first look at it), but I think I could understand what Lars wanted to do. Here is a patch that fixes the Gcc issue for me. I have papers on file, but no push access for Gnus git. Could someone please commit and push for me? (I could commit & push on emacs bzr trunk, but I think this way is easier.) Bye, Tassilo --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-nnimap.el-nnimap-request-accept-article-nnimap-proce.patch >From 6573b041d072fcfacfc7b8e6ae810abeb2f361e7 Mon Sep 17 00:00:00 2001 From: Tassilo Horn Date: Sun, 13 Feb 2011 11:57:42 +0100 Subject: [PATCH] * nnimap.el (nnimap-request-accept-article, nnimap-process-quirk): Fix Gcc processing on imap. --- lisp/ChangeLog | 5 +++++ lisp/nnimap.el | 5 +++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/lisp/ChangeLog b/lisp/ChangeLog index ed68f13..1e7b35e 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,8 @@ +2011-02-13 Tassilo Horn + + * nnimap.el (nnimap-request-accept-article, nnimap-process-quirk): Fix + Gcc processing on imap. + 2011-02-10 Stefan Monnier * message.el (message-bury): Don't pop up a new window when selected diff --git a/lisp/nnimap.el b/lisp/nnimap.el index 94c8f82..be3f812 100644 --- a/lisp/nnimap.el +++ b/lisp/nnimap.el @@ -966,7 +966,8 @@ textual parts.") (nnimap-add-cr) (setq message (buffer-substring-no-properties (point-min) (point-max))) (with-current-buffer (nnimap-buffer) - (when (setq message (nnimap-process-quirk "OK Gimap " 'append message)) + (when (setq message (or (nnimap-process-quirk "OK Gimap " 'append message) + message)) ;; If we have this group open read-only, then unselect it ;; before appending to it. (when (equal (nnimap-examined nnimap-object) group) @@ -994,7 +995,7 @@ textual parts.") (defun nnimap-process-quirk (greeting-match type data) (when (and (nnimap-greeting nnimap-object) - (string-match "OK Gimap " (nnimap-greeting nnimap-object)) + (string-match greeting-match (nnimap-greeting nnimap-object)) (eq type 'append) (string-match "\000" data)) (let ((choice (gnus-multiple-choice -- 1.7.4 --=-=-=--