From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/72322 Path: news.gmane.org!not-for-mail From: Florian Ragwitz Newsgroups: gmane.emacs.gnus.general Subject: Re: [PATCH] Introduce gnus-completing-read Date: Thu, 30 Sep 2010 19:22:42 +0200 Message-ID: <87k4m3ywm5.fsf@tardis.home.perldition.org> References: <1285688153-19680-1-git-send-email-julien@danjou.info> <87wrq5ammm.fsf@tardis.home.perldition.org> <87eicdacn6.fsf@tardis.home.perldition.org> <87hbh9tx2x.fsf@keller.adm.naquadah.org> <87y6aj7mp2.fsf@marauder.physik.uni-ulm.de> <87y6aj4jjk.fsf@tardis.home.perldition.org> <87hbh74gb5.fsf@tardis.home.perldition.org> <87d3rv4fvz.fsf@tardis.home.perldition.org> <87sk0r2xzc.fsf@tardis.home.perldition.org> <87pqvv6utx.fsf@lifelogs.com> <878w2j6tp0.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Trace: dough.gmane.org 1285867424 8137 80.91.229.12 (30 Sep 2010 17:23:44 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 30 Sep 2010 17:23:44 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M20695@lists.math.uh.edu Thu Sep 30 19:23:43 2010 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P1Mr7-0006Vl-R5 for ding-account@gmane.org; Thu, 30 Sep 2010 19:23:42 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1P1Mr5-0005Be-84; Thu, 30 Sep 2010 12:23:39 -0500 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1P1Mr3-0005BO-DT for ding@lists.math.uh.edu; Thu, 30 Sep 2010 12:23:37 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.72) (envelope-from ) id 1P1Mr2-0000Ee-8N for ding@lists.math.uh.edu; Thu, 30 Sep 2010 12:23:37 -0500 Original-Received: from kief.perldition.org ([78.47.20.161]) by quimby.gnus.org with esmtp (Exim 3.36 #1 (Debian)) id 1P1Mr1-0001mP-00 for ; Thu, 30 Sep 2010 19:23:35 +0200 Original-Received: from p4fd7608c.dip.t-dialin.net ([79.215.96.140] helo=tardis.home.perldition.org) by kief.perldition.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1P1Mqz-0000El-97 for ding@gnus.org; Thu, 30 Sep 2010 19:23:34 +0200 Original-Received: from rafl by tardis.home.perldition.org with local (Exim 4.72) (envelope-from ) id 1P1MqD-00046C-QN for ding@gnus.org; Thu, 30 Sep 2010 19:22:45 +0200 Mail-Copies-To: never In-Reply-To: <878w2j6tp0.fsf@lifelogs.com> (Ted Zlatanov's message of "Thu, 30 Sep 2010 12:13:15 -0500") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.2 (gnu/linux) X-Spam_score: -3.9 X-Spam_score_int: -38 X-Spam_bar: --- X-Spam_report: Spam detection software, running on the system "kief.perldition.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Ted Zlatanov writes: > On Thu, 30 Sep 2010 19:06:08 +0200 Florian Ragwitz wrote: > > FR> This appears to be as correct as my initial version of it. However, > FR> Julien made some follow-up changes to it, fixing a bug regarding > FR> handling of history. Your version makes the same mistake I initially > FR> did. Julien's fix needs to be adapted for the new code. > > I just looked at the rev ID you mentioned. Argh. Anyhow, the point was > that it's just a small rewrite to make your patch trivial. X-Spam-Score: -1.9 (-) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:72322 Archived-At: --=-=-= Content-Type: text/plain Ted Zlatanov writes: > On Thu, 30 Sep 2010 19:06:08 +0200 Florian Ragwitz wrote: > > FR> This appears to be as correct as my initial version of it. However, > FR> Julien made some follow-up changes to it, fixing a bug regarding > FR> handling of history. Your version makes the same mistake I initially > FR> did. Julien's fix needs to be adapted for the new code. > > I just looked at the rev ID you mentioned. Argh. Anyhow, the point was > that it's just a small rewrite to make your patch trivial. Julien may > be the best person to do it to ensure it's not accidentally broken, but > I'll do it if he doesn't have the time. > > I *think* that's within the spirit of the GNU project, especially since > you (Florian) are OK with the rewrite. Absolutely. I'd rather have another patch by someone else, achieving the same thing as the original patch, than no patch at all. (Well, actually I'd much rather have contributing be easy, fun, and encouraging more contributions, but short of that, the above appears to be the next best thing.) --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAkykx2MACgkQdC8qQo5jWl58rACfUWaoe5YIbOOQ0Wvr0yp5ptlY 8xYAn0Cuxv20j+xHX8jsWC3vFj0K1ZnW =um04 -----END PGP SIGNATURE----- --=-=-=--