From: Reiner Steib <reinersteib+gmane@imap.cc>
To: Simon Josefsson <jas@extundo.com>
Cc: Frank Schmitt <ich@frank-schmitt.net>,
Stefan Monnier <monnier@iro.umontreal.ca>,
ding@gnus.org, 1174@emacsbugs.donarmstrong.com
Subject: Re: bug#1174: 23.0.60; Some UTF-8 mails displaying wrongly in Emacs 23
Date: Sat, 29 Nov 2008 13:08:20 +0100 [thread overview]
Message-ID: <87k5ampwej.fsf@marauder.physik.uni-ulm.de> (raw)
In-Reply-To: <m3ej2fdq5x.fsf@mid.gehheimdienst.de> (Frank Schmitt's message of "Fri, 17 Oct 2008 20:36:58 +0200")
On Fri, Oct 17 2008, Frank Schmitt wrote:
> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>
>> On Fri, Oct 17 2008, Stefan Monnier wrote:
>>
>>>> ;; BEWARE: we used to use string-as-multibyte here which is braindead
>>>> ;; because it will turn accidental emacs-mule-valid byte sequences
>>>> ;; into multibyte chars. --Stef
>>>> ;; Reverted, braindead got 7.5 out of 10 on imdb, so it can't be
>>>> ;; that bad. --Simon
Simon, could you please clarify why you reverted Stefan's change in
`nnimap-demule'? It breaks reading UTF-8 articles via nnimap.el in
Emacs 23.
>>> Who's this Simon who reverted my change without even explaining why?
>>
>> The one who's listed as the author of nnimap.el (cc-ed).
>>
>>>> which is called at several places. And this breaks it. If I change
>>>> this function so that string is not changed, my mails are displayed
>>>> correctly.
>>
>> Does it work correctly when using Stefan's version?
>> ( s/string-as-multibyte/string-to-multibyte/ ...)
>>
>> (defun nnimap-demule (string)
>> ;; BEWARE: we used to use string-as-multibyte here which is braindead
>> ;; because it will turn accidental emacs-mule-valid byte sequences
>> ;; into multibyte chars. --Stef
>> (funcall (if (and (fboundp 'string-to-multibyte)
>> (subrp (symbol-function 'string-to-multibyte)))
>> 'string-to-multibyte
>> 'identity)
>> (or string "")))
>
> Yes, it does.
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
next prev parent reply other threads:[~2008-11-29 12:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m37i89boe6.fsf@mid.gehheimdienst.de>
[not found] ` <jeabd5vvug.fsf@sykes.suse.de>
[not found] ` <m363ntey23.fsf@mid.gehheimdienst.de>
[not found] ` <u63nso2wk.fsf@gnu.org>
[not found] ` <jebpxjvd53.fsf@sykes.suse.de>
[not found] ` <m3ej2fd2o0.fsf@mid.gehheimdienst.de>
[not found] ` <umyh3mttj.fsf@gnu.org>
[not found] ` <m33aivfsa8.fsf@mid.gehheimdienst.de>
[not found] ` <jwv8wsnjknd.fsf-monnier+emacsbugreports@gnu.org>
2008-10-17 18:19 ` Reiner Steib
2008-10-17 18:36 ` Frank Schmitt
2008-11-29 12:08 ` Reiner Steib [this message]
2008-11-29 12:18 ` Simon Josefsson
2008-11-29 15:30 ` Reiner Steib
2008-11-29 21:30 ` Stefan Monnier
2008-11-30 13:12 ` Reiner Steib
2008-11-29 22:14 ` James Cloos
2008-11-30 13:11 ` View articles with different charset (was: bug#1174: 23.0.60; Some UTF-8 mails displaying wrongly in Emacs 23) Reiner Steib
2008-11-30 21:23 ` View articles with different charset James Cloos
2009-01-12 10:54 ` bug#1174: 23.0.60; Some UTF-8 mails displaying wrongly in Emacs 23 Simon Josefsson
2009-01-12 11:03 ` Frank Schmitt
2009-01-12 11:10 ` Simon Josefsson
2009-01-14 11:20 ` Gabor Z. Papp
2009-01-14 20:12 ` Reiner Steib
2009-01-14 22:08 ` Stefan Monnier
2008-12-01 21:04 ` Stefan Monnier
2008-12-01 22:48 ` Reiner Steib
2008-12-02 7:36 ` Stefan Monnier
2008-12-04 19:43 ` Reiner Steib
2008-12-04 21:43 ` Frank Schmitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k5ampwej.fsf@marauder.physik.uni-ulm.de \
--to=reinersteib+gmane@imap.cc \
--cc=1174@emacsbugs.donarmstrong.com \
--cc=Reiner.Steib@gmx.de \
--cc=ding@gnus.org \
--cc=ich@frank-schmitt.net \
--cc=jas@extundo.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).