Re: Sticky article buffers

[Tassilo Horn <tassilo@member.fsf.org>]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

Hi Reiner,

>> But what other free binding could be used?
>
> If we stay with the term "sticky article buffer", I'd suggest `A S'.

Will the translation from `A s' stop if I bind it to `A S'?

,----
| A s (translated from A S) runs the command gnus-summary-isearch-article
|   which is an interactive compiled Lisp function in `gnus-sum.el'.
| It is bound to s, A s, <menu-bar> <Article> <Isearch article...>.
| (gnus-summary-isearch-article &optional REGEXP-P)
| 
| Do incremental search forward on the current article.
| If REGEXP-P (the prefix) is non-nil, do regexp isearch.
`----

> Oh, please use unified diff (-u) (or context diff (-c)).

Ok.

>> 4360a4373,4378
>>> 
>>> ;; Local Variables:
>>> ;; coding: iso-8859-1
>>> ;; indent-tabs-mode: t
>>> ;; tab-width: 8
>>> ;; End:
>
> Please don't submit proposals that include unrelated changes.

Hm, how do I tell `cvs diff' which hunks it should add and which not? Or
may I simply kill those lines before I submit the patch?

>>>     (define-key gnus-sticky-article-mode-map k nil))
>>>   (define-key gnus-sticky-article-mode-map "q" 'gnus-sticky-article-kill-buffer)
>
> I'd expect `k' for kill buffer and `q' for quit (bury buffer).

Ok, I'll change that.

>>>   (define-key gnus-sticky-article-mode-map "\C-hc" 'describe-key-briefly)
>>>   (define-key gnus-sticky-article-mode-map "\C-hk" 'describe-key))
>
> Why do we need to treat these two command specially?

I'm not really sure, but I had a hard time figuring out what to do so
that `C-h m' shows all possible bindings but none that don't work with
sticky articles.

>>> (defun gnus-sticky-article-kill-buffer (&optional buffer)
>>>   "Kills the given sticky article buffer. If none is given, it'll
>>> assume the current buffer and kill it if it has
>>> `gnus-sticky-article-mode'."
> [...]
>>> (defun gnus-summary-make-sticky-article (arg)
>>>   "Make the current article sticky. If a prefix arg is given you
>>> will be asked for a name for this sticky buffer."
>
> The doc strings needs a little improvement.  Cf. `M-x checkdoc-defun
> RET'.  But I may do this after installing the patch.

I'll do that.

Bye,
Tassilo
-- 
People sometimes  ask me if it  is a sin in  the Church of  Emacs to use
vi. Using a free  version of vi is not a sin; it  is a penance. So happy
hacking. (Richard M. Stallman)