Gnus development mailing list
 help / color / mirror / Atom feed
From: Andreas Seltenreich <andreas+ding@gate450.dyndns.org>
To: ding@gnus.org
Subject: Re: Broken IMAP search with nnir.el
Date: Sun, 25 Mar 2007 22:42:01 +0200	[thread overview]
Message-ID: <87k5x5kqcm.fsf@gate450.dyndns.org> (raw)
In-Reply-To: <87odmhzx4i.fsf@gate450.dyndns.org> (Andreas Seltenreich's message of "Sun\, 25 Mar 2007 07\:54\:21 +0200")

[-- Attachment #1: Type: text/plain, Size: 782 bytes --]

I wrote:

> Simon Josefsson writes:
>
>> I think it might be easier to have nnir never re-use article numbers.
>> But I'm not familiar enough with nnir to fix this.
>
> I'm afraid this would break solid groups, which work ok for engines
> that support ordering of returned articles by delivery-date or
> something comparable instead of "Score".

Actually, the same trick that nnweb uses to avoid caching anomalies
with ephemeral groups could be applied to nnir as well.  nnweb uses
message-unique-id to generate names for ephemeral groups, and pushing
such an id into nnir's query parameters has the same effect.

Tassilo: Could you try to reproduce the problem with the attached
patch?  If the problem is actually caching related, the symptoms
should disappear.

regards,
andreas


[-- Attachment #2: Type: text/x-patch, Size: 674 bytes --]

*** nnir.el	17 Jul 2006 17:14:52 +0200	7.19
--- nnir.el	25 Mär 2007 22:21:01 +0200	
***************
*** 294,299 ****
--- 294,300 ----
  (require 'nnoo)
  (require 'gnus-group)
  (require 'gnus-sum)
+ (require 'message)
  (eval-and-compile
    (require 'gnus-util))
  (eval-when-compile
***************
*** 610,615 ****
--- 611,617 ----
      (if extra-parms
          (setq parms (nnir-read-parms query))
        (setq parms (list (cons 'query query))))
+     (add-to-list 'parms (cons 'unique-id (message-unique-id)) t)
      (gnus-group-read-ephemeral-group
       (concat "nnir:" (prin1-to-string parms)) '(nnir "") t
       (cons (current-buffer)

  reply	other threads:[~2007-03-25 20:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-22 14:19 Tassilo Horn
2007-03-22 14:26 ` Simon Josefsson
2007-03-22 15:18   ` Tassilo Horn
2007-03-23 14:52     ` Simon Josefsson
2007-03-25  5:54       ` Andreas Seltenreich
2007-03-25 20:42         ` Andreas Seltenreich [this message]
2007-03-26  8:28           ` Tassilo Horn
2007-03-26 17:39             ` Andreas Seltenreich
2007-03-26 17:53               ` Tassilo Horn
2007-03-26  8:30         ` Tassilo Horn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k5x5kqcm.fsf@gate450.dyndns.org \
    --to=andreas+ding@gate450.dyndns.org \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).