Re: nnweb fix

[Andreas Seltenreich <andreas+ding@gate450.dyndns.org>]

[-- Attachment #1: Type: text/plain, Size: 945 bytes --]

Tassilo Horn schrob:

> Tassilo Horn <heimdall@uni-koblenz.de> writes:
>
>> I can get the first and the last message of the references at google.
>
> Short addition: I can get them via Gnus' web groups (G w RET <m-id>
> RET), too.

Does that mean, fetching the articles <44291c19@news.ish.de> and
<44294aab@news.ish.de> by hitting ^ works, but fetching
<e0b918$4oc$03$4@news.t-online.com> that way does not?

While I am not able to reproduce it, I noticed that
nnweb-request-article doesn't do any URL-encoding on the
message-id. The attached patch fixes it.

Google doesn't seem to care if ?$ and ?@ are sent unencoded though,
maybe you have a proxy inbetween that cares? I suggest applying the
patch anyway, even if it turns out that it doesn't fix the problem.

regards,
andreas

2006-04-30  Andreas Seltenreich  <uwi7@rz.uni-karlsruhe.de>

	* nnweb.el (nnweb-request-article): Do proper xwfu encoding when
	fetching articles by message-id.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: nnweb.el.patch --]
[-- Type: text/x-patch, Size: 906 bytes --]

Index: nnweb.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/nnweb.el,v
retrieving revision 7.20
diff -c -r7.20 nnweb.el
*** nnweb.el	23 Apr 2006 14:12:44 -0000	7.20
--- nnweb.el	30 Apr 2006 15:32:07 -0000
***************
*** 171,177 ****
  		       (when (string-match "^<\\(.*\\)>$" article)
  			 (setq art (match-string 1 article)))
  		       (when (and fetch art)
! 			 (setq url (format fetch art))
  			 (mm-with-unibyte-current-buffer
  			   (mm-url-insert url))
  			 (if (nnweb-definition 'reference t)
--- 171,178 ----
  		       (when (string-match "^<\\(.*\\)>$" article)
  			 (setq art (match-string 1 article)))
  		       (when (and fetch art)
! 			 (setq url (format fetch
! 					   (mm-url-form-encode-xwfu art)))
  			 (mm-with-unibyte-current-buffer
  			   (mm-url-insert url))
  			 (if (nnweb-definition 'reference t)