From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/63095 Path: news.gmane.org!not-for-mail From: Andreas Seltenreich Newsgroups: gmane.emacs.gnus.general Subject: Re: nnweb fix Date: Sun, 30 Apr 2006 17:56:09 +0200 Message-ID: <87k697ukfa.fsf@gate450.dyndns.org> References: <87ejzpzybb.fsf@gate450.dyndns.org> <87y7xw6roc.fsf@baldur.nicundtas.de> <87k697nwtg.fsf@baldur.nicundtas.de> <87bqujnu0k.fsf@baldur.nicundtas.de> <874q0bnlj7.fsf@baldur.nicundtas.de> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: sea.gmane.org 1146414486 22213 80.91.229.2 (30 Apr 2006 16:28:06 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 30 Apr 2006 16:28:06 +0000 (UTC) Original-X-From: ding-owner+m11620@lists.math.uh.edu Sun Apr 30 18:28:04 2006 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FaEm6-0003LB-9u for ding-account@gmane.org; Sun, 30 Apr 2006 18:27:58 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu ident=lists) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1FaElx-00085U-00; Sun, 30 Apr 2006 11:27:49 -0500 Original-Received: from nas01.math.uh.edu ([129.7.128.39]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1FaEHV-00084M-00 for ding@lists.math.uh.edu; Sun, 30 Apr 2006 10:56:21 -0500 Original-Received: from quimby.gnus.org ([80.91.224.244]) by nas01.math.uh.edu with esmtp (Exim 4.52) id 1FaEHT-00058B-B5 for ding@lists.math.uh.edu; Sun, 30 Apr 2006 10:56:21 -0500 Original-Received: from smtp2.rz.uni-karlsruhe.de ([129.13.185.218]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1FaEHO-0001nb-00 for ; Sun, 30 Apr 2006 17:56:14 +0200 Original-Received: from rzstud1.stud.uni-karlsruhe.de (rzstud1.stud.uni-karlsruhe.de [193.196.41.33]) by smtp2.rz.uni-karlsruhe.de with esmtp (Exim 4.50 #1) id 1FaEHL-00017K-TW; Sun, 30 Apr 2006 17:56:13 +0200 Original-Received: from uwi7 by rzstud1.stud.uni-karlsruhe.de with local (Exim 3.36 #1) id 1FaEHU-0005lO-00 for ding@gnus.org; Sun, 30 Apr 2006 17:56:20 +0200 Original-To: ding@gnus.org X-Face: $:F<87a[gD1?#R6S3j21cr1&C&7bd63GHC.tSdskUb}hhwG(ci*=D5kJ<_N+p9q(7-,PnG. Et.Yh (Tassilo Horn's message of "Sun, 30 Apr 2006 17:14:04 +0200") User-Agent: Gnus/5.110005 (No Gnus v0.5) Emacs/22.0.50 (gnu/linux) X-Spam-Score: -2.6 (--) Precedence: bulk Original-Sender: ding-owner@lists.math.uh.edu Xref: news.gmane.org gmane.emacs.gnus.general:63095 Archived-At: --=-=-= Tassilo Horn schrob: > Tassilo Horn writes: > >> I can get the first and the last message of the references at google. > > Short addition: I can get them via Gnus' web groups (G w RET > RET), too. Does that mean, fetching the articles <44291c19@news.ish.de> and <44294aab@news.ish.de> by hitting ^ works, but fetching that way does not? While I am not able to reproduce it, I noticed that nnweb-request-article doesn't do any URL-encoding on the message-id. The attached patch fixes it. Google doesn't seem to care if ?$ and ?@ are sent unencoded though, maybe you have a proxy inbetween that cares? I suggest applying the patch anyway, even if it turns out that it doesn't fix the problem. regards, andreas 2006-04-30 Andreas Seltenreich * nnweb.el (nnweb-request-article): Do proper xwfu encoding when fetching articles by message-id. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=nnweb.el.patch Index: nnweb.el =================================================================== RCS file: /usr/local/cvsroot/gnus/lisp/nnweb.el,v retrieving revision 7.20 diff -c -r7.20 nnweb.el *** nnweb.el 23 Apr 2006 14:12:44 -0000 7.20 --- nnweb.el 30 Apr 2006 15:32:07 -0000 *************** *** 171,177 **** (when (string-match "^<\\(.*\\)>$" article) (setq art (match-string 1 article))) (when (and fetch art) ! (setq url (format fetch art)) (mm-with-unibyte-current-buffer (mm-url-insert url)) (if (nnweb-definition 'reference t) --- 171,178 ---- (when (string-match "^<\\(.*\\)>$" article) (setq art (match-string 1 article))) (when (and fetch art) ! (setq url (format fetch ! (mm-url-form-encode-xwfu art))) (mm-with-unibyte-current-buffer (mm-url-insert url)) (if (nnweb-definition 'reference t) --=-=-=--