Re: Gnus Agent and mail

[Gaute B Strokkenes <gs234@cam.ac.uk>]

[-- Attachment #1: Type: text/plain, Size: 991 bytes --]

On 10 mai 2003, gs234@cam.ac.uk wrote:
>On 10 mai 2003, kgreiner@xpediantsolutions.com wrote:
>>BTW, I'm actually convincing myself that gnus-agent-queue-mail is
>>the reasonable thing to do.
>
>Well, I'm having a stab at implementing it now...

And here it is.

2003-05-10  Gaute B Strokkenes <gs234@srcf.ucam.org>

	* gnus-agent.el (gnus-agent-queue-mail): New variable.
	(gnus-agent-send-mail): Use it.

	* gnus-draft.el (gnus-group-send-queue): Bind
	message-send-mail-real-function to the value of
	gnus-agent-send-mail-function when sending queued mail.

If you find this approach at all acceptable, I will start work on the
documentation.

AFAICT there is only one change in behaviour when using the default
configuration: if you hit J S in the Group buffer when unplugged, Gnus
will actually try to send any queued email rather than just rewriting
them to the queue folder.  This is arguably an improvement; if not it
is probably better to have a "are you sure" nag message anyway.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gaqm.diff --]
[-- Type: text/x-patch, Size: 1973 bytes --]

Index: lisp/gnus-agent.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-agent.el,v
retrieving revision 6.170
diff -u -r6.170 gnus-agent.el
--- lisp/gnus-agent.el	30 Apr 2003 15:04:37 -0000	6.170
+++ lisp/gnus-agent.el	10 May 2003 21:40:07 -0000
@@ -169,6 +169,15 @@
   :type '(radio (const :format "Enable " ENABLE)
                 (const :format "Disable " DISABLE)))
 
+(defcustom gnus-agent-queue-mail t
+  "Whether and when outgoing mail should be queued by the agent.  When
+`always', always queue outgoing mail.  When `nil', never queue.
+Otherwise, queue if and only if unplugged."
+  :group 'gnus-agent
+  :type '(radio (const :format "Always" always)
+		(const :format "Never" nil)
+		(const :format "When plugged" t)))
+ 
 (defcustom gnus-agent-expire-unagentized-dirs t
 "Have gnus-agent-expire scan the directories under
 \(gnus-agent-directory) for groups that are no longer agentized.  When
@@ -623,7 +632,8 @@
      'gnus-dummy '((gnus-draft-mode)))))
 
 (defun gnus-agent-send-mail ()
-  (if gnus-plugged
+  (if (or (not gnus-agent-queue-mail)
+	  (and gnus-plugged (not (eq gnus-agent-queue-mail 'always))))
       (funcall gnus-agent-send-mail-function)
     (goto-char (point-min))
     (re-search-forward
Index: lisp/gnus-draft.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-draft.el,v
retrieving revision 6.21
diff -u -r6.21 gnus-draft.el
--- lisp/gnus-draft.el	12 Apr 2003 23:09:52 -0000	6.21
+++ lisp/gnus-draft.el	10 May 2003 21:40:07 -0000
@@ -203,7 +203,8 @@
 	   article)
       (while (setq article (pop articles))
 	(unless (memq article unsendable)
-	  (let ((message-sending-message
+	  (let ((message-send-mail-real-function gnus-agent-send-mail-function)
+		(message-sending-message
 		 (format "Sending message %d of %d..."
 			 (- total (length articles)) total)))
 	    (gnus-draft-send article)))))))

[-- Attachment #3: Type: text/plain, Size: 156 bytes --]

-- 
Big Gaute                               http://www.srcf.ucam.org/~gs234/
Hand me a pair of leather pants and a CASIO keyboard
 -- I'm living for today!