Re: set-window-point in gnus-dribble-enter?

[Josh Huber <huber@alum.wpi.edu>]

Reiner Steib <4uce.02.r.steib@gmx.net> writes:

> Maybe: When I jump `j' to a group in a hidden topic, enter the group
> and copy an article to another hidden group, the last mentioned group
> (and sub-topic) appears at the bottom:
>
> [ Gnus * 893 ]
>   [ Mail --- all * 2 ]...
> ...
>   [ Documentation --- all * 0 ]...
>       [ Trash + Test * 0 ]
> *             0: Test (08.06.2002) [?0 !2]
>
> `Trash + Test' is a sub-sub-topic of `Mail --- all', so the group
> should appear near the top rather than at the bottom.

Hmm, does commenting out that line change this behavior?  I've been
running for a few days without the call to set-window-point, and
things are working fine with me.

I'm still curious as to what it would be for.  I'm also curious as to
how it doesn't break it for everyone, and why it only started
happening to me recently ;)  I run CVS XEmacs so perhaps some behavior
changed wrt. set-window-point...hmm.

Ah hah:

@@ -1757,14 +1778,20 @@

 DEFUN ("set-window-point", Fset_window_point, 2, 2, 0, /*
 Make point value in WINDOW be at position POS in WINDOW's buffer.
+If WINDOW is the selected window, this actually changes the buffer's point
+instead of the window's point. (The equivalence of the selected window's
+point with its buffer's point is maintained throughout XEmacs.)
 */
        (window, pos))
 {
   struct window *w = decode_window (window);

   CHECK_INT_COERCE_MARKER (pos);
-  if (w == XWINDOW (Fselected_window (Qnil)))
-    Fgoto_char (pos, Qnil);
+  /* Don't dereference selected-window because there may not
+     be one -- e.g. at startup */
+  if (EQ (wrap_window (w), Fselected_window (Qnil)))
+    /* Even though window selected, buffer may not be current */
+    Fgoto_char (pos, w->buffer);
   else
     set_marker_restricted (w->pointm[CURRENT_DISP], pos, w->buffer);

Of course, I'm missing the distiction between the buffer point and the
window point.

This happened in the past 6 weeks, so it seems plausible that it's the
cause of my problems. bummer.

Still, I wonder what the intended purpose of the call was?

-- 
Josh Huber