From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/44090
Path: main.gmane.org!not-for-mail
From: Raymond Scholz <ray-2002@zonix.de>
Newsgroups: gmane.emacs.gnus.general
Subject: Empty line before signature?
Date: Sat, 30 Mar 2002 22:15:54 +0100
Sender: owner-ding@hpc.uh.edu
Message-ID: <87k7rtrc39.fsf@mde1.home>
Reply-To: Raymond Scholz <rscholz@zonix.de>
NNTP-Posting-Host: localhost.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: main.gmane.org 1017523267 23825 127.0.0.1 (30 Mar 2002 21:21:07 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Sat, 30 Mar 2002 21:21:07 +0000 (UTC)
Original-Received: from malifon.math.uh.edu ([129.7.128.13])
	by main.gmane.org with esmtp (Exim 3.33 #1 (Debian))
	id 16rQHb-0006CA-00
	for <ding-account@gmane.org>; Sat, 30 Mar 2002 22:21:07 +0100
Original-Received: from sina.hpc.uh.edu ([129.7.128.10] ident=lists)
	by malifon.math.uh.edu with esmtp (Exim 3.20 #1)
	id 16rQGU-0007b6-00; Sat, 30 Mar 2002 15:19:58 -0600
Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Sat, 30 Mar 2002 15:20:04 -0600 (CST)
Original-Received: from sclp3.sclp.com (qmailr@sclp3.sclp.com [209.196.61.66])
	by sina.hpc.uh.edu (8.9.3/8.9.3) with SMTP id PAA21246
	for <ding@hpc.uh.edu>; Sat, 30 Mar 2002 15:19:51 -0600 (CST)
Original-Received: (qmail 10562 invoked by alias); 30 Mar 2002 21:17:47 -0000
Original-Received: (qmail 10556 invoked from network); 30 Mar 2002 21:17:46 -0000
Original-Received: from quimby.gnus.org (80.91.224.244)
  by gnus.org with SMTP; 30 Mar 2002 21:17:46 -0000
Original-Received: from news by quimby.gnus.org with local (Exim 3.12 #1 (Debian))
	id 16rQOp-00081E-00
	for <ding@gnus.org>; Sat, 30 Mar 2002 22:28:35 +0100
Original-To: ding@gnus.org
Original-Path: mde1.zonix.de!not-for-mail
Original-Newsgroups: gnus.ding
Original-Lines: 68
Original-NNTP-Posting-Host: b7e5a.pppool.de
Original-X-Trace: quimby.gnus.org 1017523714 30827 213.7.126.90 (30 Mar 2002 21:28:34 GMT)
Original-X-Complaints-To: usenet@quimby.gnus.org
Original-NNTP-Posting-Date: 30 Mar 2002 21:28:34 GMT
Mail-Copies-To: nobody
X-Now-Playing: Nothing
X-Face: %.!RBc`e*wW)84O*\)VdkC}mU5c2Zh$y~ZRA3K594g/jp_&5bx\Oyes!/jK~4<<%KlaPn^\
 0<bYDHHvSRxI<
User-Agent: Gnus/5.090006 (Oort Gnus v0.06) Emacs/21.2.50
 (i386-debian-linux-gnu)
Cancel-Lock: sha1:b/VubdTL6ssySiRn2d1awWJsQJI=
Precedence: list
X-Majordomo: 1.94.jlt7
Xref: main.gmane.org gmane.emacs.gnus.general:44090
X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:44090

Hi!

Occasionally I'm getting annoyed by Gnus' behaviour...  

`message-insert-signature' inserts an empty newline before the
signature separator, which is disturbing if any greeting at the bottom
of the message (see below) will be inserted via the `body' element of
my posting styles.

If this is breaking RFC1036 or any other RFC I should've read before
immediately forget the following code:

Index: texi/message.texi
===================================================================
RCS file: /usr/local/cvsroot/gnus/texi/message.texi,v
retrieving revision 6.43
diff -u -r6.43 message.texi
--- texi/message.texi	2002/03/24 22:54:53	6.43
+++ texi/message.texi	2002/03/30 21:22:11
@@ -1482,6 +1482,11 @@
 File containing the signature to be inserted at the end of the buffer.
 The default is @file{~/.signature}.
 
+@item message-signature-insert-empty-line
+@vindex message-signature-insert-empty-line
+If @code{t} (the default value) an empty line is inserted before the
+signature separator.
+
 @end table
 
 Note that RFC1036bis says that a signature should be preceded by the three
Index: lisp/message.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/message.el,v
retrieving revision 6.224
diff -u -r6.224 message.el
--- lisp/message.el	2002/03/25 20:00:57	6.224
+++ lisp/message.el	2002/03/30 21:22:30
@@ -668,6 +668,12 @@
   :type '(choice file (const :tags "None" nil))
   :group 'message-insertion)
 
+;;;###autoload
+(defcustom message-signature-insert-empty-line t
+  "*If non-nil, insert an empty line before the signature separator."
+  :type 'boolean
+  :group 'message-insertion)
+
 (defcustom message-distribution-function nil
   "*Function called to return a Distribution header."
   :group 'message-news
@@ -2199,8 +2205,10 @@
       (goto-char (point-max))
       ;; Insert the signature.
       (unless (bolp)
+	(insert "\n"))
+      (when message-signature-insert-empty-line
 	(insert "\n"))
-      (insert "\n-- \n")
+      (insert "-- \n")
       (if (eq signature t)
 	  (insert-file-contents message-signature-file)
 	(insert signature))

Cheers, Ray
-- 
WYSIWYG is a step backwards. Human labor is used to do that which the
computer can do better.                         (Andrew S. Tanenbaum)