Re: faster gnus-summary-from-or-to-or-newsgroups

[Dan Christensen <jdc+news@uwo.ca>]

[-- Attachment #1: Type: text/plain, Size: 1034 bytes --]

Dan Christensen <jdc+news@uwo.ca> writes:

> I've managed to increase the speed of summary buffer generation
> by about 20% by rewriting gnus-summary-from-or-to-or-newsgroups
> (the %n spec).

[...]

> The changes I made are:
>
> 1) call mail-header-extra only if needed, and at most once
> 2) don't do the string-match more than once
> 3) don't call gnus-decode-encode-word-function more than once
> 4) use gnus-tmp-from instead of (mail-header-from header)

[...]

> The bottleneck is probably now in mail-extract-address-components
> (what I have gnus-extract-address-components set to).  Does someone
> want to tackle speeding that up without reducing its accuracy?
>
> Also, I noticed that removing the %d spec speeds up the generation of
> my summary buffers by about 30%!  Does anyone want to try speeding up
> the corresponding function?

I signed and sent in my copyright assignment papers a couple of weeks
ago.  I've attached the above change as a patch.  Could someone apply
it?

Dan

-- 
Dan Christensen
jdc+news@uwo.ca


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnus-sum.el.patch --]
[-- Type: text/x-patch, Size: 2186 bytes --]

--- gnus-sum.el.orig	Sat Sep 29 20:29:42 2001
+++ gnus-sum.el.jdc	Sat Sep 29 20:45:54 2001
@@ -2904,32 +2904,31 @@
    (point) (progn (eval gnus-summary-dummy-line-format-spec) (point))
    (list 'gnus-number gnus-tmp-number 'gnus-intangible gnus-tmp-number)))
 
+(defun gnus-summary-extract-address-component (from)
+  (or (car (funcall gnus-extract-address-components from))
+      from))
+
 (defun gnus-summary-from-or-to-or-newsgroups (header)
-  (let ((to (cdr (assq 'To (mail-header-extra header))))
-	(newsgroups (cdr (assq 'Newsgroups (mail-header-extra header))))
-	(mail-parse-charset gnus-newsgroup-charset)
+  (let ((mail-parse-charset gnus-newsgroup-charset)
+	; Is it really necessary to do this next part for each summary line?
+	; Luckily, doesn't seem to slow things down much.
 	(mail-parse-ignored-charsets
 	 (save-excursion (set-buffer gnus-summary-buffer)
 			 gnus-newsgroup-ignored-charsets)))
-    (cond
-     ((and to
-	   gnus-ignored-from-addresses
-	   (string-match gnus-ignored-from-addresses
-			 (mail-header-from header)))
-      (concat "-> "
-	      (or (car (funcall gnus-extract-address-components
-				(funcall
-				 gnus-decode-encoded-word-function to)))
-		  (funcall gnus-decode-encoded-word-function to))))
-     ((and newsgroups
-	   gnus-ignored-from-addresses
-	   (string-match gnus-ignored-from-addresses
-			 (mail-header-from header)))
-      (concat "=> " newsgroups))
-     (t
-      (or (car (funcall gnus-extract-address-components
-			(mail-header-from header)))
-	  (mail-header-from header))))))
+    (or
+     (and gnus-ignored-from-addresses
+	  (string-match gnus-ignored-from-addresses gnus-tmp-from)
+	  (let ((extra-headers (mail-header-extra header))
+		to
+		newsgroups)
+	    (cond
+	     ((setq to (cdr (assq 'To extra-headers)))
+	      (concat "-> "
+		      (gnus-summary-extract-address-component
+		       (funcall gnus-decode-encoded-word-function to))))
+	     ((setq newsgroups (cdr (assq 'Newsgroups extra-headers)))
+	      (concat "=> " newsgroups)))))
+     (gnus-summary-extract-address-component gnus-tmp-from))))
 
 (defun gnus-summary-insert-line (gnus-tmp-header
 				 gnus-tmp-level gnus-tmp-current