Re: Slight bug in the `gnus-use-correct-string-widths' implementation.

[Daniel Pittman <daniel@rimspace.net>]

[-- Attachment #1: Type: text/plain, Size: 813 bytes --]

On Sat, 08 Sep 2001, Michael Totschnig wrote:
> Simon Josefsson <jas@extundo.com> wrote:
> 
>> Daniel Pittman <daniel@rimspace.net> writes:
>>
>>>> It's quite nagging to me because I usually send and receive Korean
>>>> mails.
>>>
>>> The attached patch fixes is, but it's probably quite ugly and
>>> offensive to the eyes of the Gnus experts[1] so I trust that one of
>>> them will rewrite it to be nicer...
>>
>> I committed it, trusting that someone will send a patch cleaning it
>> up if necessary.
> 
> I have the impression that this patch could be responsible for a
> problem with specifications I observe since updating today:

Rats. You got me; I missed that glitch in my code. It now respects the
side that the padding should be on as well as the width of it, with the
attached patch.

         Daniel


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1186 bytes --]

Index: gnus-spec.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-spec.el,v
retrieving revision 6.13
diff -u -u -p -r6.13 gnus-spec.el
--- gnus-spec.el	2001/09/08 07:53:16	6.13
+++ gnus-spec.el	2001/09/10 01:12:00
@@ -376,16 +376,21 @@
   "Return a form that pads EL to PAD-WIDTH accounting for multi-column
 characters correctly. This is because `format' may pad to columns or to
 characters when given a pad value."
-  (let ((pad (abs pad-width)))
+  (let ((pad (abs pad-width))
+	(side (< 0 pad-width)))
     (if (symbolp el)
 	`(let ((need (- ,pad (gnus-correct-length ,el))))
 	   (if (> need 0)
-	       (concat ,el (make-string need ?\ ))
+	       (concat ,(when side '(make-string need ?\ ))
+		       ,el
+		       ,(when (not side) '(make-string need ?\ )))
 	     ,el))
       `(let* ((val (eval ,el))
 	      (need (- ,pad (gnus-correct-length ,el))))
 	 (if (> need 0)
-	     (concat ,el (make-string need ?\ ))
+	     (concat ,(when side '(make-string need ?\ ))
+		     ,el
+		     ,(when (not side) '(make-string need ?\ )))
 	   ,el)))))
 
 (defun gnus-parse-format (format spec-alist &optional insert)

[-- Attachment #3: Type: text/plain, Size: 94 bytes --]


-- 
When your hammer is C++, everything begins to look like a thumb.
        -- Simon Brooke