From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/33464
Path: main.gmane.org!not-for-mail
From: Colin Walters <walters@cis.ohio-state.edu>
Newsgroups: gmane.emacs.gnus.general
Subject: Gnus 5.9.0 message.el removes needed headers
Date: 22 Nov 2000 02:14:50 -0500
Organization: The Ohio State University Dept. of Computer and Info. Science
Sender: owner-ding@hpc.uh.edu
Message-ID: <87k89w32c5.fsf@meta.verbum.org>
Reply-To: ding@gnus.org
NNTP-Posting-Host: coloc-standby.netfonds.no
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: main.gmane.org 1035169565 25282 80.91.224.250 (21 Oct 2002 03:06:05 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Mon, 21 Oct 2002 03:06:05 +0000 (UTC)
Return-Path: <owner-ding@hpc.uh.edu>
Original-Received: from lisa.math.uh.edu (lisa.math.uh.edu [129.7.128.49])
	by mailhost.sclp.com (Postfix) with ESMTP id ABCF7D049A
	for <jason@mastaler.com>; Wed, 22 Nov 2000 02:18:43 -0500 (EST)
Original-Received: from sina.hpc.uh.edu (lists@Sina.HPC.UH.EDU [129.7.3.5])
	by lisa.math.uh.edu (8.9.1/8.9.1) with ESMTP id BAB01833;
	Wed, 22 Nov 2000 01:18:30 -0600 (CST)
Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Wed, 22 Nov 2000 01:17:30 -0600 (CST)
Original-Received: from mailhost.sclp.com (postfix@66-209.196.61.interliant.com [209.196.61.66] (may be forged))
	by sina.hpc.uh.edu (8.9.3/8.9.3) with ESMTP id BAA26318
	for <ding@hpc.uh.edu>; Wed, 22 Nov 2000 01:17:19 -0600 (CST)
Original-Received: from cis.ohio-state.edu (mail.cis.ohio-state.edu [164.107.115.5])
	by mailhost.sclp.com (Postfix) with ESMTP id 5674BD049A
	for <ding@gnus.org>; Wed, 22 Nov 2000 02:17:43 -0500 (EST)
Original-Received: from meta.verbum.org (root@gold.cis.ohio-state.edu [164.107.112.16])
	by cis.ohio-state.edu (8.9.1/8.9.1) with ESMTP id CAA11144
	for <ding@gnus.org>; Wed, 22 Nov 2000 02:17:32 -0500 (EST)
Original-Received: by meta.verbum.org (Postfix (Debian/GNU), from userid 1000)
	id 51C8210356; Wed, 22 Nov 2000 02:14:52 -0500 (EST)
Original-To: ding@gnus.org
X-Attribution: Colin
X-Face: %'w-_>8Mj2_'=;I$myE#]G"'D>x3CY_rk,K06:mXFUvWy>;3I"BW3_-MAiUby{O(mn"wV@m
 dd`)Vk[27^^Sa<qRKA=qTu-uV/qLcGrMm-}A24N2wgr)5%_46(#WMTajfXc_DBt)&'/(J1
Original-Sender: walters+s@cis.ohio-state.edu
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.0.91
Original-Lines: 38
Precedence: list
X-Majordomo: 1.94.jlt7
Xref: main.gmane.org gmane.emacs.gnus.general:33464
X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:33464

Hello,

On "GNU Emacs 21.0.91.1 (i686-pc-linux-gnu, X toolkit)
 of Sun 2000-11-19 on meta"

when sending mail, message.el generates the headers here on line 2515:

	;; Insert some headers.
	(message-generate-headers message-required-news-headers)

where the Message-ID, Lines, Date, etc are generated.  Then,
message.el generates these headers again on line 2538:

		;; We (re)generate the Lines header.
		(when (memq 'Lines message-required-mail-headers)
		  (message-generate-headers '(Lines)))

The comment by the second generation seems to say that only the Lines
header will be regenerated; in fact, all headers with the
'message-deletable text property are deleted, including the
Message-ID, but are not restored, because only the '(Lines) header is
passed as a header to generate the second time.

The following gross hack cures the symptoms, but I think message.el
should be fixed to not require the headers to be generated twice.

walters@meta:/usr/local/share/emacs/21.0.91/lisp/gnus$ diff -u message.el /usr/src/emacs-21.0.91/lisp/gnus/message.el
--- message.el	Mon Nov 13 05:25:16 2000
+++ /usr/src/emacs-21.0.91/lisp/gnus/message.el	Wed Nov 22 02:06:45 2000
@@ -2328,7 +2328,7 @@
 	    (message-narrow-to-headers)
 	    ;; We (re)generate the Lines header.
 	    (when (memq 'Lines message-required-mail-headers)
-	      (message-generate-headers '(Lines)))
+	      (message-generate-headers message-required-mail-headers))
 	    ;; Remove some headers.
 	    (message-remove-header message-ignored-mail-headers t)
 	    (let ((mail-parse-charset message-default-charset))