source of error in nnslashdot.el found

source of error in nnslashdot.el found

[Sean Doran]

Someone who can make commits on gnus might want to fix this:

Here is " *temp*":

    <title>Hubble Delivers Indications Of Black Holes</title>
    <url>http://slashdot.org/article.pl?sid=00/03/25/0111237</url>
    <time>2000-03-25 13:13:53</time>
    <author>timothy</author>
    <department>if-you-think-your-/job/-sucks</department>
    <topic>space</topic>
    <comments>32</comments>
    <section></section>
    <image>topicspace.gif</image>
  </story>

This code in nnslashdot.el:nnslashdot-request-list (around line 377 in
pgnus-0.99's nnslashdot.el) fails, because there is no match.

	(re-search-forward "<url>\\([^<]+\\)</url>")
	(setq sid (match-string 1))
	(string-match "/\\([0-9/]+\\).shtml" sid)
	(setq sid (match-string 1 sid))

Backtrace:
Signaling: (args-out-of-range "http://slashdot.org/article.pl?sid=00/03/25/0111237" 167 218)
  match-string(1 "http://slashdot.org/article.pl?sid=00/03/25/0111237")
  (setq sid (match-string 1 sid))
  (while (search-forward "<story>" nil t) (narrow-to-region (point) (search-forward "</story>")) (goto-char (point-min)) (re-search-forward "<title>\\([^<]+\\)</title>") (setq description (match-string 1)) (re-search-forward "<url>\\([^<]+\\)</url>") (setq sid (match-string 1)) (string-match "/\\([0-9/]+\\).shtml" sid) (setq sid (match-string 1 sid)) (re-search-forward "<comments>\\([^<]+\\)</comments>") (setq articles (string-to-number ...)) (setq gname (concat description " (" sid ")")) (if (setq elem ...) (setcar ... articles) (push ... nnslashdot-groups)) (goto-char (point-max)) (widen))

Suggested hack: make the .shtml ending optional. (i.e., \\(.shtml\\)?)
This works for me.

	Sean.

Re: source of error in nnslashdot.el found

[Michael Harnois]

On Sat, 25 Mar 2000 17:25:38 +0100 (CET), Sean Doran <smd@ebone.net> said:

    > This code in nnslashdot.el:nnslashdot-request-list (around line
    > 377 in pgnus-0.99's nnslashdot.el) fails, because there is no
    > match.

I had such high hopes, but, sigh ... the applicable line in the latest
CVS is

 (string-match "/\\([0-9/]+\\)\\(.shtml\\|$\\)" sid)

-- 
Michael D. Harnois, Redeemer Lutheran Church, Washburn, IA 
mdharnois@home.com                      aa0bt@aa0bt.ampr.org 
 Democracy is also a form of worship.
 It is the worship of Jackals by Jackasses. -- H. L. Mencken