Gnus development mailing list
 help / color / mirror / Atom feed
From: "Jose A. Ortega Ruiz" <jao@gnu.org>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: Eric S Fraga <e.fraga@ucl.ac.uk>,  ding@gnus.org
Subject: Re: New "gnus-search" syntax and interface
Date: Wed, 18 Nov 2020 00:46:54 +0000	[thread overview]
Message-ID: <87lfezwkxt.fsf@gnus.jao.io> (raw)
In-Reply-To: <87lfezlemj.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Tue, 17 Nov 2020 15:58:44 -0800")

On Tue, Nov 17 2020, Eric Abrahamsen wrote:

> Eric S Fraga <e.fraga@ucl.ac.uk> writes:
>
>> On Monday, 16 Nov 2020 at 10:47, Eric Abrahamsen wrote:
>>> Well that's pretty weird. I didn't think I changed any of the actual
>>> parsing behavior, only reorganized code. 
>>
>> With these complex systems, the whole concept of emergent behaviour
>> raises its head! ;-)
>>
>> Happy to test out anything you change etc., of course.
>
> Thanks very much. This is still baffling me. If you (and/or Jose, or
> anyone else) have a moment, would you please send me the command-line
> output of a successful notmuch search (ie absolute filenames) which
> fails in Emacs master right now? Feel free to anonymize however
> necessary, though obviously leaving the group-name part of the filepath
> alone. Plus whatever notmuch-related config you've got...

If i perform a gnus-search for "baffled" in this group, which is called
by gnus "nntp:gmane.emacs.gnus.general", the buffer where
gnus-search-indexed-parse-output runs has the following output from
notmuch (which correctly inserts real path names):

   /home/jao/var/mail/gmane/emacs/gnus/general/65
   /home/jao/var/mail/feeds/news/cur/1605280382.M861830P724182.osgiliath,S=3292,W=3331:2,Sa
   /home/jao/var/mail/gwene/org/arxiv/computer/science/1102

where /home/jao/var/mail is my remove-prefix.  

That method (gnus-search.el:1364) is receiving as its 'groups' argument
the value '("gmane.emacs.gnus.general").  the method constructs a regexp
that it calls group-regexp using that value, and that regexp is wrong.

That is because it uses as its value:

    (when groups
      (regexp-opt (mapcar (lambda (x) (gnus-group-real-name x)) groups)))

which, for grous being '("gmane.emacs.gnus.general"), evaluates to:

    "\\(?:gmane\\.emacs\\.gnus\\.general\\)"

That is wrong because the method then tries to match in the results
buffer, using that regexp, things like:

   /home/jao/var/mail/gmane.emacs.gnus.general/65

instead of correct pathnames such as:

   /home/jao/var/mail/gmane/emacs/gnus/general/65

The end result is that, despite notmuch finding correct paths and
inserting them correctly in the temporary results buffer,
gnus-search-indexed-parse-output fails to recognise them when it is
filtering those belonging to the searched for groups.  And this is
because it's constructing a wrong regular expression in
gnus-search.el:1367, and using it in gnus-search.el:1381.

The workaround my advice implements is changing the value of the input
parameter groups from '("foo.bar") to '("foo/bar").

I'm most probably belabouring here many things obvious to you, sorry
about that :)

Hope this helps,
jao
-- 
Flags are bits of colored cloth that governments use first to
shrink-wrap people's brains and then as ceremonial shrouds to bury the
dead. -Arundhati Roy, writer and activist (b. 1961)


  reply	other threads:[~2020-11-18  0:49 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-04 17:15 Eric Abrahamsen
2020-11-04 18:14 ` Pankaj Jangid
2020-11-04 18:45   ` Eric Abrahamsen
2020-11-04 19:32     ` Pankaj Jangid
2020-11-04 19:39     ` Pankaj Jangid
2020-11-04 19:49       ` Eric Abrahamsen
2020-11-05  2:19 ` Eric Abrahamsen
2020-11-05 11:58 ` Adam Sjøgren
2020-11-05 16:04   ` Eric Abrahamsen
2020-11-05 16:14     ` Eric Abrahamsen
2020-11-05 16:41     ` Adam Sjøgren
2020-11-05 17:18       ` Eric Abrahamsen
2020-11-05 17:34         ` Adam Sjøgren
2020-11-06  3:50           ` Eric Abrahamsen
2020-11-06  6:23 ` Jose A. Ortega Ruiz
     [not found]   ` <12MvvhYMQyipeZzkJx1ODwHAD4xQZo6qw1FSX6nvgZAyLZCPkEVFXXGxOQTuxL1zvwZC6BER4jnUFXNgIEjIZA==@protonmail.internalid>
2020-11-07  4:59   ` Eric Abrahamsen
2020-11-08  1:23     ` Jose A. Ortega Ruiz
     [not found]       ` <VEKLrJRKnbVIVztgsX0O5q0i9OwitXf-t5q2hcVN-ZDq0SRE1KS4DIpk7iNeQxIhD1_9AC4DWOdDJsJW2XCMlg==@protonmail.internalid>
2020-11-08  2:38       ` Eric Abrahamsen
2020-11-08  2:51         ` Jose A. Ortega Ruiz
2020-11-08  2:55         ` Andrew Cohen
2020-11-08  2:43     ` Jose A. Ortega Ruiz
2020-11-08  5:03       ` Eric Abrahamsen
2020-11-08  7:16         ` Jose A. Ortega Ruiz
2020-11-12 20:51           ` Eric Abrahamsen
2020-11-13  3:17             ` Jose A. Ortega Ruiz
     [not found]               ` <-NlYHnQ3eprZs5vpzJzwiWpUHjyOUwbkarR4R4m8DK_5ik1XoE8SVsxNfQWJwgUWVIfjwxU5eCbwaWIzwZUJNQ==@protonmail.internalid>
2020-11-13  6:38               ` Eric Abrahamsen
2020-11-13 19:15                 ` Jose A. Ortega Ruiz
2020-11-14  1:02                   ` Eric Abrahamsen
2020-11-13 11:07 ` Eric S Fraga
2020-11-13 12:39   ` Gijs Hillenius
2020-11-13 13:01     ` Eric S Fraga
2020-11-13 16:15       ` Eric Abrahamsen
2020-11-13 16:56         ` Eric S Fraga
2020-11-13 17:21           ` Eric Abrahamsen
2020-11-13 20:06             ` Jose A. Ortega Ruiz
2020-11-16 10:44               ` Eric S Fraga
2020-11-16 15:00               ` Eric S Fraga
2020-11-16 18:47                 ` Eric Abrahamsen
2020-11-17 11:04                   ` Eric S Fraga
2020-11-17 23:58                     ` Eric Abrahamsen
2020-11-18  0:46                       ` Jose A. Ortega Ruiz [this message]
2020-11-18 20:40                         ` Eric Abrahamsen
     [not found]                         ` <1x7NOCTHudFuCvB0kEBCGDds7KKAdbu-tZRD41ue36qG8dPBUSj7W9lq7CK5WJwL50cGQKZcom2KMkW_2VZi8Q==@protonmail.internalid>
     [not found]                           ` <871rgqz98k.fsf@ericabrahamsen.net>
2020-11-18 21:05                             ` Jose A. Ortega Ruiz
2020-11-18 21:31                               ` Eric Abrahamsen
2020-11-18  9:21 ` yoctocell
2020-11-18 20:53   ` Eric Abrahamsen
2020-11-19 11:02     ` yoctocell
2020-11-22 12:56     ` yoctocell
2020-11-22 16:31       ` Eric Abrahamsen
     [not found]         ` <86lfel9z1b.fsf@yoctocell.xyz>
2020-11-30  4:40           ` Eric Abrahamsen
2020-11-30  8:17             ` yoctocell
2020-11-30 17:30               ` Eric Abrahamsen
2020-12-01  7:47                 ` yoctocell
2020-12-02  2:16                   ` Eric Abrahamsen
2020-12-02  7:17                     ` yoctocell
2020-12-11  1:39                       ` Eric Abrahamsen
2020-12-11  7:55                         ` yoctocell
2020-12-13 10:18                           ` yoctocell
2020-12-13 11:23                             ` yoctocell
2020-12-13 16:49                               ` Eric Abrahamsen
2020-12-13 21:13                                 ` yoctocell
2020-12-18  4:30                                   ` Eric Abrahamsen
2020-12-18  8:21                                     ` yoctocell
2020-12-22 17:05                                       ` Eric Abrahamsen
2020-12-22 18:10                                         ` yoctocell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfezwkxt.fsf@gnus.jao.io \
    --to=jao@gnu.org \
    --cc=ding@gnus.org \
    --cc=e.fraga@ucl.ac.uk \
    --cc=eric@ericabrahamsen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).