Gnus development mailing list
 help / color / Atom feed
* Problem with epg-signature-to-string!?
@ 2019-12-09 22:07 Mats Lidell
  2019-12-11 18:29 ` Eric Abrahamsen
  2019-12-11 20:56 ` Adam Sjøgren
  0 siblings, 2 replies; 6+ messages in thread
From: Mats Lidell @ 2019-12-09 22:07 UTC (permalink / raw)
  To: ding

Hi,

After upgrading to latest tip version of emacs 27.0.50 I'm seeing this type of errors with encrypted signatures(!?) 

Debugger entered--Lisp error: (error "Can’t convert the Nth character to unibyte") <-(N depending on which character it can't convert)
  string-to-unibyte("Name containing non ascii character <email...>")
  epg--decode-percent-escape("Name containing non ascii character <email...>")
  epg--decode-percent-escape-as-utf-8("Name containing non ascii character <email...>")
  epg-signature-to-string(#s(epg-signature :status good :key-id "<***>" :validity undefined :fingerprint "<***>" :creation-time 1575892337 :expiration-time nil :pubkey-algorithm 1 :digest-algorithm 8 :class 1 :version 4 :notations nil))
  [...]

I suspect it started after this update

commit 98387b9e2455b0bd5a2aafe6fac939fb111eedce
Author: Lars Ingebrigtsen <larsi@gnus.org>
Date:   Wed Oct 23 10:50:29 2019 +0200

    Make display of S/MIME signatures slightly better
    
    * lisp/epg.el (epg-signature-to-string): Decode percent escapes
    (bug#36101).

Anyone else seeing this? Is this due to bad encoding in the signatures or error when decoding it?

Yours
-- 
%% Mats




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Problem with epg-signature-to-string!?
  2019-12-09 22:07 Problem with epg-signature-to-string!? Mats Lidell
@ 2019-12-11 18:29 ` Eric Abrahamsen
  2019-12-11 20:56 ` Adam Sjøgren
  1 sibling, 0 replies; 6+ messages in thread
From: Eric Abrahamsen @ 2019-12-11 18:29 UTC (permalink / raw)
  To: ding

Mats Lidell <mats.lidell@lidells.se> writes:

> Hi,
>
> After upgrading to latest tip version of emacs 27.0.50 I'm seeing this type of errors with encrypted signatures(!?) 
>
> Debugger entered--Lisp error: (error "Can’t convert the Nth character to unibyte") <-(N depending on which character it can't convert)
>   string-to-unibyte("Name containing non ascii character <email...>")

I saw this reported somewhere else, and my impression is that the
problem has been fixed in master (though only very recently). Can you
update again?




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Problem with epg-signature-to-string!?
  2019-12-09 22:07 Problem with epg-signature-to-string!? Mats Lidell
  2019-12-11 18:29 ` Eric Abrahamsen
@ 2019-12-11 20:56 ` Adam Sjøgren
  2019-12-12  8:53   ` Robert Pluim
  1 sibling, 1 reply; 6+ messages in thread
From: Adam Sjøgren @ 2019-12-11 20:56 UTC (permalink / raw)
  To: ding

Mats writes:

> Anyone else seeing this? Is this due to bad encoding in the signatures
> or error when decoding it?

Yes, I noticed as well and reported it in:

 · https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38512

and Robert Pluim has found a solution.


  Best regards,

    Adam

-- 
 "Kom læn dig op af mig                                     Adam Sjøgren
  Så falder vi sammen"                                 asjo@koldfront.dk




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Problem with epg-signature-to-string!?
  2019-12-11 20:56 ` Adam Sjøgren
@ 2019-12-12  8:53   ` Robert Pluim
  2019-12-12 10:21     ` Adam Sjøgren
  2019-12-13  9:44     ` Mats Lidell
  0 siblings, 2 replies; 6+ messages in thread
From: Robert Pluim @ 2019-12-12  8:53 UTC (permalink / raw)
  To: Adam Sjøgren; +Cc: ding, Eric Abrahamsen, Mats Lidell

>>>>> On Wed, 11 Dec 2019 21:56:44 +0100, Adam Sjøgren <asjo@koldfront.dk> said:

    Adam> Mats writes:
    >> Anyone else seeing this? Is this due to bad encoding in the signatures
    >> or error when decoding it?

    Adam> Yes, I noticed as well and reported it in:

    Adam>  · https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38512

    Adam> and Robert Pluim has found a solution.

The commit to fix this is d57bb0c323 , which I pushed about an hour
ago.

Robert



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Problem with epg-signature-to-string!?
  2019-12-12  8:53   ` Robert Pluim
@ 2019-12-12 10:21     ` Adam Sjøgren
  2019-12-13  9:44     ` Mats Lidell
  1 sibling, 0 replies; 6+ messages in thread
From: Adam Sjøgren @ 2019-12-12 10:21 UTC (permalink / raw)
  To: ding

Robert writes:

> The commit to fix this is d57bb0c323 , which I pushed about an hour
> ago.

Thanks for taking care of it - much appreciated!


  Best regards,

    Adam

-- 
 "Soon we'll have spent a whole month at sea,               Adam Sjøgren
  splitting atoms for no apparent reason"              asjo@koldfront.dk




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Problem with epg-signature-to-string!?
  2019-12-12  8:53   ` Robert Pluim
  2019-12-12 10:21     ` Adam Sjøgren
@ 2019-12-13  9:44     ` Mats Lidell
  1 sibling, 0 replies; 6+ messages in thread
From: Mats Lidell @ 2019-12-13  9:44 UTC (permalink / raw)
  To: ding

> Robert Pluim writes:
> The commit to fix this is d57bb0c323 , which I pushed about an hour
> ago.

Thanks. It works fine!

Yours
-- 
%% Mats




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-09 22:07 Problem with epg-signature-to-string!? Mats Lidell
2019-12-11 18:29 ` Eric Abrahamsen
2019-12-11 20:56 ` Adam Sjøgren
2019-12-12  8:53   ` Robert Pluim
2019-12-12 10:21     ` Adam Sjøgren
2019-12-13  9:44     ` Mats Lidell

Gnus development mailing list

Archives are clonable: git clone --mirror http://inbox.vuxu.org/ding

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.emacs.gnus.general


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git