From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/82989 Path: news.gmane.org!not-for-mail From: Daimrod Newsgroups: gmane.emacs.gnus.general Subject: Re: [PATCH] don't kill err-buffer if `sendmail-send-it' fails Date: Wed, 13 Mar 2013 22:53:38 +0100 Message-ID: <87li9rx8yl.fsf@tanger.home> References: <87fw0hk22y.fsf@tanger.home> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Trace: ger.gmane.org 1363211580 27062 80.91.229.3 (13 Mar 2013 21:53:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 13 Mar 2013 21:53:00 +0000 (UTC) To: Gnus Original-X-From: ding-owner+M31255@lists.math.uh.edu Wed Mar 13 22:53:24 2013 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UFtbp-00063Z-Rt for ding-account@gmane.org; Wed, 13 Mar 2013 22:53:18 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1UFtbM-0002DQ-PT; Wed, 13 Mar 2013 16:52:48 -0500 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1UFtbK-0002Cx-Dj for ding@lists.math.uh.edu; Wed, 13 Mar 2013 16:52:46 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) (envelope-from ) id 1UFtbJ-00015q-4z for ding@lists.math.uh.edu; Wed, 13 Mar 2013 16:52:46 -0500 Original-Received: from mail-wg0-f47.google.com ([74.125.82.47]) by quimby.gnus.org with esmtp (Exim 4.72) (envelope-from ) id 1UFtbH-0001nN-Nv for ding@gnus.org; Wed, 13 Mar 2013 22:52:43 +0100 Original-Received: by mail-wg0-f47.google.com with SMTP id dr13so1409947wgb.26 for ; Wed, 13 Mar 2013 14:52:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=G5Zx4hiwv7Gr1eans8kJuEDtrIs4OWccxuFlW+khFI4=; b=hvG1eYqbZEmo5ulgqs7FvFBjVPxpHLfomNjhl+PJZdz7IVVHIWB5j0bg5H0nF6LYzH V/AXfynwF4a+DmCdE0/LwVO5Ok62Lxn0Qux9b3zQEQgQdyhQLkXbEN2Esj5TT7TGR5CM pDpvvsrDUqM8QT/2l5agoXFJzI80b2RH1ruGJbgRYfZ111ACrpsR9COLVMgckB1UYwgd 59CDK+55kh/MGhSLHC8BEiLd7ju31bxMa/l/UlrhCAMfIxIaVurTo2hgQz5VY3H7mQce /3SUL5Wu1TGltmgZ0yyxLxYqe11XcuYrOuGdekjunffpE6F7uQ94BQlsTQUhxefC0IZz b20w== X-Received: by 10.194.122.131 with SMTP id ls3mr37256184wjb.55.1363211558423; Wed, 13 Mar 2013 14:52:38 -0700 (PDT) Original-Received: from localhost (ANantes-653-1-156-129.w90-54.abo.wanadoo.fr. [90.54.99.129]) by mx.google.com with ESMTPS id q13sm7042437wie.0.2013.03.13.14.52.35 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 13 Mar 2013 14:52:36 -0700 (PDT) In-Reply-To: <87fw0hk22y.fsf@tanger.home> (daimrod@gmail.com's message of "Wed, 27 Feb 2013 20:07:33 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Spam-Score: -3.0 (---) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:82989 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Daimrod writes: > Hi, > > Here is a small patch for `sendmail-send-it' that I've made while I was > trying to understand why I couldn't connect to my imap server. > > I've just added a boolean to avoid to kill the error buffer if an error > occurs. > > > --- old 2013-02-27 19:53:00.000000000 +0100 > +++ new 2013-02-27 19:57:03.000000000 +0100 > @@ -6,6 +6,7 @@ > (let ((errbuf (if mail-interactive > (generate-new-buffer " sendmail errors") > 0)) > + err? > (tembuf (generate-new-buffer " sendmail temp")) > (multibyte enable-multibyte-characters) > (case-fold-search nil) > @@ -170,21 +171,27 @@ > (exit-value (apply 'call-process-region args))) > (cond ((or (null exit-value) (eq 0 exit-value))) > ((numberp exit-value) > + (setq err? t) > (error "Sending...failed with exit value %d" exit-value)) > ((stringp exit-value) > + (setq err? t) > (error "Sending...terminated by signal: %s" exit-value)) > (t > + (setq err? t) > (error "SENDMAIL-SEND-IT -- fall through: %S" exit-value)))) > - (or fcc-was-found > - (error "No recipients"))) > + (unless fcc-was-found > + (setq err? t) > + (error "No recipients"))) > (if mail-interactive > (with-current-buffer errbuf > (goto-char (point-min)) > (while (re-search-forward "\n\n* *" nil t) > (replace-match "; ")) > - (if (not (zerop (buffer-size))) > - (error "Sending...failed to %s" > - (buffer-substring (point-min) (point-max))))))) > + (when (not (zerop (buffer-size))) > + (setq err? t) > + (error "Sending...failed to %s" > + (buffer-substring (point-min) (point-max))))))) > (kill-buffer tembuf) > - (if (bufferp errbuf) > - (kill-buffer errbuf))))) > + (when (and (bufferp errbuf) > + (not err?)) > + (kill-buffer errbuf))))) up. No comment on this? =2D-=20 Daimrod/Greg --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJRQPViAAoJEBNzVHcrZRiUzOMQAJJ+ch3Qae1E4z6kx7auP+tf OaefYRhf7IN+ewbTge39avzFA8YYsix+UDp8d1FgEhqEPO4NvbCnHkiLrWYx+HCq rw7wmRXG3Wmcmj5O+rnxDDU4tAlbrTWajd1lJGzXFcNKqqqP7Q0W3BpUhZeqADW7 RMk1gt4YxUYzf/NNT5WgAtYj68whlGGeczZkfMJw3RJRQtraiOERKucQe/Aw2Kw8 Rrc4HeqD7yzzR+F6ENxAnWikxPLszr/4+BuiC3eu0DGTm64claYkc8GdQbASirSG K+hU+roQWSfH3toXC2xzI6LvzLZQ9K/P+wLr4tXbrz3dqxGX0LvGJllezttdoWIQ zcQaD4lQJoZT0bHZe120Jg7GZCf1WJlFzYdQq85TEhkltbTbLvgi6olX0t1/zBso GS8wnc5fmr20RtbBaNzGTyh5Av9Ybd3ToB5rXz/Ycxa0aSbmaOK9tmP9iN+zWVcf zDtkcSB9bSKREmJYnh7vkex2W+x2mgfAu0fZfHl3mc+TAu4H9cieEv/pD9Ll0dIi PkUB4aQ5VBCh9FVm+m+NH5I5/x8RHY6zmAHAdfs1StKKmNYU+ikixA3I27RTPrvK 8ENNJU4XGvoqNZoFUy7QJ1FxUbsuRcKQQR+aHWc8yxwVdDTq4i70XXpxvCnsRUoM /6zQF6OOSbDMChrJuWs8 =S2pS -----END PGP SIGNATURE----- --=-=-=--