From: David Engster <deng@randomsample.de>
To: Ted Zlatanov <tzz@lifelogs.com>
Cc: ding@gnus.org, emacs-devel@gnu.org
Subject: Re: bizarre byte-compile issue, possibly due to EIEIO
Date: Sat, 02 Apr 2011 23:32:45 +0200 [thread overview]
Message-ID: <87lizs9w5e.fsf@randomsample.de> (raw)
In-Reply-To: <8762qxo4l3.fsf@lifelogs.com> (Ted Zlatanov's message of "Fri, 01 Apr 2011 19:54:32 -0500")
Ted Zlatanov writes:
> On Fri, 01 Apr 2011 15:29:38 -0500 Ted Zlatanov <tzz@lifelogs.com> wrote:
>
> TZ> In other words, the registry.elc file is breaking the tests. I can't
> TZ> figure out what's wrong, but it seems EIEIO-related. If I try to
> TZ> edebug, that evaluates the problematic methods (e.g. `registry-lookup')
> TZ> and then they don't exhibit the problem.
>
> TZ> Using "(eval-when-compile (require 'registry))" instead of
> TZ> "(require 'registry)" doesn't help. All the registry.el ERT tests pass.
>
> (CC to ding mailing list; see prior messages on emacs-devel for context)
>
> I've been able to work around it with:
>
> (let ((load-suffixes '(".el")))
> (require 'registry))
[...]
> So I hope someone can help me out :)
I can't really explain anything, but maybe I can at least shift the
blame. ;-)
If I rewrite your registry-lookup function to use 'mapcar' instead of
'loop', the tests work as expected:
(defmethod registry-lookup ((db registry-db) keys)
"Search for KEYS in the registry-db THIS.
Returns a alist of the key followed by the entry in a list, not a cons cell."
(let ((data (oref db :data)))
(delq nil
(mapcar
(lambda (k)
(when (gethash k data)
(list k (gethash k data))))
keys))))
-David
next prev parent reply other threads:[~2011-04-02 21:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87hbahww99.fsf@lifelogs.com>
2011-04-02 0:54 ` Ted Zlatanov
2011-04-02 20:34 ` Lars Magne Ingebrigtsen
2011-04-04 13:47 ` Ted Zlatanov
2011-04-04 15:26 ` David Engster
2011-04-02 21:32 ` David Engster [this message]
2011-04-03 9:34 ` David Engster
2011-04-04 10:18 ` Ted Zlatanov
2011-04-04 15:34 ` David Engster
2011-04-05 15:56 ` Ted Zlatanov
2011-04-05 16:38 ` David Engster
2011-04-05 17:55 ` Ted Zlatanov
2011-04-05 18:31 ` David Engster
2011-04-05 18:44 ` Ted Zlatanov
2011-04-05 16:14 ` Ted Zlatanov
2011-04-05 17:57 ` Ted Zlatanov
2011-04-04 16:29 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lizs9w5e.fsf@randomsample.de \
--to=deng@randomsample.de \
--cc=ding@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).