Re: [gnus git] branch master updated: n0-13-65-gece58ab =2= Autoload `password-in-cache-p'. ; Try to fix XEmacs message-options buffer-local issue.

[Daiki Ueno <ueno@unixuser.org>]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Julien Danjou <julien@danjou.info> writes:
>
>>> I'm not quite sure I understand the issue.  Since the variable is now
>>> buffer-local, do we need to bind it at all?
>>
>> AFAIU, yes, if you use a temp buffer (in XEmacs).
>
> Right.  Daiki Ueno's patch to copy over the buffer-local variables to
> the temp buffer might solve that problem, though?

My patch is not enough, since there are several places Gnus binds
message-options:

$ grep -n '(message-options ' *.el
gnus-art.el:4954:	      (message-options message-options)
gnus-art.el:8444:	    (let ((message-options message-options))
gnus-int.el:697:    (let ((message-options message-options))
gnus-int.el:720:    (let ((message-options message-options))
gnus-sum.el:10348:		  (message-options message-options)
message.el:1862:;; (let ((message-options message-options)) ...)
message.el:4091:	(message-options message-options))
mml.el:1469:	   (message-options message-options)

In theory, we could probably change the code like:

(let ((tmp-message-options message-options))
  (set-buffer ...)
  (setq message-options tmp-message-options))

everywhere listed above and also do this in functions called within the
let-bindings.  Too much work with little return, IMHO :)

Regards,
-- 
Daiki Ueno