From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/77558 Path: news.gmane.org!not-for-mail From: Daiki Ueno Newsgroups: gmane.emacs.gnus.general Subject: Re: [gnus git] branch master updated: n0-13-65-gece58ab =2= Autoload `password-in-cache-p'. ; Try to fix XEmacs message-options buffer-local issue. Date: Sun, 06 Mar 2011 07:55:12 +0900 Message-ID: <87lj0txjn3.fsf@broken.deisui.org> References: <87ei6o1mdi.fsf@lifelogs.com> <8762rzx2j6.fsf@broken.deisui.org> <87vczzrrpu.fsf@broken.deisui.org> <87ipvxsu4a.fsf@keller.adm.naquadah.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1299365791 25321 80.91.229.12 (5 Mar 2011 22:56:31 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 5 Mar 2011 22:56:31 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M25881@lists.math.uh.edu Sat Mar 05 23:56:27 2011 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Pw0Og-0001Ry-RY for ding-account@gmane.org; Sat, 05 Mar 2011 23:56:27 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1Pw0O2-0003Qi-7r; Sat, 05 Mar 2011 16:55:46 -0600 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1Pw0Nz-0003QK-QF for ding@lists.math.uh.edu; Sat, 05 Mar 2011 16:55:43 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.72) (envelope-from ) id 1Pw0Nm-0004Ha-1b for ding@lists.math.uh.edu; Sat, 05 Mar 2011 16:55:43 -0600 Original-Received: from ivory4.scn-net.ne.jp ([219.117.176.192]) by quimby.gnus.org with smtp (Exim 4.72) (envelope-from ) id 1Pw0Nk-0005j2-5G for ding@gnus.org; Sat, 05 Mar 2011 23:55:28 +0100 Original-Received: from ([192.168.0.187]) (envelope sender: ) by ivory4.scn-net.ne.jp with Active!Hunter esmtp server; Sun, 6 Mar 2011 07:55:23 +0900 Original-Received: Received: from well-done.deisui.org (g187018.scn-net.ne.jp [202.83.187.18]) (authenticated) by blue17.scn-net.ne.jp (unknown) with ESMTP id p25MtMMa015274 for ; Sun, 6 Mar 2011 07:55:23 +0900 In-Reply-To: (Lars Magne Ingebrigtsen's message of "Sat, 05 Mar 2011 12:15:02 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) X-Spam-Score: -1.9 (-) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:77558 Archived-At: Lars Magne Ingebrigtsen writes: > Julien Danjou writes: > >>> I'm not quite sure I understand the issue. Since the variable is now >>> buffer-local, do we need to bind it at all? >> >> AFAIU, yes, if you use a temp buffer (in XEmacs). > > Right. Daiki Ueno's patch to copy over the buffer-local variables to > the temp buffer might solve that problem, though? My patch is not enough, since there are several places Gnus binds message-options: $ grep -n '(message-options ' *.el gnus-art.el:4954: (message-options message-options) gnus-art.el:8444: (let ((message-options message-options)) gnus-int.el:697: (let ((message-options message-options)) gnus-int.el:720: (let ((message-options message-options)) gnus-sum.el:10348: (message-options message-options) message.el:1862:;; (let ((message-options message-options)) ...) message.el:4091: (message-options message-options)) mml.el:1469: (message-options message-options) In theory, we could probably change the code like: (let ((tmp-message-options message-options)) (set-buffer ...) (setq message-options tmp-message-options)) everywhere listed above and also do this in functions called within the let-bindings. Too much work with little return, IMHO :) Regards, -- Daiki Ueno