* [PATCH] (gnus-setup-message): Declare `winconf-name'.
@ 2011-02-22 9:47 David Edmondson
2011-02-22 17:38 ` Ted Zlatanov
2011-02-23 8:11 ` Lars Ingebrigtsen
0 siblings, 2 replies; 3+ messages in thread
From: David Edmondson @ 2011-02-22 9:47 UTC (permalink / raw)
To: ding; +Cc: David Edmondson
---
lisp/gnus-msg.el | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/lisp/gnus-msg.el b/lisp/gnus-msg.el
index 29ac431..d715fc8 100644
--- a/lisp/gnus-msg.el
+++ b/lisp/gnus-msg.el
@@ -383,6 +383,7 @@ Thank you for your help in stamping out bugs.
(defvar gnus-article-reply nil)
(defmacro gnus-setup-message (config &rest forms)
(let ((winconf (make-symbol "gnus-setup-message-winconf"))
+ (winconf-name (make-symbol "gnus-setup-message-winconf-name"))
(buffer (make-symbol "gnus-setup-message-buffer"))
(article (make-symbol "gnus-setup-message-article"))
(yanked (make-symbol "gnus-setup-yanked-articles"))
--
1.7.2.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] (gnus-setup-message): Declare `winconf-name'.
2011-02-22 9:47 [PATCH] (gnus-setup-message): Declare `winconf-name' David Edmondson
@ 2011-02-22 17:38 ` Ted Zlatanov
2011-02-23 8:11 ` Lars Ingebrigtsen
1 sibling, 0 replies; 3+ messages in thread
From: Ted Zlatanov @ 2011-02-22 17:38 UTC (permalink / raw)
To: ding
On Tue, 22 Feb 2011 09:47:15 +0000 David Edmondson <dme@dme.org> wrote:
DE> diff --git a/lisp/gnus-msg.el b/lisp/gnus-msg.el
DE> index 29ac431..d715fc8 100644
DE> --- a/lisp/gnus-msg.el
DE> +++ b/lisp/gnus-msg.el
DE> @@ -383,6 +383,7 @@ Thank you for your help in stamping out bugs.
DE> (defvar gnus-article-reply nil)
DE> (defmacro gnus-setup-message (config &rest forms)
DE> (let ((winconf (make-symbol "gnus-setup-message-winconf"))
DE> + (winconf-name (make-symbol "gnus-setup-message-winconf-name"))
DE> (buffer (make-symbol "gnus-setup-message-buffer"))
DE> (article (make-symbol "gnus-setup-message-article"))
DE> (yanked (make-symbol "gnus-setup-yanked-articles"))
I don't know if I'm doing something wrong but it's not fixed for me
after this patch. Maybe there's something in my setup. Backtrace
below.
Ted
Debugger entered--Lisp error: (wrong-number-of-arguments (lambda (winconf buffer article &optional config yanked) (gnus-make-local-hook (quote message-sent-hook)) (add-hook (quote message-sent-hook) (if gnus-agent (quote gnus-agent-possibly-do-gcc) (quote gnus-inews-do-gcc)) nil t) (when gnus-agent (gnus-make-local-hook (quote message-header-hook)) (add-hook (quote message-header-hook) (quote gnus-agent-possibly-save-gcc) nil t)) (setq message-post-method (\` (lambda (&optional arg) (gnus-post-method arg (\, gnus-newsgroup-name))))) (message-add-action (\` (when (gnus-buffer-exists-p (\, buffer)) (set-window-configuration (\, winconf)))) (quote exit) (quote postpone) (quote kill)) (let ((to-be-marked (cond (yanked (mapcar (lambda (x) (if (listp x) (car x) x)) yanked)) (article (if (listp article) article (list article))) (t nil)))) (message-add-action (\` (when (gnus-buffer-exists-p (\, buffer)) (with-current-buffer (\, buffer) (\, (when to-be-marked (if (eq config (quote forward)) (\` (gnus-summary-mark-article-as-forwarded (quote (\, to-be-marked)))) (\` (gnus-summary-mark-article-as-replied (quote (\, to-be-marked)))))))))) (quote send)))) 6)
gnus-inews-add-send-actions(#<window-configuration> "*Summary nntp+news.gmane.org:gmane.emacs.gnus.general*" nil message nil reply-yank)
(unwind-protect (progn (message-mail)) (gnus-inews-add-send-actions gnus-setup-message-winconf gnus-setup-message-buffer gnus-setup-message-article (quote message) gnus-setup-yanked-articles gnus-setup-message-winconf-name) (setq gnus-message-buffer (current-buffer)) (set (make-local-variable (quote gnus-message-group-art)) (cons gnus-setup-message-group gnus-setup-message-article)) (set (make-local-variable (quote gnus-newsgroup-name)) gnus-setup-message-group) (when gnus-message-highlight-citation (gnus-message-citation-mode 1)) (gnus-run-hooks (quote gnus-message-setup-hook)) (if (eq major-mode (quote message-mode)) (let ((mbl1 mml-buffer-list)) (setq mml-buffer-list mbl) (set (make-local-variable (quote mml-buffer-list)) mbl1) (gnus-make-local-hook (quote kill-buffer-hook)) (gnus-make-local-hook (quote change-major-mode-hook)) (add-hook (quote change-major-mode-hook) (quote mml-destroy-buffers) nil t) (add-hook (quote kill-buffer-hook) (quote mml-destroy-buffers) t t)) (mml-destroy-buffers) (setq mml-buffer-list mbl)))
(let ((gnus-setup-message-winconf (current-window-configuration)) (gnus-setup-message-winconf-name gnus-current-window-configuration) (gnus-setup-message-buffer (buffer-name (current-buffer))) (gnus-setup-message-article gnus-article-reply) (gnus-setup-yanked-articles gnus-article-yanked-articles) (gnus-setup-message-group gnus-newsgroup-name) (message-header-setup-hook (copy-sequence message-header-setup-hook)) (mbl mml-buffer-list) (message-mode-hook (copy-sequence message-mode-hook))) (setq mml-buffer-list nil) (add-hook (quote message-header-setup-hook) (quote gnus-inews-insert-gcc)) (add-hook (quote message-mode-hook) (lambda nil (setq message-newsreader (setq message-mailer (gnus-extended-version))))) (add-hook (quote message-mode-hook) (if (memq (quote message) (quote (reply-yank reply))) (lambda nil (gnus-configure-posting-styles gnus-setup-message-group)) (lambda nil (let (gnus-article-copy) (gnus-configure-posting-styles gnus-setup-message-group))))) (gnus-alist-pull (quote X-Draft-From) message-required-headers) (when (and gnus-setup-message-group (not (string= gnus-setup-message-group ""))) (push (cons (intern gnus-draft-meta-information-header) (gnus-inews-make-draft (or gnus-setup-yanked-articles gnus-setup-message-article))) message-required-headers)) (unwind-protect (progn (message-mail)) (gnus-inews-add-send-actions gnus-setup-message-winconf gnus-setup-message-buffer gnus-setup-message-article (quote message) gnus-setup-yanked-articles gnus-setup-message-winconf-name) (setq gnus-message-buffer (current-buffer)) (set (make-local-variable (quote gnus-message-group-art)) (cons gnus-setup-message-group gnus-setup-message-article)) (set (make-local-variable (quote gnus-newsgroup-name)) gnus-setup-message-group) (when gnus-message-highlight-citation (gnus-message-citation-mode 1)) (gnus-run-hooks (quote gnus-message-setup-hook)) (if (eq major-mode (quote message-mode)) (let ((mbl1 mml-buffer-list)) (setq mml-buffer-list mbl) (set (make-local-variable (quote mml-buffer-list)) mbl1) (gnus-make-local-hook (quote kill-buffer-hook)) (gnus-make-local-hook (quote change-major-mode-hook)) (add-hook (quote change-major-mode-hook) (quote mml-destroy-buffers) nil t) (add-hook (quote kill-buffer-hook) (quote mml-destroy-buffers) t t)) (mml-destroy-buffers) (setq mml-buffer-list mbl))) (message-hide-headers) (gnus-add-buffer) (gnus-configure-windows (quote message) t) (run-hooks (quote post-command-hook)) (set-buffer-modified-p nil))
(gnus-setup-message (quote message) (message-mail))
(progn (setq gnus-newsgroup-name (if arg (if (= 1 (prefix-numeric-value arg)) (gnus-group-completing-read "Use group" nil (gnus-read-active-file-p)) "") gnus-newsgroup-name)) (gnus-setup-message (quote message) (message-mail)))
(unwind-protect (progn (setq gnus-newsgroup-name (if arg (if (= 1 (prefix-numeric-value arg)) (gnus-group-completing-read "Use group" nil (gnus-read-active-file-p)) "") gnus-newsgroup-name)) (gnus-setup-message (quote message) (message-mail))) (with-current-buffer buffer (setq gnus-newsgroup-name group)))
(let ((group gnus-newsgroup-name) (gnus-article-copy) (buffer (current-buffer))) (unwind-protect (progn (setq gnus-newsgroup-name (if arg (if (= 1 (prefix-numeric-value arg)) (gnus-group-completing-read "Use group" nil (gnus-read-active-file-p)) "") gnus-newsgroup-name)) (gnus-setup-message (quote message) (message-mail))) (with-current-buffer buffer (setq gnus-newsgroup-name group))))
gnus-summary-mail-other-window(nil)
call-interactively(gnus-summary-mail-other-window nil nil)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] (gnus-setup-message): Declare `winconf-name'.
2011-02-22 9:47 [PATCH] (gnus-setup-message): Declare `winconf-name' David Edmondson
2011-02-22 17:38 ` Ted Zlatanov
@ 2011-02-23 8:11 ` Lars Ingebrigtsen
1 sibling, 0 replies; 3+ messages in thread
From: Lars Ingebrigtsen @ 2011-02-23 8:11 UTC (permalink / raw)
To: ding
David Edmondson <dme@dme.org> writes:
> + (winconf-name (make-symbol "gnus-setup-message-winconf-name"))
Thanks; I had added something like this but forgotten to push it out.
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-02-23 8:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-22 9:47 [PATCH] (gnus-setup-message): Declare `winconf-name' David Edmondson
2011-02-22 17:38 ` Ted Zlatanov
2011-02-23 8:11 ` Lars Ingebrigtsen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).