From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/77112 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.gnus.general Subject: Re: [PATCH] (gnus-setup-message): Declare `winconf-name'. Date: Tue, 22 Feb 2011 11:38:57 -0600 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <87lj18ynny.fsf@lifelogs.com> References: <1298368035-1950-1-git-send-email-dme@dme.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1298396384 11474 80.91.229.12 (22 Feb 2011 17:39:44 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 22 Feb 2011 17:39:44 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M25443@lists.math.uh.edu Tue Feb 22 18:39:40 2011 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PrwD4-0003WV-Aw for ding-account@gmane.org; Tue, 22 Feb 2011 18:39:38 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1PrwCh-0003ex-0q; Tue, 22 Feb 2011 11:39:15 -0600 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1PrwCf-0003ee-7J for ding@lists.math.uh.edu; Tue, 22 Feb 2011 11:39:13 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtp (Exim 4.72) (envelope-from ) id 1PrwCd-0007T2-Rb for ding@lists.math.uh.edu; Tue, 22 Feb 2011 11:39:13 -0600 Original-Received: from lo.gmane.org ([80.91.229.12]) by quimby.gnus.org with esmtp (Exim 4.72) (envelope-from ) id 1PrwCd-0003PK-3g for ding@gnus.org; Tue, 22 Feb 2011 18:39:11 +0100 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1PrwCb-0003Ei-8z for ding@gnus.org; Tue, 22 Feb 2011 18:39:09 +0100 Original-Received: from 38.98.147.130 ([38.98.147.130]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 22 Feb 2011 18:39:09 +0100 Original-Received: from tzz by 38.98.147.130 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 22 Feb 2011 18:39:09 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 105 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 38.98.147.130 X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6;d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" User-Agent: Gnus/5.110014 (No Gnus v0.14) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:R+4P/CaEm1tbZA4qmNBBtfgVbYk= X-Spam-Score: -0.7 (/) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:77112 Archived-At: On Tue, 22 Feb 2011 09:47:15 +0000 David Edmondson wrote:=20 DE> diff --git a/lisp/gnus-msg.el b/lisp/gnus-msg.el DE> index 29ac431..d715fc8 100644 DE> --- a/lisp/gnus-msg.el DE> +++ b/lisp/gnus-msg.el DE> @@ -383,6 +383,7 @@ Thank you for your help in stamping out bugs. DE> (defvar gnus-article-reply nil) DE> (defmacro gnus-setup-message (config &rest forms) DE> (let ((winconf (make-symbol "gnus-setup-message-winconf")) DE> + (winconf-name (make-symbol "gnus-setup-message-winconf-name")) DE> (buffer (make-symbol "gnus-setup-message-buffer")) DE> (article (make-symbol "gnus-setup-message-article")) DE> (yanked (make-symbol "gnus-setup-yanked-articles")) I don't know if I'm doing something wrong but it's not fixed for me after this patch. Maybe there's something in my setup. Backtrace below. Ted Debugger entered--Lisp error: (wrong-number-of-arguments (lambda (winconf b= uffer article &optional config yanked) (gnus-make-local-hook (quote message= -sent-hook)) (add-hook (quote message-sent-hook) (if gnus-agent (quote gnus= -agent-possibly-do-gcc) (quote gnus-inews-do-gcc)) nil t) (when gnus-agent = (gnus-make-local-hook (quote message-header-hook)) (add-hook (quote message= -header-hook) (quote gnus-agent-possibly-save-gcc) nil t)) (setq message-po= st-method (\` (lambda (&optional arg) (gnus-post-method arg (\, gnus-newsgr= oup-name))))) (message-add-action (\` (when (gnus-buffer-exists-p (\, buffe= r)) (set-window-configuration (\, winconf)))) (quote exit) (quote postpone)= (quote kill)) (let ((to-be-marked (cond (yanked (mapcar (lambda (x) (if (l= istp x) (car x) x)) yanked)) (article (if (listp article) article (list art= icle))) (t nil)))) (message-add-action (\` (when (gnus-buffer-exists-p (\, = buffer)) (with-current-buffer (\, buffer) (\, (when to-be-marked (if (eq co= nfig (quote forward)) (\` (gnus-summary-mark-article-as-forwarded (quote (\= , to-be-marked)))) (\` (gnus-summary-mark-article-as-replied (quote (\, to-= be-marked)))))))))) (quote send)))) 6) gnus-inews-add-send-actions(# "*Summary nntp+news.g= mane.org:gmane.emacs.gnus.general*" nil message nil reply-yank) (unwind-protect (progn (message-mail)) (gnus-inews-add-send-actions gnus-= setup-message-winconf gnus-setup-message-buffer gnus-setup-message-article = (quote message) gnus-setup-yanked-articles gnus-setup-message-winconf-name)= (setq gnus-message-buffer (current-buffer)) (set (make-local-variable (quo= te gnus-message-group-art)) (cons gnus-setup-message-group gnus-setup-messa= ge-article)) (set (make-local-variable (quote gnus-newsgroup-name)) gnus-se= tup-message-group) (when gnus-message-highlight-citation (gnus-message-cita= tion-mode 1)) (gnus-run-hooks (quote gnus-message-setup-hook)) (if (eq majo= r-mode (quote message-mode)) (let ((mbl1 mml-buffer-list)) (setq mml-buffer= -list mbl) (set (make-local-variable (quote mml-buffer-list)) mbl1) (gnus-m= ake-local-hook (quote kill-buffer-hook)) (gnus-make-local-hook (quote chang= e-major-mode-hook)) (add-hook (quote change-major-mode-hook) (quote mml-des= troy-buffers) nil t) (add-hook (quote kill-buffer-hook) (quote mml-destroy-= buffers) t t)) (mml-destroy-buffers) (setq mml-buffer-list mbl))) (let ((gnus-setup-message-winconf (current-window-configuration)) (gnus-s= etup-message-winconf-name gnus-current-window-configuration) (gnus-setup-me= ssage-buffer (buffer-name (current-buffer))) (gnus-setup-message-article gn= us-article-reply) (gnus-setup-yanked-articles gnus-article-yanked-articles)= (gnus-setup-message-group gnus-newsgroup-name) (message-header-setup-hook = (copy-sequence message-header-setup-hook)) (mbl mml-buffer-list) (message-m= ode-hook (copy-sequence message-mode-hook))) (setq mml-buffer-list nil) (ad= d-hook (quote message-header-setup-hook) (quote gnus-inews-insert-gcc)) (ad= d-hook (quote message-mode-hook) (lambda nil (setq message-newsreader (setq= message-mailer (gnus-extended-version))))) (add-hook (quote message-mode-h= ook) (if (memq (quote message) (quote (reply-yank reply))) (lambda nil (gnu= s-configure-posting-styles gnus-setup-message-group)) (lambda nil (let (gnu= s-article-copy) (gnus-configure-posting-styles gnus-setup-message-group))))= ) (gnus-alist-pull (quote X-Draft-From) message-required-headers) (when (an= d gnus-setup-message-group (not (string=3D gnus-setup-message-group ""))) (= push (cons (intern gnus-draft-meta-information-header) (gnus-inews-make-dra= ft (or gnus-setup-yanked-articles gnus-setup-message-article))) message-req= uired-headers)) (unwind-protect (progn (message-mail)) (gnus-inews-add-send= -actions gnus-setup-message-winconf gnus-setup-message-buffer gnus-setup-me= ssage-article (quote message) gnus-setup-yanked-articles gnus-setup-message= -winconf-name) (setq gnus-message-buffer (current-buffer)) (set (make-local= -variable (quote gnus-message-group-art)) (cons gnus-setup-message-group gn= us-setup-message-article)) (set (make-local-variable (quote gnus-newsgroup-= name)) gnus-setup-message-group) (when gnus-message-highlight-citation (gnu= s-message-citation-mode 1)) (gnus-run-hooks (quote gnus-message-setup-hook)= ) (if (eq major-mode (quote message-mode)) (let ((mbl1 mml-buffer-list)) (s= etq mml-buffer-list mbl) (set (make-local-variable (quote mml-buffer-list))= mbl1) (gnus-make-local-hook (quote kill-buffer-hook)) (gnus-make-local-hoo= k (quote change-major-mode-hook)) (add-hook (quote change-major-mode-hook) = (quote mml-destroy-buffers) nil t) (add-hook (quote kill-buffer-hook) (quot= e mml-destroy-buffers) t t)) (mml-destroy-buffers) (setq mml-buffer-list mb= l))) (message-hide-headers) (gnus-add-buffer) (gnus-configure-windows (quot= e message) t) (run-hooks (quote post-command-hook)) (set-buffer-modified-p = nil)) (gnus-setup-message (quote message) (message-mail)) (progn (setq gnus-newsgroup-name (if arg (if (=3D 1 (prefix-numeric-value= arg)) (gnus-group-completing-read "Use group" nil (gnus-read-active-file-p= )) "") gnus-newsgroup-name)) (gnus-setup-message (quote message) (message-m= ail))) (unwind-protect (progn (setq gnus-newsgroup-name (if arg (if (=3D 1 (pref= ix-numeric-value arg)) (gnus-group-completing-read "Use group" nil (gnus-re= ad-active-file-p)) "") gnus-newsgroup-name)) (gnus-setup-message (quote mes= sage) (message-mail))) (with-current-buffer buffer (setq gnus-newsgroup-nam= e group))) (let ((group gnus-newsgroup-name) (gnus-article-copy) (buffer (current-bu= ffer))) (unwind-protect (progn (setq gnus-newsgroup-name (if arg (if (=3D 1= (prefix-numeric-value arg)) (gnus-group-completing-read "Use group" nil (g= nus-read-active-file-p)) "") gnus-newsgroup-name)) (gnus-setup-message (quo= te message) (message-mail))) (with-current-buffer buffer (setq gnus-newsgro= up-name group)))) gnus-summary-mail-other-window(nil) call-interactively(gnus-summary-mail-other-window nil nil)