From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/76860 Path: news.gmane.org!not-for-mail From: Raphael Kubo da Costa Newsgroups: gmane.emacs.gnus.general Subject: Re: [PATCH] auth-source.el: Also load EIEIO when byte-compiling. Date: Thu, 17 Feb 2011 01:05:53 -0200 Message-ID: <87lj1fweb2.fsf@gmail.com> References: <1297907256-17277-1-git-send-email-kubito@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1297912462 32456 80.91.229.12 (17 Feb 2011 03:14:22 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 17 Feb 2011 03:14:22 +0000 (UTC) Cc: ding@gnus.org To: Katsumi Yamaoka Original-X-From: ding-owner+M25199@lists.math.uh.edu Thu Feb 17 04:14:18 2011 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PpuJt-0005Hj-N8 for ding-account@gmane.org; Thu, 17 Feb 2011 04:14:18 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1PpuJo-0003Sr-3E; Wed, 16 Feb 2011 21:14:12 -0600 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1PpuJl-0003SQ-N3 for ding@lists.math.uh.edu; Wed, 16 Feb 2011 21:14:09 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.72) (envelope-from ) id 1PpuJj-0003ha-NA for ding@lists.math.uh.edu; Wed, 16 Feb 2011 21:14:09 -0600 Original-Received: from mail-gx0-f172.google.com ([209.85.161.172]) by quimby.gnus.org with esmtp (Exim 4.72) (envelope-from ) id 1PpuJi-0007LC-QY for ding@gnus.org; Thu, 17 Feb 2011 04:14:06 +0100 Original-Received: by gxk27 with SMTP id 27so858771gxk.17 for ; Wed, 16 Feb 2011 19:14:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=oHAbC/BK7+wi/OnlgMTWZibtbSRrzfvVq6b6NXZbYXQ=; b=D2rLC4IoSOxLRvTXqzbdZ4iD3P3Q03Zo+ZksEKU0yDGyrph1QLlaJOX/1ilMLcgFjj mx2yPY0dwrPwVsuyrnsmuZ+UnDYwKHBwiAXWYoVwD6J3F2uz+8k3C6b/Pw41B+x5kVgd D1YSOTuLnfW85zXuhLrAhJp7Gb6qICd90Ci9g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=XwrrGIRFxOCwEGMBmZDKMb/Oo9Oeq1OIX9YQQRVQfsGya/H8dFiVLogSozc1n1rh1x J0bSEVtL364meKyPUddi6OdTAopGzwQ6xUj83n+K3oQYgSz/iuQrof9oAHujZypnxluG gX2YHHjzw7U0t9Nh6FZ1Ebiia3qH3v4EulmoI= Original-Received: by 10.236.102.165 with SMTP id d25mr2443406yhg.78.1297911964238; Wed, 16 Feb 2011 19:06:04 -0800 (PST) Original-Received: from gibbon.gmail.com ([189.61.209.106]) by mx.google.com with ESMTPS id 68sm305554yhl.19.2011.02.16.19.06.02 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 16 Feb 2011 19:06:03 -0800 (PST) In-Reply-To: (Katsumi Yamaoka's message of "Thu, 17 Feb 2011 11:59:12 +0900") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.2 (berkeley-unix) X-Spam-Score: -3.0 (---) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:76860 Archived-At: Katsumi Yamaoka writes: > Raphael Kubo da Costa wrote: >> Commit 4a0aa92 moved (require 'eieio) to an `or', and the >> byte-compiler only loads top-level `require' calls, which resulted in >> problems when the byte-compiler tried to evaluate the `defclass' >> macro. > >> The fallback loading code has also been changed -- there was a single >> condition being checked, and if it evaluated to t the `load' call was >> always made. > > Thanks. But I still get an error when loading auth-source.elc: > > Debugger entered--Lisp error: (void-variable auth-source-backend) > byte-code("\304^H\305\306\307\310\311\312... > > A workaround is to remove auth-source.elc in the installation > directory. Weird, that is what I was getting before the commit. I'm on GNU Emacs 23.2.1 here. Does it still happen if you run 'git clean -fdx && ./configure && make'? Before the patch, make would show a lot of warnings related to `defclass' not being defined when it was called in auth-source.el and it was being byte-compiled. After the patch, the warnings disappear and I can call (require 'auth-source) in the scratchb buffer without getting the void-variable errors.