Gnus development mailing list
 help / color / mirror / Atom feed
From: Julien Danjou <julien@danjou.info>
To: Michael Piotrowski <mxp@dynalabs.de>
Cc: ding@gnus.org
Subject: Re: Problem displaying multipart/alternative messages
Date: Thu, 20 Jan 2011 18:55:36 +0100	[thread overview]
Message-ID: <87lj2fxxwn.fsf@keller.adm.naquadah.org> (raw)
In-Reply-To: <x61v47k652.fsf@dynalabs.de> (Michael Piotrowski's message of "Thu, 20 Jan 2011 15:21:29 +0100")

[-- Attachment #1: Type: text/plain, Size: 1483 bytes --]

On Thu, Jan 20 2011, Michael Piotrowski wrote:

> The problem is the code after the comment "Remove empty parts" in
> `mm-preferred-alternative-precedence'.  If I remove this code, it works
> as before.
>
> The messages I'm referring to in my original post are of type
> "multipart/alternative", containing a "text/plain" and a
> "multipart/mixed" part.  The latter part typicalle consists of a
> "text/html" part and one or more attachments, e.g., "application/pdf".
> When displaying such a message,
>
>   (mm-handle-buffer handle)
>
> returns the string "multipart/mixed" instead of a buffer, and
> `with-current-buffer' then raises the error above.
>
> Does really nobody else encounter this problem?

I encountered it this morning too.
The problem come from the commit

commit d9418f8743d26df6253803ccb2ff8cdc88e8934f
Author: Lars Magne Ingebrigtsen <larsi@quimbies.gnus.org>
Date:   Tue Jan 11 20:20:56 2011 +0100

    (mm-preferred-alternative-precedence): Discourage showing empty parts.


it introduces this regression because it does:

#+begin_src emacs-lisp
    (unless (with-current-buffer (mm-handle-buffer handle)
      …))
#+end_src

Which fails, because some of the handle is not like the other:
calling mm-handle-buffer on it returns a string, not a buffer. The
handle entry is not in the same format (with buffer in car) that the
other. But Lars must know that I think.

-- 
Julien Danjou
❱ http://julien.danjou.info

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2011-01-20 17:55 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-13 10:42 Michael Piotrowski
2011-01-20 14:21 ` Michael Piotrowski
2011-01-20 17:55   ` Julien Danjou [this message]
2011-01-20 20:56     ` quoting Emacs Lisp (was: Problem displaying multipart/alternative messages) Ted Zlatanov
2011-01-20 21:05       ` quoting Emacs Lisp Julien Danjou
2011-01-20 21:17         ` Ted Zlatanov
2011-01-20 21:31           ` Julien Danjou
2011-01-20 21:36             ` Julien Danjou
2011-01-24  1:00             ` Lars Ingebrigtsen
2011-01-24 10:29               ` Julien Danjou
2011-01-24 17:51                 ` Ted Zlatanov
2011-01-24 21:47                   ` Lars Ingebrigtsen
2011-01-24 22:09                     ` Ted Zlatanov
2011-01-24 22:26                       ` Daniel Pfeiffer
2011-01-25 10:18                   ` Julien Danjou
2011-01-22  4:50         ` Lars Ingebrigtsen
2011-01-24  1:06     ` Problem displaying multipart/alternative messages Lars Ingebrigtsen
2011-01-22  4:48   ` Lars Ingebrigtsen
2011-01-22  8:06     ` Julien Danjou
2011-01-22 19:50       ` Eric S Fraga

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lj2fxxwn.fsf@keller.adm.naquadah.org \
    --to=julien@danjou.info \
    --cc=ding@gnus.org \
    --cc=mxp@dynalabs.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).