From: Daniel Dehennin <daniel.dehennin@baby-gnu.org>
To: ding@gnus.org
Subject: Re: mml2015-epg-sign does not use From header.
Date: Tue, 16 Nov 2010 00:23:38 +0100 [thread overview]
Message-ID: <87lj4uuq6d.fsf@hati.baby-gnu.org> (raw)
In-Reply-To: <87vd3ymb8d.fsf@hati.baby-gnu.org> (Daniel Dehennin's message of "Tue, 16 Nov 2010 00:13:38 +0100")
[-- Attachment #1: Type: text/plain, Size: 3390 bytes --]
Daniel Dehennin <daniel.dehennin@baby-gnu.org> writes:
> @@ -950,8 +951,8 @@ Whether the passphrase is cached at all is controlled by
> (epa-select-keys context "\
> Select keys for signing.
> If no one is selected, default secret key is used. "
> - mml2015-signers t)
> - (if mml2015-signers
> + (append mml2015-signers (list sender)) t)
> + (if (or sender mml2015-signers)
> (delq nil
> (mapcar
> (lambda (signer)
> @@ -965,7 +966,7 @@ If no one is selected, default secret key is used. "
> signer)))
> (error "No secret key for %s" signer))
> signer-key)
> - mml2015-signers)))))))
> + (append mml2015-signers (list sender)))))))))
> signature micalg)
> (epg-context-set-armor context t)
> (epg-context-set-textmode context t)
> --
> 1.7.2.3
I just see that the (append mml2015-signers (list sender)) can be
rewritten as (cons sender mml2015-signers), I thought about ordering at
first but it's just useless.
The same apply for the other patch.
---
lisp/mml2015.el | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/lisp/mml2015.el b/lisp/mml2015.el
index 7697f8a..5a515fa 100644
--- a/lisp/mml2015.el
+++ b/lisp/mml2015.el
@@ -951,7 +951,7 @@ Whether the passphrase is cached at all is controlled by
(epa-select-keys context "\
Select keys for signing.
If no one is selected, default secret key is used. "
- (append mml2015-signers (list sender)) t)
+ (cons sender mml2015-signers) t)
(if (or sender mml2015-signers)
(delq nil
(mapcar
@@ -966,7 +966,7 @@ If no one is selected, default secret key is used. "
signer)))
(error "No secret key for %s" signer))
signer-key)
- (append mml2015-signers (list sender)))))))))
+ (cons sender mml2015-signers))))))))
signature micalg)
(epg-context-set-armor context t)
(epg-context-set-textmode context t)
@@ -1029,7 +1029,7 @@ If no one is selected, default secret key is used. "
(when mml2015-encrypt-to-self
(unless (or sender mml2015-signers)
(error "Message sender and mml2015-signers not set"))
- (setq recipients (nconc recipients (append mml2015-signers (list sender)))))
+ (setq recipients (nconc recipients (cons sender mml2015-signers))))
(if (eq mm-encrypt-option 'guided)
(setq recipients
(epa-select-keys context "\
@@ -1062,7 +1062,7 @@ If no one is selected, symmetric encryption will be performed. "
(epa-select-keys context "\
Select keys for signing.
If no one is selected, default secret key is used. "
- (append mml2015-signers (list sender)) t)
+ (cons mml2015-signers) t)
(if (or sender mml2015-signers)
(delq nil
(mapcar
@@ -1077,7 +1077,7 @@ If no one is selected, default secret key is used. "
signer)))
(error "No secret key for %s" signer))
signer-key)
- (append mml2015-signers (list sender)))))))))
+ (cons mml2015-signers))))))))
(epg-context-set-signers context signers))
(epg-context-set-armor context t)
(epg-context-set-textmode context t)
--
1.7.2.3
--
Daniel Dehennin
Récupérer ma clef GPG:
gpg --keyserver pgp.mit.edu --recv-keys 0x6A2540D1
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2010-11-15 23:23 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-25 20:11 mml2015-epg-sign do not use from header Daniel Dehennin
2009-01-25 20:37 ` Reiner Steib
2009-01-25 20:43 ` Daniel Dehennin
2009-01-26 1:34 ` Daiki Ueno
2009-02-28 11:25 ` Reiner Steib
2009-03-01 3:27 ` Daiki Ueno
2009-01-28 11:57 ` Daniel Dehennin
2009-01-28 11:59 ` [PATCH] mml2015-epg-sign does " Daniel Dehennin
2009-03-01 17:13 ` Daiki Ueno
2009-03-03 18:59 ` Daniel Dehennin
2009-04-13 20:31 ` Daniel Dehennin
2009-04-13 20:32 ` [PATCH] mml2015-epg-encrypt do not use from header to sign Daniel Dehennin
2009-01-28 12:00 ` [PATCH] Factor spliting mail addresses Daniel Dehennin
2009-04-13 20:32 ` Daniel Dehennin
2009-01-28 12:01 ` [PATCH] Cleanup selecting a key for sign and encryption Daniel Dehennin
2009-04-13 20:32 ` Daniel Dehennin
2009-01-28 12:02 ` [PATCH] Only one sender Daniel Dehennin
2009-04-13 20:32 ` Daniel Dehennin
2009-01-28 12:02 ` Daniel Dehennin
2009-04-13 20:32 ` Daniel Dehennin
2009-01-28 12:02 ` [PATCH] Factorize choosing a key Daniel Dehennin
2009-04-13 20:33 ` Daniel Dehennin
2009-01-28 12:02 ` [PATCH] mml2015-epg-choose-keys handle the verbose selection of keys Daniel Dehennin
2009-04-13 20:33 ` Daniel Dehennin
2009-01-28 12:02 ` [PATCH] Fix variable name, only one sender Daniel Dehennin
2009-01-28 12:02 ` [PATCH] Remove useless variables Daniel Dehennin
2009-04-13 20:33 ` Daniel Dehennin
2009-01-28 12:03 ` [PATCH] Permit to select a key if more than one match a mail address Daniel Dehennin
2009-04-13 20:33 ` Daniel Dehennin
2009-04-13 20:31 ` mml2015-epg-sign do not use from header Daniel Dehennin
2009-04-13 22:48 ` Daiki Ueno
2010-11-15 23:11 ` Daniel Dehennin
2010-11-15 23:13 ` mml2015-epg-sign does not use From header Daniel Dehennin
2010-11-15 23:23 ` Daniel Dehennin [this message]
2010-11-16 18:21 ` mml2015-epg-sign do not use from header Lars Magne Ingebrigtsen
2010-11-16 20:23 ` Daniel Dehennin
2010-11-16 20:27 ` Lars Magne Ingebrigtsen
2010-11-16 20:45 ` Daniel Dehennin
2010-11-17 7:34 ` Katsumi Yamaoka
2010-11-17 17:06 ` Daniel Dehennin
2010-11-17 17:13 ` Lars Magne Ingebrigtsen
2010-11-17 17:37 ` Merging ChangeLogs (was: mml2015-epg-sign do not use from header) Sven Joachim
2010-11-21 4:51 ` Merging ChangeLogs Lars Magne Ingebrigtsen
2010-11-21 7:38 ` Sven Joachim
2010-11-21 7:43 ` Lars Magne Ingebrigtsen
2010-11-21 8:12 ` Sven Joachim
2010-11-21 8:19 ` Sven Joachim
2010-11-22 19:42 ` Ted Zlatanov
2010-11-24 21:13 ` Lars Magne Ingebrigtsen
2010-11-17 18:07 ` mml2015-epg-sign do not use from header Julien Danjou
2010-11-21 4:49 ` Lars Magne Ingebrigtsen
2010-11-17 23:08 ` Daniel Dehennin
2010-11-21 4:47 ` Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lj4uuq6d.fsf@hati.baby-gnu.org \
--to=daniel.dehennin@baby-gnu.org \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).