From: Dave Love <fx@gnu.org>
To: Ted Zlatanov <tzz@lifelogs.com>
Cc: ding@gnus.org
Subject: Re: FIXMEs in imap.el and nnimap.el
Date: Wed, 07 Jan 2009 21:07:59 +0000 [thread overview]
Message-ID: <87ljtmddu8.fsf@liv.ac.uk> (raw)
In-Reply-To: <87priydeqd.fsf@liv.ac.uk> (Dave Love's message of "Sun, 04 Jan 2009 23:10:50 +0000")
[-- Attachment #1: Type: text/plain, Size: 371 bytes --]
I wrote:
> Certainly my version of imap-fetch-safe will fail if it's not called
> with a pair.
Sorry, I was confused by the context and just realized that the typo is
in my code originally. I don't understand that, because (a) I thought
I'd fixed it before sending the patch, and (b) I thought I was running
with a copy up-to-date with CVS... Anyhow, this is right:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 724 bytes --]
2009-01-07 Dave Love <fx@gnu.org>
* imap.el (imap-message-appenduid-1): Fix typo in imap-fetch-safe call.
Index: imap.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/imap.el,v
retrieving revision 7.50
diff -u -r7.50 imap.el
--- imap.el 1 Jan 2009 18:50:34 -0000 7.50
+++ imap.el 7 Jan 2009 20:49:30 -0000
@@ -1870,7 +1870,7 @@
(imap-message-data (make-vector 2 0)))
(when (imap-mailbox-examine-1 mailbox)
(prog1
- (and (imap-fetch-safe '("*" "*:*") "UID")
+ (and (imap-fetch-safe '("*" . "*:*") "UID")
(list (imap-mailbox-get-1 'uidvalidity mailbox)
(apply 'max (imap-message-map
(lambda (uid prop) uid) 'UID))))
next prev parent reply other threads:[~2009-01-07 21:07 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87iqphil5p.fsf@liv.ac.uk>
2008-12-22 22:38 ` imap.el workaround for Exchange 2007 Reiner Steib
2008-12-23 15:41 ` Dave Love
2009-01-01 18:34 ` Reiner Steib
2009-01-02 22:20 ` Ted Zlatanov
2009-01-02 22:38 ` Reiner Steib
2009-01-09 12:00 ` Simon Josefsson
2009-01-01 18:55 ` FIXMEs in imap.el and nnimap.el (was: imap.el workaround for Exchange 2007) Reiner Steib
2009-01-02 22:19 ` FIXMEs in imap.el and nnimap.el Ted Zlatanov
2009-01-02 22:57 ` Reiner Steib
2009-01-04 23:10 ` Dave Love
2009-01-07 21:07 ` Dave Love [this message]
2009-01-08 20:42 ` Reiner Steib
2009-01-07 19:25 ` Ted Zlatanov
2009-01-08 21:04 ` Reiner Steib
2009-01-13 10:40 ` Dave Love
2009-01-13 17:00 ` IMAP and Exchange 2007 - imap-fetch-safe (was: FIXMEs in imap.el and nnimap.el) Reiner Steib
2009-01-13 17:20 ` IMAP and Exchange 2007 - imap-fetch-safe Simon Josefsson
2009-01-17 20:58 ` Dave Love
2009-01-28 1:18 ` Dave Love
2009-01-31 15:27 ` Reiner Steib
2009-02-01 15:43 ` Bjorn Solberg
2009-02-02 14:54 ` Dave Goldberg
2009-02-02 19:19 ` Reiner Steib
2009-02-03 16:21 ` Stephen J. Turnbull
2009-02-08 18:00 ` Dave Love
2009-02-08 18:38 ` Dave Goldberg
2009-02-02 19:15 ` Reiner Steib
2009-01-13 18:28 ` Bjorn Solberg
2009-01-13 20:18 ` Bjorn Solberg
2009-01-17 20:59 ` Dave Love
2009-01-04 20:08 ` FIXMEs in imap.el and nnimap.el Dave Love
2009-01-05 16:13 ` Dave Love
2009-01-05 20:35 ` Conventions (was: FIXMEs in imap.el and nnimap.el) Reiner Steib
2009-01-06 11:33 ` Conventions Tassilo Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ljtmddu8.fsf@liv.ac.uk \
--to=fx@gnu.org \
--cc=ding@gnus.org \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).