From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/68104 Path: news.gmane.org!not-for-mail From: Dave Love Newsgroups: gmane.emacs.gnus.general Subject: Re: FIXMEs in imap.el and nnimap.el Date: Wed, 07 Jan 2009 21:07:59 +0000 Message-ID: <87ljtmddu8.fsf@liv.ac.uk> References: <87iqphil5p.fsf@liv.ac.uk> <87ocz3n8d4.fsf@marauder.physik.uni-ulm.de> <87iqpa99wy.fsf@liv.ac.uk> <87wsde7t5j.fsf_-_@marauder.physik.uni-ulm.de> <86mye95p27.fsf@lifelogs.com> <878wpt48qj.fsf@marauder.physik.uni-ulm.de> <87priydeqd.fsf@liv.ac.uk> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="munitions-csystems-espionage-nitrate-ANC" X-Trace: ger.gmane.org 1231363994 11469 80.91.229.12 (7 Jan 2009 21:33:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 7 Jan 2009 21:33:14 +0000 (UTC) Cc: ding@gnus.org To: Ted Zlatanov Original-X-From: ding-owner+M16549@lists.math.uh.edu Wed Jan 07 22:34:25 2009 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1LKg2b-0005jL-Jr for ding-account@gmane.org; Wed, 07 Jan 2009 22:34:17 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1LKg16-00034u-5J; Wed, 07 Jan 2009 15:32:44 -0600 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1LKfcs-0002yc-FA for ding@lists.math.uh.edu; Wed, 07 Jan 2009 15:07:42 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.69) (envelope-from ) id 1LKfcp-0005gv-7u for ding@lists.math.uh.edu; Wed, 07 Jan 2009 15:07:42 -0600 Original-Received: from mxb.liv.ac.uk ([138.253.100.102]) by quimby.gnus.org with esmtp (Exim 3.36 #1 (Debian)) id 1LKfd5-0005hZ-00 for ; Wed, 07 Jan 2009 22:07:55 +0100 Original-Received: from mailhuba.liv.ac.uk ([138.253.100.36]) by mxb.liv.ac.uk with esmtp (Exim 4.67) (envelope-from ) id 1LKfcK-0005Z2-3i for ding@gnus.org; Wed, 07 Jan 2009 21:07:08 +0000 Original-Received: from localhost ([127.0.0.1] helo=mailhuba.liv.ac.uk) by mailhuba.liv.ac.uk with esmtp (Exim 4.67) (envelope-from ) id 1LKfcK-0005s1-1S; Wed, 07 Jan 2009 21:07:08 +0000 Original-Received: from pc102091.liv.ac.uk ([138.253.102.91] helo=albion) by mailhuba.liv.ac.uk with esmtps (TLSv1:AES256-SHA:256) (Exim 4.67) (envelope-from ) id 1LKfcJ-0005ry-RV; Wed, 07 Jan 2009 21:07:07 +0000 Original-Received: from dlove by albion with local (Exim 4.69) (envelope-from ) id 1LKfd9-0001K4-Dz; Wed, 07 Jan 2009 21:07:59 +0000 X-Draft-From: ("nntp+news.gmane.org:gmane.emacs.gnus.general" 68103) In-Reply-To: <87priydeqd.fsf@liv.ac.uk> (Dave Love's message of "Sun, 04 Jan 2009 23:10:50 +0000") User-Agent: Gnus/5.110011 (No Gnus v0.11) X-Spam-Score: -5.6 (-----) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:68104 Archived-At: --munitions-csystems-espionage-nitrate-ANC I wrote: > Certainly my version of imap-fetch-safe will fail if it's not called > with a pair. Sorry, I was confused by the context and just realized that the typo is in my code originally. I don't understand that, because (a) I thought I'd fixed it before sending the patch, and (b) I thought I was running with a copy up-to-date with CVS... Anyhow, this is right: --munitions-csystems-espionage-nitrate-ANC Content-Type: text/x-patch Content-Disposition: inline 2009-01-07 Dave Love * imap.el (imap-message-appenduid-1): Fix typo in imap-fetch-safe call. Index: imap.el =================================================================== RCS file: /usr/local/cvsroot/gnus/lisp/imap.el,v retrieving revision 7.50 diff -u -r7.50 imap.el --- imap.el 1 Jan 2009 18:50:34 -0000 7.50 +++ imap.el 7 Jan 2009 20:49:30 -0000 @@ -1870,7 +1870,7 @@ (imap-message-data (make-vector 2 0))) (when (imap-mailbox-examine-1 mailbox) (prog1 - (and (imap-fetch-safe '("*" "*:*") "UID") + (and (imap-fetch-safe '("*" . "*:*") "UID") (list (imap-mailbox-get-1 'uidvalidity mailbox) (apply 'max (imap-message-map (lambda (uid prop) uid) 'UID)))) --munitions-csystems-espionage-nitrate-ANC--