From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/67438 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.gnus.general Subject: Re: Comments in References Date: Wed, 24 Sep 2008 22:16:00 +0200 Message-ID: <87ljxhpaf3.fsf@marauder.physik.uni-ulm.de> References: <87hc85qy0z.fsf@marauder.physik.uni-ulm.de> Reply-To: Reiner Steib NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1222287403 23979 80.91.229.12 (24 Sep 2008 20:16:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 24 Sep 2008 20:16:43 +0000 (UTC) Cc: ding@gnus.org To: Andreas Schwab Original-X-From: ding-owner+M15889@lists.math.uh.edu Wed Sep 24 22:17:41 2008 connect(): Connection refused Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1Kianm-0005lH-Ai for ding-account@gmane.org; Wed, 24 Sep 2008 22:17:34 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1KiamP-00047g-Pb; Wed, 24 Sep 2008 15:16:09 -0500 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1KiamO-00047J-Dl for ding@lists.math.uh.edu; Wed, 24 Sep 2008 15:16:08 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.69) (envelope-from ) id 1KiamK-0004rF-RW for ding@lists.math.uh.edu; Wed, 24 Sep 2008 15:16:08 -0500 Original-Received: from mail.uni-ulm.de ([134.60.1.11]) by quimby.gnus.org with esmtp (Exim 3.36 #1 (Debian)) id 1KiamP-0007xv-00 for ; Wed, 24 Sep 2008 22:16:09 +0200 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.41.37]) by mail.uni-ulm.de (8.14.2/8.14.2) with ESMTP id m8OKG3bt007612; Wed, 24 Sep 2008 22:16:03 +0200 (MEST) Original-Received: from localhost (localhost [127.0.0.1]) by bridgekeeper.physik.uni-ulm.de (Postfix) with ESMTP id 2E59113325; Wed, 24 Sep 2008 22:16:03 +0200 (CEST) X-Face: 3Phac&+dw=IZHjhua]bp}LH<*p{qzj8u+ Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:67438 Archived-At: On Wed, Sep 24 2008, Andreas Schwab wrote: > Reiner Steib writes: >> On Wed, Sep 24 2008, Andreas Schwab wrote: >>> Should gnus-parent-id strip comments, or is this the duty of its >>> callers? >> >> According to it's doc string, I'd say `gnus-parent-id' should strip >> it: [...] > What about this then? I've tested it with > gmane.linux.kernel.wireless.general, the false orphans are now correctly > threaded. [...] > * gnus-util.el (gnus-split-references): Strip comments. > (gnus-parent-id): Likewise. Looks good, thank. Unless someone points out a problem (within ~1 day), please install[1] it. I'd say there is no doubt that this qualifies as a bug fix (I assume you verified that the RFCs allow CFWS). Bye, Reiner. [1] AFAIK you don't have write access to cvs.gnus.org. So install it in Emacs CVS. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/