Re: [PATCH] Improve Gnus sieve integration

[Simon Josefsson <simon@josefsson.org>]

Daniel Pittman <daniel@rimspace.net> writes:

> The attached patch changes this: it extends the support to be able to
> use managesieve to upload the generated Sieve script to a managesieve
> server as well as to upload through running a shell command.

Cool!

The documentation needs to be modified, though, or possibly your code
could be aligned to match the current documentation to avoid backwards
compatibility problems.  The current manual says:

`D g'
     Regenerate a Sieve script from the `sieve' group parameters and
     put you into the `gnus-sieve-file' without saving it.

`D u'
     Regenerates the Gnus managed part of `gnus-sieve-file' using the
     `sieve' group parameters, save the file and upload it to the
     server using the `sieveshell' program.

Maybe your after-save-hook stuff could be replaced by having a new
command that can be invoked in the sieve buffer, to upload the file?
Then people can use D g as before, and have a new option of easily
uploading it via managesieve, or use D u as before too.

Alternatively, the after-save-hook could ask whether the user wants to
upload the file too?  Then both D g and D u would work as documented,
and users would have no surprises and a better experience.  The prompt
could be yes/no/always where always saved a customization of a variable
to remove the prompt.

Just some ideas.

/Simon