From: Simon Josefsson <simon@josefsson.org>
To: "Bjørn Mork" <bmork@dod.no>
Cc: ding@gnus.org
Subject: Re: Speeding up nnimap expiry when both source and target are groups on the same imap server
Date: Mon, 18 Jun 2007 19:14:46 +0200 [thread overview]
Message-ID: <87lkehrxq1.fsf@mocca.josefsson.org> (raw)
In-Reply-To: <87fy4u9t1r.fsf@obelix.mork.no> (=?iso-8859-1?Q?=22Bj=F8rn?= Mork"'s message of "Thu, 14 Jun 2007 22:31:44 +0200")
Bjørn Mork <bmork@dod.no> writes:
> I believe I've posted this before, but let's try again... I've been
> using this patch for quite a while:
I don't use expiring... could someone else that uses expiring with
nnimap test this please? I'm not sure whether to install it without
someone else testing it first.
/Simon
>
> Index: lisp/nnimap.el
> ===================================================================
> RCS file: /usr/local/cvsroot/gnus/lisp/nnimap.el,v
> retrieving revision 7.35
> diff -u -r7.35 nnimap.el
> --- lisp/nnimap.el 24 May 2007 15:16:12 -0000 7.35
> +++ lisp/nnimap.el 14 Jun 2007 20:28:16 -0000
> @@ -1465,14 +1465,23 @@
>
> (defun nnimap-expiry-target (arts group server)
> (unless (eq nnmail-expiry-target 'delete)
> - (with-temp-buffer
> - (dolist (art arts)
> - (nnimap-request-article art group server (current-buffer))
> - ;; hints for optimization in `nnimap-request-accept-article'
> - (let ((nnimap-current-move-article art)
> - (nnimap-current-move-group group)
> - (nnimap-current-move-server server))
> - (nnmail-expiry-target-group nnmail-expiry-target group))))
> + (if (and (not (functionp nnmail-expiry-target))
> + (gnus-server-equal (gnus-group-method nnmail-expiry-target)
> + (gnus-server-to-method
> + (format "nnimap:%s" server))))
> + ;; moving article within same server, speed it up...
> + (and (nnimap-possibly-change-group group)
> + (imap-message-copy (imap-range-to-message-set arts)
> + (gnus-group-short-name nnmail-expiry-target)
> + 'dontcreate nil nnimap-server-buffer))
> + (with-temp-buffer
> + (dolist (art arts)
> + (nnimap-request-article art group server (current-buffer))
> + ;; hints for optimization in `nnimap-request-accept-article'
> + (let ((nnimap-current-move-article art)
> + (nnimap-current-move-group group)
> + (nnimap-current-move-server server))
> + (nnmail-expiry-target-group nnmail-expiry-target group)))))
> ;; It is not clear if `nnmail-expiry-target' somehow cause the
> ;; current group to be changed or not, so we make sure here.
> (nnimap-possibly-change-group group server)))
>
>
> Is it something that could be considered for Gnus, or am I the only one
> ever to get frustrated by slow nnimap expiry?
>
>
>
> Bjørn
> --
> It takes a Moonie ignoramus like you to say that every Iranian person
> is a incompetent.
prev parent reply other threads:[~2007-06-18 17:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-14 20:31 Bjørn Mork
2007-06-18 17:14 ` Simon Josefsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lkehrxq1.fsf@mocca.josefsson.org \
--to=simon@josefsson.org \
--cc=bmork@dod.no \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).