[Fixed] list identifiers don't disappear in summary

[Fixed] list identifiers don't disappear in summary

[Katsumi Yamaoka]

Hi,

I fixed a bug that list identifiers didn't disappear in summary
lines even if `gnus-list-identifiers' is specified.  It occurred
when typing `P', `^', `j' etc. in the summary buffer.

In addition to this, I've merged the bugfix for spam-stat.el
done by Hiroshi Fujishima in the trunk into the v5-10 branch.

I would appreciate someone merging those changes into Emacs CVS.

Regards,

Re: [Fixed] list identifiers don't disappear in summary

[Katsumi Yamaoka]

>>>>> In <hhwtzbzuzw.fsf@blah.pl> Maciej Matysiak wrote:

>>   4 | (0.4k:  13) Exceptions to globs                        Björn Lindström
>>   2 | (0.5k:  21) ¦-»                                        Peter Bowyer
>>| (1.4k:  41) ¦ ·-»                                      Philip Hazel
>>| (0.6k:  23) ·-»                                        David Woodhouse

>>   3 | (1.3k:  38) Re: [Exim] Retry timeout option of "defer" Dean Brooks
>>   2 | (1.4k:  36) ·-»                                        Philip Hazel
>>| (0.9k:  25)   ·-»                                      Alan J. Flavell

> <    3 | (0.0k:   0) Re: [exim] Future architectures            
>>| (0.8k:  32) ¦-»                                        Edgar Lovecraft
>>| (0.5k:  16) ·-»                                        Philip Hazel

> as you can see, only subject in thread with the first article has stripped
> list-identifier. which is a bug, i think. i'd be very happy to see it fixed
> at last :) (it's there since may, afair).

I tried it using the configuration similar to yours.  But, hmm,
I couldn't reproduce such a problem so far.  I need to look into
it further...

shy group bug in XEmacs 21.4 (was Re: [Fixed] list identifiers...)

[Katsumi Yamaoka]

>>>>> In <b9y3c1zdaes.fsf@jpl.org> Katsumi Yamaoka wrote:

> I need to look into it further...

I discovered what's wrong.  The problem is caused by a bug of
XEmacs 21.4.  Emacs 21.x and XEmacs 21.5 return `0' for the
following form, but XEmacs 21.4 returns nil for it.

(let ((subject "Re: [Exim] Exceptions to globs")
      (regexp "^\\(?:R[Ee]: +\\)*\\(\\[Exim\\] *\\)"))
  (string-match regexp subject))

The reason why the list identifier is removed in the parent
article is that the subject doesn't begin with `Re: '.

A special regexp called `shy group' is there.  XEmacs 21.4
supports it but doesn't seem to work in some cases.  The recent
Gnus uses it in several Lisp modules, however I don't know
whether we should restore all or some as before.

If anything, I don't feel like degenerating them.  Because using
`shy group' is hopeful to improve the performance.  Isn't there
a chance of fixing XEmacs 21.4?

Re: shy group bug in XEmacs 21.4

[Stephen J. Turnbull]

>>>>> "KY" == Katsumi Yamaoka <yamaoka@jpl.org> writes:

    KY> If anything, I don't feel like degenerating them.  Because
    KY> using `shy group' is hopeful to improve the performance.

IIRC, shy groups by themselves make negligible difference to XEmacs's
regexps.  I think the improvement in clarity and flexibility of
subexpressions is well worth it though.

    KY> Isn't there a chance of fixing XEmacs 21.4?

It depends on exactly what code needs to be changed, although Vin
S. has final say either way.  Do you have any idea where the bug is?
It's been a while since I looked at regexp.c.


-- 
Institute of Policy and Planning Sciences     http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba                    Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
               Ask not how you can "do" free software business;
              ask what your business can "do for" free software.

Re: shy group bug in XEmacs 21.4

[Katsumi Yamaoka]

>>>>> In <878ybr4c1s.fsf@tleepslib.sk.tsukuba.ac.jp> 
>>>>>	"Stephen J. Turnbull" <stephen@xemacs.org> wrote:

> IIRC, shy groups by themselves make negligible difference to XEmacs's
> regexps.  I think the improvement in clarity and flexibility of
> subexpressions is well worth it though.

That's quite right.

>     KY> Isn't there a chance of fixing XEmacs 21.4?

> It depends on exactly what code needs to be changed, although Vin
> S. has final say either way.  Do you have any idea where the bug is?
> It's been a while since I looked at regexp.c.

I'm not reliable in C, probably I've never opened it, sorry.

Re: [Fixed] list identifiers don't disappear in summary

[Miles Bader]

Katsumi Yamaoka <yamaoka@jpl.org> writes:
> In addition to this, I've merged the bugfix for spam-stat.el
> done by Hiroshi Fujishima in the trunk into the v5-10 branch.
>
> I would appreciate someone merging those changes into Emacs CVS.

I've done this, and will also merge all future Gnus v5-10 commits into
Emacs CVS.

-Miles
-- 
"Unless there are slaves to do the ugly, horrible, uninteresting work, culture
and contemplation become almost impossible. Human slavery is wrong, insecure,
and demoralizing.  On mechanical slavery, on the slavery of the machine, the
future of the world depends." -Oscar Wilde, "The Soul of Man Under Socialism"