Gnus v5.10.5 is released

Gnus v5.10.5 is released

[Lars Magne Ingebrigtsen]

Possibly the last Gnus 5.10 release.

Get it from <URL:http://quimby.gnus.org/gnus/dist/gnus-5.10.5.tar.gz>
or "/ftp@quimby.gnus.org:/pub/gnus/".  The patch is available as
<URL:ftp://quimby.gnus.org/pub/gnus/ding-patches/gnus-5.10.4-5.10.5.diff.gz>.

ChangeLog since last release:

2004-01-04 Lars Magne Ingebrigtsen <lars@ingebrigtsen.no>

	* gnus.el: Gnus v5.10.5 is released.

2004-01-03  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* gnus-fun.el (gnus-face-from-file): Message 9.

2004-01-03  Romain FRANCOISE  <romain@orebokech.com>

	* gnus-fun.el (gnus-face-from-file): Use gnus-message.

2004-01-03  Reiner Steib  <Reiner.Steib@gmx.de>

	* gnus-art.el (gnus-button-mid-or-mail-heuristic): Treat Gmane
	addresses specially.  Fix returned value and messages.

	* mm-decode.el (mm-enable-external): New variable.
	(mm-display-part): Use it.
	(mm-display-external): Fix message in case of nil handle.

	* Update copyright for several files.

	* spam-report.el (spam-report-gmane): Adjust verbosity.
	Delete trailing whitespace.  Update copyright.

	* spam.el: Fix many (but not all) checkdoc complaints.
	Delete trailing whitespace.

	* message.el (message-header-synonyms): Defcustom.
	(message-get-reply-headers): Catch `Original-To'.
	(message-carefully-insert-headers): Added comment.

	* gnus-sum.el (gnus-summary-make-menu-bar): Improved "Washing" menu.

2004-01-03  Lars Magne Ingebrigtsen  <larsi@gnus.org>

	* gnus-sum.el (gnus-select-newsgroup): Use cat.

	* gnus-agent.el (gnus-agent-cat-enable-undownloaded-faces): New
	cat. 

	* gnus.el (gnus-user-agent): Moved here.

	* gnus-msg.el (gnus-user-agent): Moved from here.

	* gnus.el (gnus-version-number): Bump.



-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Gnus v5.10.5 is released

[Gaute B Strokkenes]

[-- Attachment #1: Type: text/plain, Size: 783 bytes --]

On 4 jan 2004, larsi@gnus.org wrote:

> Possibly the last Gnus 5.10 release.

I think that before we make the transition to No Gnus, the follwoing
almost-trivial patch should be applied.

Kevin Greiner gave his approval to this patch way back in May, but did
not apply it straight away, since this was straight after Lars
announced that he wanted there to be more focus on fixing bugs rather
than new features in anticipation of No Gnus.  See
<87bry4sk0n.fsf@cam.ac.uk> and the surrounding discussion.

I think that the patch should be applied now since it is small and
tidy, serves a demonstrable need and has been very thoroughly tested
by yours truly in the months following May (more than half a year).
There have been lots of other patches applied that are far more
intrusive.


[-- Attachment #2: gnus-agent.diff --]
[-- Type: text/plain, Size: 6249 bytes --]

Index: lisp/gnus-agent.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-agent.el,v
retrieving revision 6.186
diff -u -r6.186 gnus-agent.el
--- lisp/gnus-agent.el	3 Jan 2004 18:52:57 -0000	6.186
+++ lisp/gnus-agent.el	4 Jan 2004 07:07:39 -0000
@@ -181,6 +181,21 @@
   :type 'boolean
   :group 'gnus-agent)
 
+(defcustom gnus-agent-queue-mail t
+  "Whether and when outgoing mail should be queued by the agent.  When
+`always', always queue outgoing mail.  When `nil', never queue.
+Otherwise, queue if and only if unplugged."
+  :group 'gnus-agent
+  :type '(radio (const :format "Always" always)
+		(const :format "Never" nil)
+		(const :format "When plugged" t)))
+
+(defcustom gnus-agent-prompt-send-queue nil
+  "If non-nil, `gnus-group-send-queue' will prompt if called when
+unplugged."
+  :group 'gnus-agent
+  :type 'boolean)
+
 (defcustom gnus-agent-auto-agentize-methods '(nntp nnimap)
   "Initially, all servers from these methods are agentized.
 The user may remove or add servers using the Server buffer.
@@ -642,7 +657,8 @@
      'gnus-dummy '((gnus-draft-mode)))))
 
 (defun gnus-agent-send-mail ()
-  (if gnus-plugged
+  (if (or (not gnus-agent-queue-mail)
+	  (and gnus-plugged (not (eq gnus-agent-queue-mail 'always))))
       (funcall gnus-agent-send-mail-function)
     (goto-char (point-min))
     (re-search-forward
Index: lisp/gnus-draft.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-draft.el,v
retrieving revision 6.24
diff -u -r6.24 gnus-draft.el
--- lisp/gnus-draft.el	12 Dec 2003 16:31:46 -0000	6.24
+++ lisp/gnus-draft.el	4 Jan 2004 07:07:40 -0000
@@ -142,6 +142,9 @@
 				message-send-hook))
 	(message-setup-hook (and group (not (equal group "nndraft:queue"))
 				 message-setup-hook))
+	(gnus-agent-queue-mail (if (equal group "nndraft:queue")
+				   nil
+				 gnus-agent-queue-mail))
 	type method move-to)
     (gnus-draft-setup article (or group "nndraft:queue"))
     ;; We read the meta-information that says how and where
@@ -196,22 +199,25 @@
 (defun gnus-group-send-queue ()
   "Send all sendable articles from the queue group."
   (interactive)
-  (gnus-activate-group "nndraft:queue")
-  (save-excursion
-    (let* ((articles (nndraft-articles))
-	   (unsendable (gnus-uncompress-range
-			(cdr (assq 'unsend
-				   (gnus-info-marks
-				    (gnus-get-info "nndraft:queue"))))))
-	   (gnus-posting-styles nil)
-	   (total (length articles))
-	   article)
-      (while (setq article (pop articles))
-	(unless (memq article unsendable)
-	  (let ((message-sending-message
-		 (format "Sending message %d of %d..."
-			 (- total (length articles)) total)))
-	    (gnus-draft-send article)))))))
+  (when (or gnus-plugged
+	    (not gnus-agent-prompt-send-queue)
+	    (gnus-y-or-n-p "Gnus is unplugged; really send queue? "))
+    (gnus-activate-group "nndraft:queue")
+    (save-excursion
+      (let* ((articles (nndraft-articles))
+	     (unsendable (gnus-uncompress-range
+			  (cdr (assq 'unsend
+				     (gnus-info-marks
+				      (gnus-get-info "nndraft:queue"))))))
+	     (gnus-posting-styles nil)
+	     (total (length articles))
+	     article)
+	(while (setq article (pop articles))
+	  (unless (memq article unsendable)
+	    (let ((message-sending-message
+		   (format "Sending message %d of %d..."
+			   (- total (length articles)) total)))
+	      (gnus-draft-send article "nndraft:queue"))))))))
 
 ;;;###autoload
 (defun gnus-draft-reminder ()
Index: texi/gnus.texi
===================================================================
RCS file: /usr/local/cvsroot/gnus/texi/gnus.texi,v
retrieving revision 6.601
diff -u -r6.601 gnus.texi
--- texi/gnus.texi	4 Jan 2004 03:20:18 -0000	6.601
+++ texi/gnus.texi	4 Jan 2004 07:08:03 -0000
@@ -18388,16 +18388,24 @@
 @node Outgoing Messages
 @subsection Outgoing Messages
 
-When Gnus is unplugged, all outgoing messages (both mail and news) are
-stored in the draft group ``queue'' (@pxref{Drafts}).  You can view
-them there after posting, and edit them at will.
-
-When Gnus is plugged again, you can send the messages either from the
-draft group with the special commands available there, or you can use
-the @kbd{J S} command in the group buffer to send all the sendable
-messages in the draft group.
-
-
+By default, when Gnus is unplugged, all outgoing messages (both mail
+and news) are stored in the draft group ``queue'' (@pxref{Drafts}).
+You can view them there after posting, and edit them at will.
+
+You can control the circumstances under which outgoing mail is queued
+(see @code{gnus-agent-queue-mail}, @pxref{Agent Variables}).  Outgoing
+news is always queued when Gnus is unplugged, and never otherwise.
+
+You can send the messages either from the draft group with the special
+commands available there, or you can use the @kbd{J S} command in the
+group buffer to send all the sendable messages in the draft group.
+Posting news will only work when Gnus is plugged, but you can send
+mail at any time.
+
+If sending mail while unplugged does not work for you and you worry
+about hitting @kbd{J S} by accident when unplugged, you can have Gnus
+ask you to confirm your action (see
+@code{gnus-agent-prompt-send-queue}, @pxref{Agent Variables}).
 
 @node Agent Variables
 @subsection Agent Variables
@@ -18496,6 +18504,19 @@
 have not been fetched), @code{always-undownloaded} (maneuvering always
 ignores articles that have not been fetched), @code{unfetched}
 (maneuvering ignores articles whose headers have not been fetched).
+
+@item gnus-agent-queue-mail
+@vindex gnus-agent-queue-mail
+When @code{gnus-agent-queue-mail} is @code{always}, Gnus will always
+queue mail rather than sending it straight away.  When @code{t}, Gnus
+will queue mail when unplugged only.  When @code{nil}, never queue
+mail.  The default is @code{t}.
+
+@item gnus-agent-prompt-send-queue
+@vindex gnus-agent-prompt-send-queue
+When @code{gnus-agent-prompt-send-queue} is non-@code{nil} Gnus will
+prompt you to confirm that you really wish to proceed if you hit
+@kbd{J S} while unplugged.  The default is @code{nil}.
 
 @item gnus-agent-auto-agentize-methods
 @vindex gnus-agent-auto-agentize-methods

[-- Attachment #3: Type: text/plain, Size: 241 bytes --]


-- 
Gaute Strokkenes                        http://www.srcf.ucam.org/~gs234/
If a person is FAMOUS in this country, they have to go on the ROAD
 for MONTHS at a time and have their name misspelled on the SIDE
 of a GREYHOUND SCENICRUISER!!

Re: Gnus v5.10.5 is released

[Lars Magne Ingebrigtsen]

Gaute B Strokkenes <biggaute@uwc.net> writes:

> I think that the patch should be applied now since it is small and
> tidy, serves a demonstrable need and has been very thoroughly tested
> by yours truly in the months following May (more than half a year).

It's a new feature, so it'll have to wait until No Gnus.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Gnus v5.10.5 is released

[Gaute B Strokkenes]

On  4 jan 2004, larsi@gnus.org wrote:

> Gaute B Strokkenes <biggaute@uwc.net> writes:
>
>> I think that the patch should be applied now since it is small and
>> tidy, serves a demonstrable need and has been very thoroughly
>> tested by yours truly in the months following May (more than half a
>> year).
>
> It's a new feature, so it'll have to wait until No Gnus.

It was my impression that that particular good intention went out the
window rather quickly, but never mind.

But now that we've started No Gnus, would it be possible to have the
patch applied?

-- 
Gaute Strokkenes                        http://www.srcf.ucam.org/~gs234/
Did you GAIN WEIGHT in th' past 5 MINUTES or am I just DREAMING of two
 BROCCOLI FLORETS lying in an empty GAS TANK?

Re: Gnus v5.10.5 is released

[Simon Josefsson]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Possibly the last Gnus 5.10 release.

Perhaps it would be useful to create a branch for 5.10 before starting
No Gnus?  Then there can be more 5.10 releases if any bugs are found.
But you probably already thought of this.

Re: Gnus v5.10.5 is released

[Steinar Bang]

>>>>> Simon Josefsson <jas@extundo.com>:

> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>> Possibly the last Gnus 5.10 release.

> Perhaps it would be useful to create a branch for 5.10 before starting
> No Gnus?  Then there can be more 5.10 releases if any bugs are found.
> But you probably already thought of this.

As long as a release is tagged, you can put a branch tag there
anytime.

Eg.
	cvs rtag -b -r v5-10-5 b5-10-5 gnus
(or something like that)

Re: Gnus v5.10.5 is released

[Lars Magne Ingebrigtsen]

Steinar Bang <sb@dod.no> writes:

> As long as a release is tagged, you can put a branch tag there
> anytime.
>
> Eg.
> 	cvs rtag -b -r v5-10-5 b5-10-5 gnus
> (or something like that)

Right.  I've never actually branched anywhere using cvs...  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Gnus v5.10.5 is released

[Steinar Bang]

>>>>> Lars Magne Ingebrigtsen <larsi@gnus.org>:

> Steinar Bang <sb@dod.no> writes:
>> As long as a release is tagged, you can put a branch tag there
>> anytime.

>> Eg.
>> 	cvs rtag -b -r v5-10-5 b5-10-5 gnus
>> (or something like that)

> Right.  I've never actually branched anywhere using cvs...  :-)

If you don't plan to merge the branch back in, it isn't really hard.

 - with a command like the above you place a branch tag at the point
   where you would like the branch to start.  As for naming the branch
   tags, in the example above, I've given the branch tag the same name
   as the version tag at its root, but with the "v" replaced with a
   "b"

 - then check out a separate Gnus CVS workspace on the branch, eg.:
	cd /tmp/
	cvs co gnus
	cvs up -dP -r b5-10-5
	mv /tmp/gnus ~/cvs/gnus-5.10-branch

All commits you make in this workspace (including adds and removes)
will be on the branch.  What you'll see on updates is commits other
maintainers have made on the branch.  Files that have been removed in
the trunk after the branch, will still be present, editable and
commitable on the branch.

Re: Gnus v5.10.5 is released

[Wes Hardaker]

>>>>> On Mon, 05 Jan 2004 21:16:16 +0100, Steinar Bang <sb@dod.no> said:

>> Right.  I've never actually branched anywhere using cvs...  :-)

Steinar> If you don't plan to merge the branch back in, it isn't
Steinar> really hard.

Actually, even if you do it frequently isn't too bad.  I have used
many branches for the Net-SNMP development over the years, and if you
follow some basic guidelines merging branches back into the head at
regular intervals (thats the hard part) works fairly well.

-- 
"In the bathtub of history the truth is harder to hold than the soap,
 and much more difficult to find."  -- Terry Pratchett

Re: Gnus v5.10.5 is released

[Lars Magne Ingebrigtsen]

Steinar Bang <sb@dod.no> writes:

> If you don't plan to merge the branch back in, it isn't really hard.

[explanation elided]

That was quite easy, indeed, so if it turns out that we have to do
another Gnus 5.10.x release, I'll know how to do it...

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen