Re: gnus-convert-image-to-face-command

[Romain FRANCOISE <romain@orebokech.com>]

Simon Josefsson <jas@extundo.com> writes:

> The user may change the command to use jpegtopnm or something entirely
> different, and then the variable documentation would be confusing.  If
> the user isn't supposed to be able to alter the command, perhaps it
> should be made into a constant.

Ah!  Yes, good point.  I really don't know if the user is supposed to
change the command, I guess if there's only one way to do it, he doesn't
need to.

> What do you think of the following solution as a compromise?

>   "Command for converting an image to an X-Face.
> The default is to convert from GIF images by using giftopnm and some
> other programs."

I think we must at least give the expected image format in the functions
docstrings, so that the user knows what file to give at the prompt,
otherwise she'll be confused.  Your suggestion looks fine, can you cook
something up for the function definitions as well?

(In `gnus-convert-image-to-face-command', "X-Face" should be "Face", by
the way--your patch didn't fix it.)

-- 
Romain FRANCOISE <romain@orebokech.com> | The moon is closer to the sun
it's a miracle -- http://orebokech.com/ | than I am to anyone.