Gnus development mailing list
 help / color / mirror / Atom feed
From: Colin Walters <walters@cis.ohio-state.edu>
Subject: problem in `nnheader-report'?
Date: 30 Apr 2001 15:21:18 -0400	[thread overview]
Message-ID: <87lmoiurbl.church.of.emacs@space-ghost.verbum.org> (raw)

In CVS, there seems to be a problem with either the function
`nnheader-report', or some of the calls to it in
`nntp-retrieve-groups'.  For example, the code:

(unless (gnus-buffer-live-p buf)
	  (error
	   (nnheader-report 'nntp "Connection to %s is closed." server)))

in nntp.el seems to expect nnheader-report to return a string, but it
currently always returns nil.  So here's a patch which should make it
return the string.  I'm not sure if this is the correct fix or not,
but it seems to work.

2001-04-30  Colin Walters  <walters@cis.ohio-state.edu>

	* nnheader.el (nnheader-report): Return the string instead of nil.

diff -u /usr/local/share/emacs/site-lisp/gnus/nnheader.el\~ /usr/local/share/emacs/site-lisp/gnus/nnheader.el
--- /usr/local/share/emacs/site-lisp/gnus/nnheader.el~	Mon Apr 30 14:42:45 2001
+++ /usr/local/share/emacs/site-lisp/gnus/nnheader.el	Mon Apr 30 14:57:26 2001
@@ -687,8 +687,7 @@
   (set (intern (format "%s-status-string" backend))
        (if (< (length args) 2)
 	   (car args)
-	 (apply 'format args)))
-  nil)
+	 (apply 'format args))))
 
 (defun nnheader-get-report (backend)
   "Get the most recent report from BACKEND."



             reply	other threads:[~2001-04-30 19:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-04-30 19:21 Colin Walters [this message]
2001-04-30 21:39 ` ShengHuo ZHU

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lmoiurbl.church.of.emacs@space-ghost.verbum.org \
    --to=walters@cis.ohio-state.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).