From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/36072
Path: main.gmane.org!not-for-mail
From: Colin Walters <walters@cis.ohio-state.edu>
Newsgroups: gmane.emacs.gnus.general
Subject: problem in `nnheader-report'?
Date: 30 Apr 2001 15:21:18 -0400
Organization: The Ohio State University Dept. of Computer and Info. Science
Sender: walters@verbum.org
Message-ID: <87lmoiurbl.church.of.emacs@space-ghost.verbum.org>
NNTP-Posting-Host: coloc-standby.netfonds.no
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: main.gmane.org 1035171719 6615 80.91.224.250 (21 Oct 2002 03:41:59 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Mon, 21 Oct 2002 03:41:59 +0000 (UTC)
Return-Path: <owner-ding@gnus.org>
Original-Received: (qmail 21627 invoked by alias); 30 Apr 2001 21:05:48 -0000
Original-Received: (qmail 21622 invoked from network); 30 Apr 2001 21:05:43 -0000
Original-Received: from mail.cis.ohio-state.edu (HELO cis.ohio-state.edu) (root@164.107.115.5)
  by gnus.org with SMTP; 30 Apr 2001 21:05:43 -0000
Original-Received: from verbum.org (root@gold.cis.ohio-state.edu [164.107.112.16])
	by cis.ohio-state.edu (8.9.1/8.9.1) with ESMTP id RAA21661
	for <ding@gnus.org>; Mon, 30 Apr 2001 17:05:42 -0400 (EDT)
Original-Received: from meta.verbum.org (meta.verbum.org [192.168.5.76])
	by verbum.org (Postfix (Debian/GNU)) with ESMTP id 1D7447DF6
	for <ding@gnus.org>; Mon, 30 Apr 2001 17:05:37 -0400 (EDT)
Original-Received: by meta.verbum.org (Postfix (Debian/GNU), from userid 1000)
	id C7A5C1036F; Mon, 30 Apr 2001 17:02:47 -0400 (EDT)
Resent-Sender: walters@verbum.org
Resent-To: ding@gnus.org
Resent-X-Attribution: Colin
Resent-X-Face: %'w-_>8Mj2_'=;I$myE#]G"'D>x3CY_rk,K06:mXFUvWy>;3I"BW3_-MAiUby{O(mn"wV@m
 dd`)Vk[27^^Sa<qRKA=qTu-uV/qLcGrMm-}A24N2wgr)5%_46(#WMTajfXc_DBt)&'/(J1
Resent-From: Colin Walters <walters@cis.ohio-state.edu>
Resent-Date: 30 Apr 2001 17:02:46 -0400
X-From-Line: nobody Mon Apr 30 15:21:19 2001
Original-Sender: walters@space-ghost.verbum.org
Original-To: ding@gnus.org
X-Attribution: Colin
X-Face: %'w-_>8Mj2_'=;I$myE#]G"'D>x3CY_rk,K06:mXFUvWy>;3I"BW3_-MAiUby{O(mn"wV@m
 dd`)Vk[27^^Sa<qRKA=qTu-uV/qLcGrMm-}A24N2wgr)5%_46(#WMTajfXc_DBt)&'/(J1
Mail-Followup-To: ding@gnus.org
User-Agent: Gnus/5.090003 (Oort Gnus v0.03) Emacs/21.0.102
Resent-Message-Id: <20010430210247.C7A5C1036F@meta.verbum.org>
Original-Lines: 31
Xref: main.gmane.org gmane.emacs.gnus.general:36072
X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:36072

In CVS, there seems to be a problem with either the function
`nnheader-report', or some of the calls to it in
`nntp-retrieve-groups'.  For example, the code:

(unless (gnus-buffer-live-p buf)
	  (error
	   (nnheader-report 'nntp "Connection to %s is closed." server)))

in nntp.el seems to expect nnheader-report to return a string, but it
currently always returns nil.  So here's a patch which should make it
return the string.  I'm not sure if this is the correct fix or not,
but it seems to work.

2001-04-30  Colin Walters  <walters@cis.ohio-state.edu>

	* nnheader.el (nnheader-report): Return the string instead of nil.

diff -u /usr/local/share/emacs/site-lisp/gnus/nnheader.el\~ /usr/local/share/emacs/site-lisp/gnus/nnheader.el
--- /usr/local/share/emacs/site-lisp/gnus/nnheader.el~	Mon Apr 30 14:42:45 2001
+++ /usr/local/share/emacs/site-lisp/gnus/nnheader.el	Mon Apr 30 14:57:26 2001
@@ -687,8 +687,7 @@
   (set (intern (format "%s-status-string" backend))
        (if (< (length args) 2)
 	   (car args)
-	 (apply 'format args)))
-  nil)
+	 (apply 'format args))))
 
 (defun nnheader-get-report (backend)
   "Get the most recent report from BACKEND."