* problem in `nnheader-report'?
@ 2001-04-30 19:21 Colin Walters
2001-04-30 21:39 ` ShengHuo ZHU
0 siblings, 1 reply; 2+ messages in thread
From: Colin Walters @ 2001-04-30 19:21 UTC (permalink / raw)
In CVS, there seems to be a problem with either the function
`nnheader-report', or some of the calls to it in
`nntp-retrieve-groups'. For example, the code:
(unless (gnus-buffer-live-p buf)
(error
(nnheader-report 'nntp "Connection to %s is closed." server)))
in nntp.el seems to expect nnheader-report to return a string, but it
currently always returns nil. So here's a patch which should make it
return the string. I'm not sure if this is the correct fix or not,
but it seems to work.
2001-04-30 Colin Walters <walters@cis.ohio-state.edu>
* nnheader.el (nnheader-report): Return the string instead of nil.
diff -u /usr/local/share/emacs/site-lisp/gnus/nnheader.el\~ /usr/local/share/emacs/site-lisp/gnus/nnheader.el
--- /usr/local/share/emacs/site-lisp/gnus/nnheader.el~ Mon Apr 30 14:42:45 2001
+++ /usr/local/share/emacs/site-lisp/gnus/nnheader.el Mon Apr 30 14:57:26 2001
@@ -687,8 +687,7 @@
(set (intern (format "%s-status-string" backend))
(if (< (length args) 2)
(car args)
- (apply 'format args)))
- nil)
+ (apply 'format args))))
(defun nnheader-get-report (backend)
"Get the most recent report from BACKEND."
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: problem in `nnheader-report'?
2001-04-30 19:21 problem in `nnheader-report'? Colin Walters
@ 2001-04-30 21:39 ` ShengHuo ZHU
0 siblings, 0 replies; 2+ messages in thread
From: ShengHuo ZHU @ 2001-04-30 21:39 UTC (permalink / raw)
Colin Walters <walters@cis.ohio-state.edu> writes:
> In CVS, there seems to be a problem with either the function
> `nnheader-report', or some of the calls to it in
> `nntp-retrieve-groups'. For example, the code:
>
> (unless (gnus-buffer-live-p buf)
> (error
> (nnheader-report 'nntp "Connection to %s is closed." server)))
>
> in nntp.el seems to expect nnheader-report to return a string, but it
> currently always returns nil. So here's a patch which should make it
> return the string. I'm not sure if this is the correct fix or not,
> but it seems to work.
It's my fault for adding these error codes. Actually, nnheader-report
should always return nil, because most backends use nnheader-report to
return nil. I'll install a patch in minutes.
ShengHuo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2001-04-30 21:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-04-30 19:21 problem in `nnheader-report'? Colin Walters
2001-04-30 21:39 ` ShengHuo ZHU
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).