From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 30958 invoked from network); 22 Mar 2022 18:55:29 -0000 Received: from mx1.math.uh.edu (129.7.128.32) by inbox.vuxu.org with ESMTPUTF8; 22 Mar 2022 18:55:29 -0000 Received: from lists1.math.uh.edu ([129.7.128.208]) by mx1.math.uh.edu with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nWjfC-005DBQ-MG for ml@inbox.vuxu.org; Tue, 22 Mar 2022 13:55:27 -0500 Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by lists1.math.uh.edu with smtp (Exim 4.94.2) (envelope-from ) id 1nWjfB-00674q-UP for ml@inbox.vuxu.org; Tue, 22 Mar 2022 13:55:25 -0500 Received: from mx2.math.uh.edu ([129.7.128.33]) by lists1.math.uh.edu with esmtp (Exim 4.94.2) (envelope-from ) id 1nWhhH-0066fX-9c for ding@lists.math.uh.edu; Tue, 22 Mar 2022 11:49:27 -0500 Received: from quimby.gnus.org ([95.216.78.240]) by mx2.math.uh.edu with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nWhhF-00AXhT-6M for ding@lists.math.uh.edu; Tue, 22 Mar 2022 11:49:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wNkOhKEhUlwAUwd6hUxi58FQ5z/08S6e4EZMtUUFSvc=; b=fujZOMtUVL7+xOFW3voUTe8Uyo 4/18j6mZiuaNPkFp4kOTviCroJREGSDuLrUiYv6MdlRPdcP0mlQTqCQPYuv0GoKjRGTXlv+F4WGYs oSfHjHF1u/Wc+LwMfyIBmfcWSeLMJ0d4/Y4zNOYDmeaAc7tGLmdWbsiEQMpGe3/Ad7Ys=; Received: from eggs.gnu.org ([209.51.188.92]) by quimby.gnus.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWhh8-0008I6-Ax; Tue, 22 Mar 2022 17:49:20 +0100 Received: from [2001:470:142:3::e] (port=41388 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWhh5-0004kV-OM; Tue, 22 Mar 2022 12:49:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=wNkOhKEhUlwAUwd6hUxi58FQ5z/08S6e4EZMtUUFSvc=; b=bpuCcHQTlN+yn/FYGIJ1 GcO4SYQ+vbujCq8Yx+CMILWnRATf45Rj4fQ/63yIaJg20xQ/QYutx05hJtew+MAN3e84OhFL4RsqW 82+7tpuFcGgcrTZgZUPdONXSyz1NGlmctiFraSus3uxSVhA2CWpPlLNEWWi1fX6Q8mUtNed4Cqy/k HzphUcT++sQC2zRwi0knoCpVYi3DGc35ewlEy0D0BlUuESULXOjQR2JF0TR4JTOFpoqOJSp4rzZOq 5U774CLQBio1K8WXPAUcfiZ2RNSIBGMhCDZXVOZl3uebmihlWv92vh3+bMwzcHHCALwLc6KdJg7Sj wH4MB5InpD0ZFQ==; Received: from lukas.physics.niu.edu ([131.156.224.124]:35744 helo=lukas) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nWhh5-00011d-FZ; Tue, 22 Mar 2022 12:49:15 -0400 From: Roland Winkler To: Sam Steingold Cc: 54423@debbugs.gnu.org, ding@gnus.org, bbdb-user@nongnu.org, Lars Ingebrigtsen Subject: Re: bug#54423: 29.0.50; gnus-fetch-original-field returns nil in digest References: <87ee30vo80.fsf@gnus.org> <87cziku6kv.fsf@gnus.org> <87k0cssiaw.fsf@gnus.org> Date: Tue, 22 Mar 2022 11:49:14 -0500 In-Reply-To: (Sam Steingold's message of "Mon, 21 Mar 2022 20:04:53 -0400") Message-ID: <87mthi7x11.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain List-ID: Precedence: bulk On Mon, Mar 21 2022, Sam Steingold wrote: > Lars suggested that I use this: > > (gnus-info-params (gnus-get-info gnus-newsgroup-name)) > > and it appears that the following works: > [snip] > + (and-let* ((i (gnus-get-info gnus-newsgroup-name)) > + (p (gnus-info-params i)) > + (parent-summary-buffer (cadr (assq 'quit-config p)))) > + (with-current-buffer parent-summary-buffer > + (gnus-fetch-original-field header))))) ...Is the (and-let*... needed? Of course, one could wrap all code that way. But and-let* is not even part of Emacs 25 that current BBDB is supposed to support. Also, if the above code should fail in certain cases, it might be an indication that the above code is not yet exactly what is needed so that this should not be swept under the carpet. So I feel that (with-current-buffer (cadr (assq 'quit-config (gnus-info-params (gnus-get-info gnus-newsgroup-name)))) is the better way to go. Am I missing something? Or: If the corner cases when the code can still fail are known and the failure is in that sense intentional, this should be made more explicit in the code.