From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: Tassilo Horn <tsdh@gnu.org>
Cc: ding@gnus.org
Subject: Re: nnir-summary-line-format doesn't work
Date: Sat, 06 Jun 2020 13:10:32 -0700 [thread overview]
Message-ID: <87mu5grm4n.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <87a71gsg6e.fsf@gnu.org> (Tassilo Horn's message of "Sat, 06 Jun 2020 11:21:29 +0200")
Tassilo Horn <tsdh@gnu.org> writes:
> Hi all,
>
> it seems like `nnir-summary-line-format' doesn't work in the current
> Emacs master (and probably hasn't worked for ages). It gets set as
> `gnus-summary-line-format' in `nnir-mode' which is called in
> `gnus-summary-prepared-hook'. However, at that point, the summary
> buffer is already built using the original `gnus-summary-line-format'
> value.
>
> The patch below fixes this problem. Could someone with a bit more Gnus
> knowledge have a look at it and tell me if IDRT?
I would expect that you can just move all of `nnir-mode' to
`gnus-summary-generate-hook'. The only other thing `nnir-mode' does is
mess with the article-(delete|move|expire)-hook, and those hooks have
all had their local values set by this stage.
It would be a simpler solution, anyway -- try it out and see if anything
goes wrong?
next prev parent reply other threads:[~2020-06-06 20:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-06 9:21 Tassilo Horn
2020-06-06 20:10 ` Eric Abrahamsen [this message]
2020-06-07 8:04 ` Tassilo Horn
2020-06-07 15:36 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mu5grm4n.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=ding@gnus.org \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).