From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/87710 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.gnus.general,gmane.emacs.devel Subject: Re: Gnus work Date: Wed, 04 Oct 2017 11:53:08 -0700 Message-ID: <87mv56d9t7.fsf@ericabrahamsen.net> References: <87vajudasc.fsf@ericabrahamsen.net> <86376y7nyy.fsf@zoho.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1507143230 11921 195.159.176.226 (4 Oct 2017 18:53:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 4 Oct 2017 18:53:50 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) Cc: emacs-devel@gnu.org To: ding@gnus.org Original-X-From: ding-owner+m35924=ding+2daccount=gmane.org@lists.math.uh.edu Wed Oct 04 20:53:46 2017 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from mxfilter-048034.atla03.us.yomura.com ([107.189.48.34]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzong-0002Q3-V0 for ding-account@gmane.org; Wed, 04 Oct 2017 20:53:45 +0200 X-Yomura-MXScrub: 1.0 Original-Received: from lists1.math.uh.edu (unknown [129.7.128.208]) by mxfilter-048034.atla03.us.yomura.com (Halon) with ESMTPS id 500f9fc2-a935-11e7-8b7f-b499baa2b07a; Wed, 04 Oct 2017 18:53:30 +0000 (UTC) Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by lists1.math.uh.edu with smtp (Exim 4.87) (envelope-from ) id 1dzonR-0006zj-NB for ding-account@gmane.org; Wed, 04 Oct 2017 13:53:29 -0500 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by lists1.math.uh.edu with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1dzonQ-0006zd-8B for ding@lists.math.uh.edu; Wed, 04 Oct 2017 13:53:28 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtps (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.87) (envelope-from ) id 1dzonP-0001Cx-1w for ding@lists.math.uh.edu; Wed, 04 Oct 2017 13:53:28 -0500 Original-Received: from [195.159.176.226] (helo=blaine.gmane.org) by quimby.gnus.org with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1dzonN-0002J8-Hw for ding@gnus.org; Wed, 04 Oct 2017 20:53:25 +0200 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1dzonE-0007s3-2P for ding@gnus.org; Wed, 04 Oct 2017 20:53:16 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Followup-To: gmane.emacs.gnus.general Original-Lines: 28 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:wkXV335J3KcRXko8RMkcLCab8OM= List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:87710 gmane.emacs.devel:219086 Archived-At: Emanuel Berg writes: > Eric Abrahamsen wrote: > >> I've been very slowly reading the Gnus code >> base, and looking at how to go about doing >> some refactoring, cleanups, and a few >> new features. > > What strikes me immediately when I read the > Gnus source is that the defuns are often very, > very long. But I'm not suggesting anyone do > something about it for that reason alone. > However if anyone does work on a defun and has > thus acquired a close to complete understanding > of it, it could be considered breaking it up, > possibly repeatedly, as the last step of work, > and then along lines that are as natural > as possible, of course. I think the main problem is not so much that the defuns are long, but that they do too much, there's overlap, and there's lots of work-by-side-effect. A long defun wouldn't be so bad if you could scan it and feel confident that you knew what it was doing. What I *do* think is a problem is that variables and functions are named inconsistently, and often confusingly. It just makes debugging that much harder. But on the other hand, renaming just for renaming's sake...