From: Tassilo Horn <tassilo@member.fsf.org>
To: Ted Zlatanov <tzz@lifelogs.com>
Cc: ding@gnus.org, Andreas Schwab <schwab@linux-m68k.org>
Subject: Re: Debugger entered--Lisp error: (overflow-error "13419098521433281274")
Date: Thu, 03 Mar 2011 09:11:18 +0100 [thread overview]
Message-ID: <87mxlcpqs9.fsf@member.fsf.org> (raw)
In-Reply-To: <871v2pkzrg.fsf@lifelogs.com> (Ted Zlatanov's message of "Wed, 02 Mar 2011 14:56:19 -0600")
Ted Zlatanov <tzz@lifelogs.com> writes:
Hi Ted,
>>> To fix it now, I would replace such large numbers with a truncated
>>> version, which can be done safely with a regex before the reader
>>> sees the input. But I'll let Lars decide, he knows that code best.
>
> TH> But that huge number is not used by gnus, anyway. It is `read'
> TH> but only the UID and FLAGS values are saved. So IMHO, the proper
> TH> fix is to put a condition-case around the `read' that picks the
> TH> UID and FLAGS with string-matching if an overflow-error occurs.
>
> Yeah, that would work too, but it's a hack either way. My way would
> be less work since we just rewrite that number to 1 or whatever, which
> is one extra line of code. If you want to submit a patch for either
> hack go ahead, otherwise I'll wait for Lars to fix it.
I've now combined both approaches. A condition-case handler simply
deletes the big number and `read's again. That fixes the issue for me.
I added a FIXME and comment, too. Maybe Lars has some better idea how
to deal with that.
Since that number occurs as value of MODSEQ (which Gnus doesn't use), is
the HIGHESTMODSEQ (which Gnus reads and stores as number) also a
candidate for overflowing? It probably is, so it might be better to
handle it as string just like the UIDVALIDITY.
Bye,
Tassilo
--
Sent from my Emacs
next prev parent reply other threads:[~2011-03-03 8:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 15:28 Tassilo Horn
2011-03-02 17:52 ` Tassilo Horn
2011-03-02 19:00 ` Andreas Schwab
2011-03-02 19:24 ` Tassilo Horn
2011-03-02 20:17 ` Ted Zlatanov
2011-03-02 20:36 ` Tassilo Horn
2011-03-02 20:52 ` Andreas Schwab
2011-03-02 21:02 ` Tassilo Horn
2011-03-02 20:56 ` Ted Zlatanov
2011-03-03 8:11 ` Tassilo Horn [this message]
2011-03-04 14:59 ` Ted Zlatanov
2011-03-05 10:52 ` Lars Magne Ingebrigtsen
2011-03-05 10:55 ` Lars Magne Ingebrigtsen
2011-03-07 17:29 ` Ted Zlatanov
2011-03-15 16:50 ` Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mxlcpqs9.fsf@member.fsf.org \
--to=tassilo@member.fsf.org \
--cc=ding@gnus.org \
--cc=schwab@linux-m68k.org \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).