Gnus development mailing list
 help / color / mirror / Atom feed
From: Julien Danjou <julien@danjou.info>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: ding@gnus.org
Subject: Re: Error on leaving Gnus group
Date: Tue, 08 Feb 2011 10:46:03 +0100	[thread overview]
Message-ID: <87mxm62wp8.fsf@keller.adm.naquadah.org> (raw)
In-Reply-To: <87lj1tut67.fsf@stupidchicken.com>

[-- Attachment #1: Type: text/plain, Size: 2191 bytes --]

On Sun, Feb 06 2011, Chong Yidong wrote:

> Debugger entered--Lisp error: (error "No 1.0 specs in (vertical 1 (group 1 point))")
>   signal(error ("No 1.0 specs in (vertical 1 (group 1 point))"))
>   error("No 1.0 specs in %s" (vertical 1 (group 1 point)))
>   gnus-configure-frame((vertical 1.0 (group 1 point)))
>   gnus-configure-windows(group force)
>   gnus-summary-exit()
>   call-interactively(gnus-summary-exit nil nil)
>
> This problem was introduced by this change:
>
>
> 2011-01-28  Julien Danjou  <julien@danjou.info>
>
> 	* gnus-win.el: Remove dead function gnus-window-configuration-element.
> 	(gnus-all-windows-visible-p): Remove old compatibility code.
> 	(gnus-window-top-edge): Add docstring.
>
> If I put the "old compatibility code" back into
> gnus-all-windows-visible-p, the error is not signalled.  Dunno what the
> "old compatibility" refers to; I don't have much in the way of Gnus
> customization, and using a fresh .newsrc.eld file gives the same error.
>
> Does this ring a bell for anyone?  If not, I can try making a test case.

This is real diff behind that change:
--- a/lisp/gnus-win.el
+++ b/lisp/gnus-win.el
@@ -437,11 +437,7 @@ should have point."
        type buffer win buf)
     (while (and (setq split (pop stack))
                all-visible)
-      ;; Be backwards compatible.
-      (when (vectorp split)
-       (setq split (append split nil)))
-      (when (or (consp (car split))
-               (vectorp (car split)))
+      (when (consp (car split))
        (push 1.0 split)
        (push 'vertical split))
       ;; The SPLIT might be something that is to be evaled to

I do not think it's wrong. There's no vector involed here.

In your backtrace I see
   gnus-configure-frame((vertical 1.0 (group 1 point)))

I cannot find such a line in Gnus code source.

In gnus-win there something that looks like it which is:
  '((group
     (vertical 1.0
	       (group 1.0 point)))

But it's 1 dot zero.

So I don't get where it come from. Maybe you have an very definition of
the gnus-buffer-configuration variable? If that's possible.

-- 
Julien Danjou
❱ http://julien.danjou.info

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

  parent reply	other threads:[~2011-02-08  9:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-06 14:36 Chong Yidong
2011-02-07 16:32 ` Lars Ingebrigtsen
2011-02-07 18:15   ` Julien Danjou
2011-02-07 18:35   ` Chong Yidong
2011-02-08  9:46 ` Julien Danjou [this message]
2011-02-14  2:42   ` Lars Ingebrigtsen
2011-02-14  4:12     ` Chong Yidong
2011-02-14  5:14     ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mxm62wp8.fsf@keller.adm.naquadah.org \
    --to=julien@danjou.info \
    --cc=cyd@stupidchicken.com \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).