Re: nnir and move

[Ted Zlatanov <tzz@lifelogs.com>]

On Wed, 10 Nov 2010 13:42:28 -0500 Andrew Cohen <cohen@andy.bu.edu> wrote: 

>>>>>> "Ted" == Ted Zlatanov <tzz@lifelogs.com> writes:
Ted> Could you use nnir-original-group and nnir-original-subject in
Ted> the let you said you would do?  I'll make the names more
Ted> general if anyone else needs it but I was thinking this way
Ted> it's clear that it's a nnir requirement.

Ted> That way the registry will not care what nnir does to the
Ted> subject or group name, it will just take the originals from the
Ted> let-bound variables.

AC> In fact I'm thinking about a different way (but this might not be best
AC> way):


AC> 1. nnir ends up replacing the parsed header with a new one, so the
AC> original subject isn't available anymore, but its easy enough to get
AC> back with a simple string-match. And the only place the original subject
AC> is used is in the registry, which is why I thought that it was best to
AC> just modify gnus-registry-simplify-subject to:

AC> (defun gnus-registry-simplify-subject (subject)
AC>   (if (stringp subject)
AC>       (progn
AC> 	(string-match "^\\[[0-9]+:.+/[0-9]+\\] " subject)
AC> 	(setq subject (substring subject (match-end 0)))
AC> 	(gnus-simplify-subject subject))
AC>     nil))

I don't like this: it will fail if a user has that subject accidentally.
Better to get the original unambigously as we get the group.

AC> 2. As for the original newsgroup name, I am trying to avoid anything
AC> nnir specific outside the nnir.el file.

OK.

AC> Its also possible that other/future virtual backends might want to
AC> do something similar so I've tried an approach that won't require
AC> special-casing. The trick is to pass the original newsgroup name
AC> back in to gnus-summary-move-article. I think this is easy---just
AC> introduce a let-bound variable gnus-original-newsgroup-name
AC> initialized to gnus-newsgroup-name and let the backend-specific
AC> 'request-move-article replace it as needed. So only a few lines of
AC> changes and no need for nnir-specific code.

OK, but the variable should not be defined in nnir.el.  I would define
`gnus-original-article-group' and `gnus-original-article-subject' in
gnus.el.

Ted