Re: Automatically authenticating at local imap server

Re: Automatically authenticating at local imap server

[Tassilo Horn]

The following message is a courtesy copy of an article
that has been posted to gmane.emacs.gnus.user as well.

Reiner Steib <reinersteib+gmane@imap.cc> writes:

Hi Reiner,

> On Mon, Feb 04 2008, Tassilo Horn wrote:
>
>> The problem is, that in my ~/.authinfo I specified the port as imap (or
>> now I omit it) and on the gnus side I said 143.  So
>> `netrc-machine-user-or-password' is called with ports = ("143") and
>> defaults = ("imap" "imaps") which won't find a match.
>>
>> I think the right fix would be to add "143" and "993" to the call of
>> `netrc-machine-user-or-password' in `nnimap-open-connection', because
>> these are the default ports for imap and imaps.
>
> Would you like to submit a patch?  (Please send it to ding@gnu.org)

Sure, so here it is.

--8<---------------cut here---------------start------------->8---
Index: lisp/nnimap.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/nnimap.el,v
retrieving revision 7.41
diff -u -r7.41 nnimap.el
--- lisp/nnimap.el	20 Jan 2008 05:23:57 -0000	7.41
+++ lisp/nnimap.el	7 Feb 2008 09:55:03 -0000
@@ -802,7 +802,7 @@
 			(or nnimap-server-address
 			    nnimap-address))
 		  (list port)
-		  (list "imap" "imaps")))
+		  (list "imap" "imaps" "143" "993")))
 	   (passwd (netrc-machine-user-or-password
 		    "password"
 		    list
@@ -810,7 +810,7 @@
 			  (or nnimap-server-address
 			      nnimap-address))
 		    (list port)
-		    (list "imap" "imaps"))))
+		    (list "imap" "imaps" "143" "993"))))
       (if (imap-authenticate user passwd nnimap-server-buffer)
 	  (prog2
 	      (setq nnimap-server-buffer-alist
--8<---------------cut here---------------end--------------->8---

And here's a ChangeLog entry.

--8<---------------cut here---------------start------------->8---
2008-02-07  Tassilo Horn  <tassilo@member.fsf.org>

	* nnimap.el (nnimap-open-connection): Add "143" and "993" as default
	ports to the calls to `netrc-machine-user-or-password' in addition to
	"imap" and "imaps".
--8<---------------cut here---------------end--------------->8---

Bye,
Tassilo

Re: Automatically authenticating at local imap server

[Reiner Steib]

On Thu, Feb 07 2008, Tassilo Horn wrote:

> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>> On Mon, Feb 04 2008, Tassilo Horn wrote:
>>> I think the right fix would be to add "143" and "993" to the call of
>>> `netrc-machine-user-or-password' in `nnimap-open-connection', because
>>> these are the default ports for imap and imaps.
>>
>> Would you like to submit a patch?  (Please send it to ding@gnu.org)
[...]
> 2008-02-07  Tassilo Horn  <tassilo@member.fsf.org>
>
> 	* nnimap.el (nnimap-open-connection): Add "143" and "993" as default
> 	ports to the calls to `netrc-machine-user-or-password' in addition to
> 	"imap" and "imaps".

Applied, thanks.

Could you please check if the manual needs to be changed as well?

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Automatically authenticating at local imap server

[Tassilo Horn]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

Hi Reiner,

> Could you please check if the manual needs to be changed as well?

I had a short look at it, and I think it's fine.  Before my change the
docs should have mentioned that the number a user specifies for
nnimap-server-port must `equal' the port value in ~/.authinfo, but now
that's not needed anymore for standard ports.

Bye,
Tassilo

Re: Automatically authenticating at local imap server

[Reiner Steib]

On Thu, Feb 07 2008, Tassilo Horn wrote:

> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>> Could you please check if the manual needs to be changed as well?
>
> I had a short look at it, and I think it's fine.  

Thanks.

> Before my change the docs should have mentioned that the number a
> user specifies for nnimap-server-port must `equal' the port value in
> ~/.authinfo, but now that's not needed anymore for standard ports.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/