Re: patch - nnimap - case handling in STATUS command and response

[Simon Josefsson <simon@josefsson.org>]

nathanw@MIT.EDU (Nathan J. Williams) writes:

>> Note that the server is broken here, the RFC is clear
>> that the status-att are upper case.
>
> Ah. Can you let me know where it says that? I was going from the
> formal syntax at the end of RFC3501, where it says:
>
>         (1) Except as noted otherwise, all alphabetic characters
>         are case-insensitive.  The use of upper or lower case
>         characters to define token strings is for editorial clarity
>         only.  Implementations MUST accept these strings in a
>         case-insensitive fashion.
>
> and I didn't see anything specially marked about the case of
> status-att (or, in fact, anything other than the issues around INBOX).

You are right!  So your patch is indeed the right thing to do.

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> ,----
> | 	* imap.el (imap-mailbox-status-asynch): Upcase STATUS items.
> | 	(imap-parse-status): Upcase status-att for broken servers that sends
> | 	them lower-case (e.g., MS Exchange 2007).
> `----
>
> I think this explanations should be added as a comment(s) in imap.el.

Given that it is incorrect, I modified the ChangeLog entry to read:

2007-12-03  Nathan J. Williams  <nathanw@MIT.EDU>  (tiny change)

	* imap.el (imap-mailbox-status-asynch): Upcase STATUS items.
	(imap-parse-status): Upcase status-att for servers that sends them
	lower-case (e.g., MS Exchange 2007).

Since this was a real bug in imap.el, a comment shouldn't be needed.

Leo <sdl.web@gmail.com> writes:

>> Thanks, applied.  Note that the server is broken here, the RFC is clear
>> that the status-att are upper case.
>
> Should this be added to the comments of the function?

Nope. :)

/Simon