From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/65986 Path: news.gmane.org!not-for-mail From: Simon Josefsson Newsgroups: gmane.emacs.gnus.general Subject: Re: patch - nnimap - case handling in STATUS command and response Date: Tue, 18 Dec 2007 16:42:39 +0100 Message-ID: <87mys86mc0.fsf@mocca.josefsson.org> References: <878x4bhdbp.fsf@mocca.josefsson.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1197992652 5275 80.91.229.12 (18 Dec 2007 15:44:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 18 Dec 2007 15:44:12 +0000 (UTC) Cc: ding@gnus.org To: nathanw@MIT.EDU (Nathan J. Williams) Original-X-From: ding-owner+M14479@lists.math.uh.edu Tue Dec 18 16:44:23 2007 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1J4ecG-0000c2-Ll for ding-account@gmane.org; Tue, 18 Dec 2007 16:44:20 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1J4eay-0000Uo-UA; Tue, 18 Dec 2007 09:43:00 -0600 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1J4eax-0000UX-4n for ding@lists.math.uh.edu; Tue, 18 Dec 2007 09:42:59 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.67) (envelope-from ) id 1J4eaq-0003Ja-T7 for ding@lists.math.uh.edu; Tue, 18 Dec 2007 09:42:59 -0600 Original-Received: from yxa.extundo.com ([83.241.177.38]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1J4eam-0002CO-00 for ; Tue, 18 Dec 2007 16:42:48 +0100 Original-Received: from mocca.josefsson.org (yxa.extundo.com [83.241.177.38]) (authenticated bits=0) by yxa.extundo.com (8.13.4/8.13.4/Debian-3sarge3) with ESMTP id lBIFgekY015732 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 18 Dec 2007 16:42:40 +0100 OpenPGP: id=B565716F; url=http://josefsson.org/key.txt Mail-Copies-To: nobody X-Hashcash: 1:22:071218:nathanw@mit.edu::q8x0d8Vt/JlUjd+Q:0ajn X-Hashcash: 1:22:071218:ding@gnus.org::jhu8tmy/aPikEUq1:BSK2 In-Reply-To: (Nathan J. Williams's message of "Mon, 03 Dec 2007 13:09:25 -0500") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/22.1 (gnu/linux) X-Spam-Status: No, score=-0.0 required=4.0 tests=SPF_PASS autolearn=disabled version=3.1.7 X-Spam-Checker-Version: SpamAssassin 3.1.7 (2006-10-05) on yxa-iv X-Virus-Scanned: ClamAV version 0.88.2, clamav-milter version 0.88.2 on yxa.extundo.com X-Virus-Status: Clean X-Spam-Score: -2.5 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:65986 Archived-At: nathanw@MIT.EDU (Nathan J. Williams) writes: >> Note that the server is broken here, the RFC is clear >> that the status-att are upper case. > > Ah. Can you let me know where it says that? I was going from the > formal syntax at the end of RFC3501, where it says: > > (1) Except as noted otherwise, all alphabetic characters > are case-insensitive. The use of upper or lower case > characters to define token strings is for editorial clarity > only. Implementations MUST accept these strings in a > case-insensitive fashion. > > and I didn't see anything specially marked about the case of > status-att (or, in fact, anything other than the issues around INBOX). You are right! So your patch is indeed the right thing to do. Reiner Steib writes: > ,---- > | * imap.el (imap-mailbox-status-asynch): Upcase STATUS items. > | (imap-parse-status): Upcase status-att for broken servers that sends > | them lower-case (e.g., MS Exchange 2007). > `---- > > I think this explanations should be added as a comment(s) in imap.el. Given that it is incorrect, I modified the ChangeLog entry to read: 2007-12-03 Nathan J. Williams (tiny change) * imap.el (imap-mailbox-status-asynch): Upcase STATUS items. (imap-parse-status): Upcase status-att for servers that sends them lower-case (e.g., MS Exchange 2007). Since this was a real bug in imap.el, a comment shouldn't be needed. Leo writes: >> Thanks, applied. Note that the server is broken here, the RFC is clear >> that the status-att are upper case. > > Should this be added to the comments of the function? Nope. :) /Simon