From: Elias Oltmanns <eo@nebensachen.de>
To: ding@gnus.org
Subject: Re: URIs wrapped in angle brackets are not extracted correctly
Date: Tue, 18 Sep 2007 23:03:52 +0200 [thread overview]
Message-ID: <87myvj65zb.fsf@denkblock.local> (raw)
In-Reply-To: <b4mtzps19ju.fsf@jpl.org>
Katsumi Yamaoka <yamaoka@jpl.org> wrote:
> (I added Cc: ding.)
>
>>>>>> Christoph Conrad wrote:
>> No Gnus v0.7
>> GNU Emacs 23.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2.10.13, multi-tty)
>> of 2007-09-03 on brabbelbox
>> 200 news.gmane.org InterNetNews NNRP server INN 2.4.1 ready (posting ok).
>
>> Hi,
>
>> according to RFC 3986 Appendix C the following URI should be extracted
>> correctly when embedded in angle brackets, containing a line break:
>
> <http://www.faz.net/s/Rub560251485DC24AF181BBEF83E12CA16E/Doc~E990108D4B
> D2D4C29A2BA6460BE3F10EC~ATpl~Ecommon~Scontent.html>
>
>> This is not the case in current cvs-Gnus when pressing <RET>
>> (widget-button-press). Only the first part of the URI before the line
>> break is extracted.
>
> There might be a reason neither `ffap-url-at-point' (ffap.el) nor
> `thing-at-point' (thingatpt.el) works with such data. I tried
> making Gnus work (the patch is attached to this message).
May I just point out another issue with the button logic in article
buffers in general. Whereas gnus-article-add-buttons does evaluate the
form of each gnus-button-alist entry, i.e., (nth 2 entry), to see
whether that particular entry is applicable or not, gnus-push-button
does not. As a result buttons show up correctly in the article buffer.
But if you press enter on a button for which there are two entries in
gnus-button-alist whose regexp matches but only the form of one of them
evaluates to something non nil, gnus-button-push won't care and apply
the first of those two entries it stumbles upon.
I wonder whether the check for (nth 2 entry) should be moved to
gnus-button-entry or whether it should just be added to gnus-button-push
as well.
Regards,
Elias
next prev parent reply other threads:[~2007-09-18 21:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <874phvi0ui.fsf@ID-24456.user.uni-berlin.de>
2007-09-18 11:45 ` Katsumi Yamaoka
2007-09-18 19:26 ` Christoph Conrad
2007-09-18 21:03 ` Elias Oltmanns [this message]
2007-09-29 10:39 ` Reiner Steib
2007-09-29 10:50 ` Christoph Conrad
2007-09-30 23:55 ` Katsumi Yamaoka
2007-10-11 22:09 ` Katsumi Yamaoka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87myvj65zb.fsf@denkblock.local \
--to=eo@nebensachen.de \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).