From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/65211 Path: news.gmane.org!not-for-mail From: Elias Oltmanns Newsgroups: gmane.emacs.gnus.general Subject: Re: URIs wrapped in angle brackets are not extracted correctly Date: Tue, 18 Sep 2007 23:03:52 +0200 Message-ID: <87myvj65zb.fsf@denkblock.local> References: <874phvi0ui.fsf@ID-24456.user.uni-berlin.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1190149496 10487 80.91.229.12 (18 Sep 2007 21:04:56 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 18 Sep 2007 21:04:56 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M13724@lists.math.uh.edu Tue Sep 18 23:04:53 2007 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1IXkFU-0003jC-Dr for ding-account@gmane.org; Tue, 18 Sep 2007 23:04:48 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1IXkEv-0001pm-6S; Tue, 18 Sep 2007 16:04:13 -0500 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1IXkEt-0001pQ-9r for ding@lists.math.uh.edu; Tue, 18 Sep 2007 16:04:11 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtp (Exim 4.67) (envelope-from ) id 1IXkEo-0007LY-Nl for ding@lists.math.uh.edu; Tue, 18 Sep 2007 16:04:11 -0500 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1IXkEf-0003tg-00 for ; Tue, 18 Sep 2007 23:03:57 +0200 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1IXkEl-0002Nm-SF for ding@gnus.org; Tue, 18 Sep 2007 23:04:03 +0200 Original-Received: from pd9e85365.dip.t-dialin.net ([217.232.83.101]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 18 Sep 2007 23:04:03 +0200 Original-Received: from eo by pd9e85365.dip.t-dialin.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 18 Sep 2007 23:04:03 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 42 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: pd9e85365.dip.t-dialin.net User-Agent: Gnus/5.110007 (No Gnus v0.7) Cancel-Lock: sha1:D5hBhK/qKdlfPv7T1RU3g8iXRwI= X-Spam-Score: -2.6 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:65211 Archived-At: Katsumi Yamaoka wrote: > (I added Cc: ding.) > >>>>>> Christoph Conrad wrote: >> No Gnus v0.7 >> GNU Emacs 23.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2.10.13, multi-tty) >> of 2007-09-03 on brabbelbox >> 200 news.gmane.org InterNetNews NNRP server INN 2.4.1 ready (posting ok). > >> Hi, > >> according to RFC 3986 Appendix C the following URI should be extracted >> correctly when embedded in angle brackets, containing a line break: > > D2D4C29A2BA6460BE3F10EC~ATpl~Ecommon~Scontent.html> > >> This is not the case in current cvs-Gnus when pressing >> (widget-button-press). Only the first part of the URI before the line >> break is extracted. > > There might be a reason neither `ffap-url-at-point' (ffap.el) nor > `thing-at-point' (thingatpt.el) works with such data. I tried > making Gnus work (the patch is attached to this message). May I just point out another issue with the button logic in article buffers in general. Whereas gnus-article-add-buttons does evaluate the form of each gnus-button-alist entry, i.e., (nth 2 entry), to see whether that particular entry is applicable or not, gnus-push-button does not. As a result buttons show up correctly in the article buffer. But if you press enter on a button for which there are two entries in gnus-button-alist whose regexp matches but only the form of one of them evaluates to something non nil, gnus-button-push won't care and apply the first of those two entries it stumbles upon. I wonder whether the check for (nth 2 entry) should be moved to gnus-button-entry or whether it should just be added to gnus-button-push as well. Regards, Elias